From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 441E8C61DD8 for ; Sat, 14 Nov 2020 19:17:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 075A722263 for ; Sat, 14 Nov 2020 19:17:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726310AbgKNTQq (ORCPT ); Sat, 14 Nov 2020 14:16:46 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:39033 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726239AbgKNTQq (ORCPT ); Sat, 14 Nov 2020 14:16:46 -0500 X-Greylist: delayed 78586 seconds by postgrey-1.27 at vger.kernel.org; Sat, 14 Nov 2020 14:16:45 EST X-Originating-IP: 86.194.74.19 Received: from localhost (lfbn-lyo-1-997-19.w86-194.abo.wanadoo.fr [86.194.74.19]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 60FE7FF805; Sat, 14 Nov 2020 19:16:43 +0000 (UTC) Date: Sat, 14 Nov 2020 20:16:42 +0100 From: Alexandre Belloni To: Jonathan Cameron Cc: Lars-Peter Clausen , Peter Meerwald-Stadler , Nicolas Ferre , Ludovic Desroches , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/9] iio: adc: at91_adc: rework trigger definition Message-ID: <20201114191642.GA5272@piout.net> References: <20201113212650.507680-1-alexandre.belloni@bootlin.com> <20201113212650.507680-5-alexandre.belloni@bootlin.com> <20201114170230.5a94a192@archlinux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201114170230.5a94a192@archlinux> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/11/2020 17:02:30+0000, Jonathan Cameron wrote: > On Fri, 13 Nov 2020 22:26:45 +0100 > Alexandre Belloni wrote: > > > Move the available trigger definition back in the driver to stop cluttering > > the device tree. There is no functional change except that it actually > > fixes the available triggers for at91sam9rl as it inherited the list from > > at91sam9260 but actually has the triggers from at91sam9x5. > > Is that a fix we might want to backport? If not we should probably put a clear > statement in here to avoid it getting picked up by the bot. > > I'd argue it's to invasive a change to backport. > Nobody ever complained about it so I don't think it is necessary to backport. Anyway, the proper backportable fix would be to simply change the device tree, that avoids the driver change which I also think is too invasive. I'll include the DT change in v2. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51621C5519F for ; Sat, 14 Nov 2020 19:18:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D80FE22263 for ; Sat, 14 Nov 2020 19:18:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="11NEwWbW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D80FE22263 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=c7fTKuklpHKqWn6cgegkgOrmOzMAtSVZL41lvQBQoV4=; b=11NEwWbWxnjx3PZ43pfbpk5x3 aZs8Ri6ZLGrbJNzIrJiNVC/tqmh6Axyp9fxvPXj0fQvldmE2peCmEdsfTWu+RyysylNP516BDE1/0 57ujbZrJO3zDkLr1CR58go+rC/Mymedl2u/DTHnLb27Fipwp+0cyTCFFrhLRvBQR7VX1VwmxOLZ87 8mJ0ShRxugENjG95vUem5WaoHTwD7tH8q6776ZIfnFw/RT4dJukhXcveadfW2RtF+F5bmSly4Wwp4 NL+p9w1Q1ofaRGcZGaHMLzT0MKwsXXsaIOwET/1zrDs4yaTR/1y4OyfiqtT5B31Q4s+QHBSPWt6zd JZhCZ5Brw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ke12Y-0001x7-AY; Sat, 14 Nov 2020 19:16:50 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ke12V-0001wm-Lm for linux-arm-kernel@lists.infradead.org; Sat, 14 Nov 2020 19:16:48 +0000 X-Originating-IP: 86.194.74.19 Received: from localhost (lfbn-lyo-1-997-19.w86-194.abo.wanadoo.fr [86.194.74.19]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 60FE7FF805; Sat, 14 Nov 2020 19:16:43 +0000 (UTC) Date: Sat, 14 Nov 2020 20:16:42 +0100 From: Alexandre Belloni To: Jonathan Cameron Subject: Re: [PATCH 4/9] iio: adc: at91_adc: rework trigger definition Message-ID: <20201114191642.GA5272@piout.net> References: <20201113212650.507680-1-alexandre.belloni@bootlin.com> <20201113212650.507680-5-alexandre.belloni@bootlin.com> <20201114170230.5a94a192@archlinux> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201114170230.5a94a192@archlinux> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201114_141647_823233_7153561B X-CRM114-Status: GOOD ( 17.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Lars-Peter Clausen , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Ludovic Desroches , Peter Meerwald-Stadler , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14/11/2020 17:02:30+0000, Jonathan Cameron wrote: > On Fri, 13 Nov 2020 22:26:45 +0100 > Alexandre Belloni wrote: > > > Move the available trigger definition back in the driver to stop cluttering > > the device tree. There is no functional change except that it actually > > fixes the available triggers for at91sam9rl as it inherited the list from > > at91sam9260 but actually has the triggers from at91sam9x5. > > Is that a fix we might want to backport? If not we should probably put a clear > statement in here to avoid it getting picked up by the bot. > > I'd argue it's to invasive a change to backport. > Nobody ever complained about it so I don't think it is necessary to backport. Anyway, the proper backportable fix would be to simply change the device tree, that avoids the driver change which I also think is too invasive. I'll include the DT change in v2. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel