CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Miquel Raynal CC: Boris Brezillon tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: e28c0d7c92c89016c12a677616668957351e7542 commit: 4c46667b3d67253604ee42840917844548c86657 mtd: rawnand: s/data_interface/interface_config/ date: 5 months ago :::::: branch date: 3 hours ago :::::: commit date: 5 months ago config: i386-randconfig-m021-20201115 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter New smatch warnings: drivers/mtd/nand/raw/ams-delta.c:202 gpio_nand_setup_interface() warn: passing a valid pointer to 'PTR_ERR' drivers/mtd/nand/raw/fsmc_nand.c:340 fsmc_setup_interface() warn: passing a valid pointer to 'PTR_ERR' drivers/mtd/nand/raw/tegra_nand.c:824 tegra_nand_setup_interface() warn: passing a valid pointer to 'PTR_ERR' Old smatch warnings: drivers/mtd/nand/raw/fsmc_nand.c:309 fsmc_calc_timings() warn: impossible condition '(tims->thold > 255) => (0-255 > 255)' drivers/mtd/nand/raw/fsmc_nand.c:316 fsmc_calc_timings() warn: impossible condition '(tims->twait > 255) => (0-255 > 255)' drivers/mtd/nand/raw/fsmc_nand.c:324 fsmc_calc_timings() warn: impossible condition '(tims->tset > 255) => (0-255 > 255)' vim +/PTR_ERR +202 drivers/mtd/nand/raw/ams-delta.c 3d12c0c75db0cd8 drivers/mtd/nand/ams-delta.c Jonathan McDowell 2006-05-21 193 4c46667b3d67253 drivers/mtd/nand/raw/ams-delta.c Miquel Raynal 2020-05-29 194 static int gpio_nand_setup_interface(struct nand_chip *this, int csline, 4c46667b3d67253 drivers/mtd/nand/raw/ams-delta.c Miquel Raynal 2020-05-29 195 const struct nand_interface_config *cf) ccada49b050f44d drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12 196 { 16d00cd61206896 drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12 197 struct gpio_nand *priv = nand_get_controller_data(this); ccada49b050f44d drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12 198 const struct nand_sdr_timings *sdr = nand_get_sdr_timings(cf); ccada49b050f44d drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12 199 struct device *dev = &nand_to_mtd(this)->dev; ccada49b050f44d drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12 200 ccada49b050f44d drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12 201 if (IS_ERR(sdr)) ccada49b050f44d drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12 @202 return PTR_ERR(sdr); ccada49b050f44d drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12 203 ccada49b050f44d drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12 204 if (csline == NAND_DATA_IFACE_CHECK_ONLY) ccada49b050f44d drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12 205 return 0; ccada49b050f44d drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12 206 586a746b326c35d drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12 207 if (priv->gpiod_nre) { ccada49b050f44d drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12 208 priv->tRP = DIV_ROUND_UP(sdr->tRP_min, 1000); ccada49b050f44d drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12 209 dev_dbg(dev, "using %u ns read pulse width\n", priv->tRP); 586a746b326c35d drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12 210 } ccada49b050f44d drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12 211 ccada49b050f44d drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12 212 priv->tWP = DIV_ROUND_UP(sdr->tWP_min, 1000); ccada49b050f44d drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12 213 dev_dbg(dev, "using %u ns write pulse width\n", priv->tWP); ccada49b050f44d drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12 214 ccada49b050f44d drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12 215 return 0; ccada49b050f44d drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12 216 } ccada49b050f44d drivers/mtd/nand/raw/ams-delta.c Janusz Krzysztofik 2020-02-12 217 :::::: The code at line 202 was first introduced by commit :::::: ccada49b050f44df9499859f09b822b8aebc3a4d mtd: rawnand: ams-delta: Don't hardcode read/write pulse widths :::::: TO: Janusz Krzysztofik :::::: CC: Miquel Raynal --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org