From: Jakub Kicinski <kuba@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Realtek linux nic maintainers <nic_swsd@realtek.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] r8169: improve rtl8169_start_xmit
Date: Mon, 16 Nov 2020 07:58:03 -0800 [thread overview]
Message-ID: <20201116075803.0a75fd3f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <80085451-3eaf-507a-c7c0-08d607c46fbc@gmail.com>
On Sat, 14 Nov 2020 21:49:53 +0100 Heiner Kallweit wrote:
> Improve the following in rtl8169_start_xmit:
> - tp->cur_tx can be accessed in parallel by rtl_tx(), therefore
> annotate the race by using WRITE_ONCE
> - avoid checking stop_queue a second time by moving the doorbell check
> - netif_stop_queue() uses atomic operation set_bit() that includes a
> full memory barrier on some platforms, therefore use
> smp_mb__after_atomic to avoid overhead
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied, thanks.
next prev parent reply other threads:[~2020-11-16 15:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 20:49 [PATCH net-next] r8169: improve rtl8169_start_xmit Heiner Kallweit
2020-11-16 15:58 ` Jakub Kicinski [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-02-22 16:02 Heiner Kallweit
2020-02-24 1:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116075803.0a75fd3f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.