From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60F0DC55ABD for ; Mon, 16 Nov 2020 09:04:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E4F59221F9 for ; Mon, 16 Nov 2020 09:04:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rG3sxjug" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727768AbgKPIk2 (ORCPT ); Mon, 16 Nov 2020 03:40:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726440AbgKPIk1 (ORCPT ); Mon, 16 Nov 2020 03:40:27 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BA6FC0613CF for ; Mon, 16 Nov 2020 00:40:27 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id l1so17697098wrb.9 for ; Mon, 16 Nov 2020 00:40:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=66vgfrqqdZ/IjftnWRbyL4mui98MkxfRQBZDGIvtL2s=; b=rG3sxjughMIpsK016TP+ndDu9i6AsudSrG82mApavm72NuxKrKmrpmqp7UfsnrS+yr LPkQykKHB7bRePswqOeFuGE5U3urfRmgY8xCS2gNc18KwwFLvnk13kusPLexPkHCAW4J Q9HmnCCFvyN/irDbL+knw2OVY4WgR9jGxnNnnkdowuQhOUiVIrhDotn0STih9731kL2C /o8NkkcLheLF2oh3UB4RhqEomcfmm1va+jVfdm4csg0sztaacD7Acd252QOQanS4gjCV gVJG2ZjycLDmaEQGJe2yo8jij2ity89vkyHFF3HwoQOqrTAzFbKF1R57Z2dOgJPXgc73 2pzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=66vgfrqqdZ/IjftnWRbyL4mui98MkxfRQBZDGIvtL2s=; b=jymA+Ta6wA70gk/Dm6dSs7/faiDMR0cUiBD66eap3Q8WSR0K7cf6KppLmlCrDvUTwB uz9aU/eF2/e1qBJ9VeITm95zrftvqF3LneNYmacqA5XOyu/3MxPBtzph7ETZUiwdNlEG A6NR3xJ10w5i4WgwXwmaKTPsxM0Xp85uofdNpQ6s/X6QUX3nfGt3On7lo4B4ZKSrYbA2 HG7sCbdGtAjbMloXiblibC24tNSCITCTtdskZ8v2N8uKHUA96ZOSlaj+iUGbGHIBrSfu zIR/oMUiHUGlVSvPmDLwbdi9GcF1Z+5v3n4aSda6t9VGdOcItoy3YPBieW1osiwBLU85 VXoA== X-Gm-Message-State: AOAM532k4aUJUP5eXZUT7sX31mOPSvrBJNtn/b7MiFUWWb2PPuwLrr5l BOYBVh5gRjDNzUBTrigMDD9nwwjLczW/YWnV X-Google-Smtp-Source: ABdhPJwtkF/gvhkWNlAdOMKy71DTjd+S++as5sylbMhPP9SVjdJjRBSawpKlXZ8BBiftB8AUIyg38Q== X-Received: by 2002:adf:f94b:: with SMTP id q11mr18901740wrr.351.1605516026241; Mon, 16 Nov 2020 00:40:26 -0800 (PST) Received: from dell ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id t5sm18937446wmg.19.2020.11.16.00.40.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 00:40:25 -0800 (PST) Date: Mon, 16 Nov 2020 08:40:23 +0000 From: Lee Jones To: Sam Ravnborg Cc: Eric Anholt , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/40] drm/pl111/pl111_display: Make local function static Message-ID: <20201116084023.GL3718728@dell> References: <20201113134938.4004947-1-lee.jones@linaro.org> <20201113134938.4004947-13-lee.jones@linaro.org> <20201114191127.GB3797389@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201114191127.GB3797389@ravnborg.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 14 Nov 2020, Sam Ravnborg wrote: > Hi Lee, > On Fri, Nov 13, 2020 at 01:49:10PM +0000, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/pl111/pl111_display.c:356:6: warning: no previous prototype for ‘pl111_display_disable’ [-Wmissing-prototypes] > > > > Cc: Eric Anholt > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: dri-devel@lists.freedesktop.org > > Signed-off-by: Lee Jones > > Eric's was not copied on this or the other pl111 patch. > Added Eric so he can be aware of this fix. Eric Anholt? He's on Cc? > > --- > > drivers/gpu/drm/pl111/pl111_display.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c > > index b3e8697cafcf1..69c02e7c82b7e 100644 > > --- a/drivers/gpu/drm/pl111/pl111_display.c > > +++ b/drivers/gpu/drm/pl111/pl111_display.c > > @@ -353,7 +353,7 @@ static void pl111_display_enable(struct drm_simple_display_pipe *pipe, > > drm_crtc_vblank_on(crtc); > > } > > > > -void pl111_display_disable(struct drm_simple_display_pipe *pipe) > > +static void pl111_display_disable(struct drm_simple_display_pipe *pipe) > > { > > struct drm_crtc *crtc = &pipe->crtc; > > struct drm_device *drm = crtc->dev; -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16052C4742C for ; Mon, 16 Nov 2020 08:40:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87B4C21D93 for ; Mon, 16 Nov 2020 08:40:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rG3sxjug" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87B4C21D93 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BB2F889D9B; Mon, 16 Nov 2020 08:40:28 +0000 (UTC) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 99DF189D9B for ; Mon, 16 Nov 2020 08:40:27 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id b6so17723927wrt.4 for ; Mon, 16 Nov 2020 00:40:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=66vgfrqqdZ/IjftnWRbyL4mui98MkxfRQBZDGIvtL2s=; b=rG3sxjughMIpsK016TP+ndDu9i6AsudSrG82mApavm72NuxKrKmrpmqp7UfsnrS+yr LPkQykKHB7bRePswqOeFuGE5U3urfRmgY8xCS2gNc18KwwFLvnk13kusPLexPkHCAW4J Q9HmnCCFvyN/irDbL+knw2OVY4WgR9jGxnNnnkdowuQhOUiVIrhDotn0STih9731kL2C /o8NkkcLheLF2oh3UB4RhqEomcfmm1va+jVfdm4csg0sztaacD7Acd252QOQanS4gjCV gVJG2ZjycLDmaEQGJe2yo8jij2ity89vkyHFF3HwoQOqrTAzFbKF1R57Z2dOgJPXgc73 2pzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=66vgfrqqdZ/IjftnWRbyL4mui98MkxfRQBZDGIvtL2s=; b=iZSj2kk0SZBOXiQsgOWfkb1M+pRnftvs5FP0epcycyKPoLn77jTI5BA5qZ/GEgd3js nxuFtqaES/AgdLcqksQULJq5UTvayABdpLm+swvDcjBeBsFb5XAZcY1CKWwn/nreRf6U 0dM4bwYDlmsrYnsn1aWfg8wTIO6A2+aiR7BUMWx8zP7AieU2BQMlT32zZxnHBLcqIsu6 DlFCfYWhBvDr983apokldgnWtn+Mf1KIHx1IMbj9xDr5/9et4kS51mrZELOXezvNHywP nOVl7P+NmYvrmgnE6LTVvgMyzd9B74A/kE9m6jD9UsM2qASVWkZj2mjJt6tZQUZpc+/B lPow== X-Gm-Message-State: AOAM532GT4WJBhu1NM+DqJ2qHw1UQI60TBUBWXhMeAj15fae2vJt9KPH 4pUuC/5sB3dYx3TJvD+3zTc9mg== X-Google-Smtp-Source: ABdhPJwtkF/gvhkWNlAdOMKy71DTjd+S++as5sylbMhPP9SVjdJjRBSawpKlXZ8BBiftB8AUIyg38Q== X-Received: by 2002:adf:f94b:: with SMTP id q11mr18901740wrr.351.1605516026241; Mon, 16 Nov 2020 00:40:26 -0800 (PST) Received: from dell ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id t5sm18937446wmg.19.2020.11.16.00.40.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 00:40:25 -0800 (PST) Date: Mon, 16 Nov 2020 08:40:23 +0000 From: Lee Jones To: Sam Ravnborg Subject: Re: [PATCH 12/40] drm/pl111/pl111_display: Make local function static Message-ID: <20201116084023.GL3718728@dell> References: <20201113134938.4004947-1-lee.jones@linaro.org> <20201113134938.4004947-13-lee.jones@linaro.org> <20201114191127.GB3797389@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201114191127.GB3797389@ravnborg.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gU2F0LCAxNCBOb3YgMjAyMCwgU2FtIFJhdm5ib3JnIHdyb3RlOgoKPiBIaSBMZWUsCj4gT24g RnJpLCBOb3YgMTMsIDIwMjAgYXQgMDE6NDk6MTBQTSArMDAwMCwgTGVlIEpvbmVzIHdyb3RlOgo+ ID4gRml4ZXMgdGhlIGZvbGxvd2luZyBXPTEga2VybmVsIGJ1aWxkIHdhcm5pbmcocyk6Cj4gPiAK PiA+ICBkcml2ZXJzL2dwdS9kcm0vcGwxMTEvcGwxMTFfZGlzcGxheS5jOjM1Njo2OiB3YXJuaW5n OiBubyBwcmV2aW91cyBwcm90b3R5cGUgZm9yIOKAmHBsMTExX2Rpc3BsYXlfZGlzYWJsZeKAmSBb LVdtaXNzaW5nLXByb3RvdHlwZXNdCj4gPiAKPiA+IENjOiBFcmljIEFuaG9sdCA8ZXJpY0Bhbmhv bHQubmV0Pgo+ID4gQ2M6IERhdmlkIEFpcmxpZSA8YWlybGllZEBsaW51eC5pZT4KPiA+IENjOiBE YW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+Cj4gPiBDYzogZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwo+ID4gU2lnbmVkLW9mZi1ieTogTGVlIEpvbmVzIDxsZWUuam9uZXNAbGlu YXJvLm9yZz4KPiAKPiBFcmljJ3Mgd2FzIG5vdCBjb3BpZWQgb24gdGhpcyBvciB0aGUgb3RoZXIg cGwxMTEgcGF0Y2guCj4gQWRkZWQgRXJpYyBzbyBoZSBjYW4gYmUgYXdhcmUgb2YgdGhpcyBmaXgu CgpFcmljIEFuaG9sdD8KCkhlJ3Mgb24gQ2M/Cgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJt L3BsMTExL3BsMTExX2Rpc3BsYXkuYyB8IDIgKy0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNl cnRpb24oKyksIDEgZGVsZXRpb24oLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9wbDExMS9wbDExMV9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vcGwxMTEvcGwxMTFf ZGlzcGxheS5jCj4gPiBpbmRleCBiM2U4Njk3Y2FmY2YxLi42OWMwMmU3YzgyYjdlIDEwMDY0NAo+ ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3BsMTExL3BsMTExX2Rpc3BsYXkuYwo+ID4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL3BsMTExL3BsMTExX2Rpc3BsYXkuYwo+ID4gQEAgLTM1Myw3ICszNTMs NyBAQCBzdGF0aWMgdm9pZCBwbDExMV9kaXNwbGF5X2VuYWJsZShzdHJ1Y3QgZHJtX3NpbXBsZV9k aXNwbGF5X3BpcGUgKnBpcGUsCj4gPiAgCQlkcm1fY3J0Y192Ymxhbmtfb24oY3J0Yyk7Cj4gPiAg fQo+ID4gIAo+ID4gLXZvaWQgcGwxMTFfZGlzcGxheV9kaXNhYmxlKHN0cnVjdCBkcm1fc2ltcGxl X2Rpc3BsYXlfcGlwZSAqcGlwZSkKPiA+ICtzdGF0aWMgdm9pZCBwbDExMV9kaXNwbGF5X2Rpc2Fi bGUoc3RydWN0IGRybV9zaW1wbGVfZGlzcGxheV9waXBlICpwaXBlKQo+ID4gIHsKPiA+ICAJc3Ry dWN0IGRybV9jcnRjICpjcnRjID0gJnBpcGUtPmNydGM7Cj4gPiAgCXN0cnVjdCBkcm1fZGV2aWNl ICpkcm0gPSBjcnRjLT5kZXY7CgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dClNlbmlvciBUZWNo bmljYWwgTGVhZCAtIERldmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJj ZSBzb2Z0d2FyZSBmb3IgQXJtIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVy IHwgQmxvZwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK