From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 335D7C8300F for ; Mon, 16 Nov 2020 12:37:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 07BE220853 for ; Mon, 16 Nov 2020 12:37:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729052AbgKPLSz (ORCPT ); Mon, 16 Nov 2020 06:18:55 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:37742 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728968AbgKPLSz (ORCPT ); Mon, 16 Nov 2020 06:18:55 -0500 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 86E0720056; Mon, 16 Nov 2020 12:18:51 +0100 (CET) Date: Mon, 16 Nov 2020 12:18:50 +0100 From: Sam Ravnborg To: Lee Jones Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 12/40] drm/pl111/pl111_display: Make local function static Message-ID: <20201116111850.GA68743@ravnborg.org> References: <20201113134938.4004947-1-lee.jones@linaro.org> <20201113134938.4004947-13-lee.jones@linaro.org> <20201114191127.GB3797389@ravnborg.org> <20201116084023.GL3718728@dell> <20201116101734.GA65688@ravnborg.org> <20201116102530.GN3718728@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201116102530.GN3718728@dell> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VbvZwmh9 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=IkcTkHD0fZMA:10 a=-VAfIpHNAAAA:8 a=e5mUnYsNAAAA:8 a=KKAkSRfTAAAA:8 a=VwQbUJbxAAAA:8 a=xQzvdHlxAAAA:20 a=YYAp68AnUQjD0k_29DoA:9 a=QEXdDO2ut3YA:10 a=srlwD-8ojaedGGhPAyx8:22 a=Vxmtnl_E_bksehYqCbjh:22 a=cvBusfyB2V15izCimMoJ:22 a=AjGcO6oz07-iQ99wixmX:22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lee, On Mon, Nov 16, 2020 at 10:25:30AM +0000, Lee Jones wrote: > On Mon, 16 Nov 2020, Sam Ravnborg wrote: > > > Hi Lee, > > On Mon, Nov 16, 2020 at 08:40:23AM +0000, Lee Jones wrote: > > > On Sat, 14 Nov 2020, Sam Ravnborg wrote: > > > > > > > Hi Lee, > > > > On Fri, Nov 13, 2020 at 01:49:10PM +0000, Lee Jones wrote: > > > > > Fixes the following W=1 kernel build warning(s): > > > > > > > > > > drivers/gpu/drm/pl111/pl111_display.c:356:6: warning: no previous prototype for ‘pl111_display_disable’ [-Wmissing-prototypes] > > > > > > > > > > Cc: Eric Anholt > > > > > Cc: David Airlie > > > > > Cc: Daniel Vetter > > > > > Cc: dri-devel@lists.freedesktop.org > > > > > Signed-off-by: Lee Jones > > > > > > > > Eric's was not copied on this or the other pl111 patch. > > > > Added Eric so he can be aware of this fix. > > > > > > Eric Anholt? > > > > > > He's on Cc? > > Not on the original mail I received. > > Looks fine to me: > > Date: Fri, 13 Nov 2020 13:49:10 +0000 > From: Lee Jones > To: lee.jones@linaro.org > Cc: linux-kernel@vger.kernel.org, Eric Anholt , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org > Subject: [PATCH 12/40] drm/pl111/pl111_display: Make local function static > > Also reflected in Gmail: > > https://i.imgur.com/d69YTzz.png Strange indeed. In lore Eric is not included: https://lore.kernel.org/dri-devel/20201113134938.4004947-13-lee.jones@linaro.org/ I consider this a fluke in the force, and will not worry more about it. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DEB6C4742C for ; Mon, 16 Nov 2020 11:18:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E48A020853 for ; Mon, 16 Nov 2020 11:18:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E48A020853 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 13D7C89E1B; Mon, 16 Nov 2020 11:18:55 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id E070989E1B for ; Mon, 16 Nov 2020 11:18:53 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 86E0720056; Mon, 16 Nov 2020 12:18:51 +0100 (CET) Date: Mon, 16 Nov 2020 12:18:50 +0100 From: Sam Ravnborg To: Lee Jones Subject: Re: [PATCH 12/40] drm/pl111/pl111_display: Make local function static Message-ID: <20201116111850.GA68743@ravnborg.org> References: <20201113134938.4004947-1-lee.jones@linaro.org> <20201113134938.4004947-13-lee.jones@linaro.org> <20201114191127.GB3797389@ravnborg.org> <20201116084023.GL3718728@dell> <20201116101734.GA65688@ravnborg.org> <20201116102530.GN3718728@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201116102530.GN3718728@dell> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VbvZwmh9 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=IkcTkHD0fZMA:10 a=-VAfIpHNAAAA:8 a=e5mUnYsNAAAA:8 a=KKAkSRfTAAAA:8 a=VwQbUJbxAAAA:8 a=xQzvdHlxAAAA:20 a=YYAp68AnUQjD0k_29DoA:9 a=QEXdDO2ut3YA:10 a=srlwD-8ojaedGGhPAyx8:22 a=Vxmtnl_E_bksehYqCbjh:22 a=cvBusfyB2V15izCimMoJ:22 a=AjGcO6oz07-iQ99wixmX:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkgTGVlLApPbiBNb24sIE5vdiAxNiwgMjAyMCBhdCAxMDoyNTozMEFNICswMDAwLCBMZWUgSm9u ZXMgd3JvdGU6Cj4gT24gTW9uLCAxNiBOb3YgMjAyMCwgU2FtIFJhdm5ib3JnIHdyb3RlOgo+IAo+ ID4gSGkgTGVlLAo+ID4gT24gTW9uLCBOb3YgMTYsIDIwMjAgYXQgMDg6NDA6MjNBTSArMDAwMCwg TGVlIEpvbmVzIHdyb3RlOgo+ID4gPiBPbiBTYXQsIDE0IE5vdiAyMDIwLCBTYW0gUmF2bmJvcmcg d3JvdGU6Cj4gPiA+IAo+ID4gPiA+IEhpIExlZSwKPiA+ID4gPiBPbiBGcmksIE5vdiAxMywgMjAy MCBhdCAwMTo0OToxMFBNICswMDAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiA+ID4gPiBGaXhlcyB0 aGUgZm9sbG93aW5nIFc9MSBrZXJuZWwgYnVpbGQgd2FybmluZyhzKToKPiA+ID4gPiA+IAo+ID4g PiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9wbDExMS9wbDExMV9kaXNwbGF5LmM6MzU2OjY6IHdhcm5p bmc6IG5vIHByZXZpb3VzIHByb3RvdHlwZSBmb3Ig4oCYcGwxMTFfZGlzcGxheV9kaXNhYmxl4oCZ IFstV21pc3NpbmctcHJvdG90eXBlc10KPiA+ID4gPiA+IAo+ID4gPiA+ID4gQ2M6IEVyaWMgQW5o b2x0IDxlcmljQGFuaG9sdC5uZXQ+Cj4gPiA+ID4gPiBDYzogRGF2aWQgQWlybGllIDxhaXJsaWVk QGxpbnV4LmllPgo+ID4gPiA+ID4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4K PiA+ID4gPiA+IENjOiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiA+ID4gPiBT aWduZWQtb2ZmLWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgo+ID4gPiA+IAo+ ID4gPiA+IEVyaWMncyB3YXMgbm90IGNvcGllZCBvbiB0aGlzIG9yIHRoZSBvdGhlciBwbDExMSBw YXRjaC4KPiA+ID4gPiBBZGRlZCBFcmljIHNvIGhlIGNhbiBiZSBhd2FyZSBvZiB0aGlzIGZpeC4K PiA+ID4gCj4gPiA+IEVyaWMgQW5ob2x0Pwo+ID4gPiAKPiA+ID4gSGUncyBvbiBDYz8KPiA+IE5v dCBvbiB0aGUgb3JpZ2luYWwgbWFpbCBJIHJlY2VpdmVkLgo+IAo+IExvb2tzIGZpbmUgdG8gbWU6 Cj4gCj4gRGF0ZTogRnJpLCAxMyBOb3YgMjAyMCAxMzo0OToxMCArMDAwMAo+IEZyb206IExlZSBK b25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+Cj4gVG86IGxlZS5qb25lc0BsaW5hcm8ub3JnCj4g Q2M6IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmcsIEVyaWMgQW5ob2x0IDxlcmljQGFuaG9s dC5uZXQ+LCBEYXZpZCBBaXJsaWUgPGFpcmxpZWRAbGludXguaWU+LCBEYW5pZWwgVmV0dGVyIDxk YW5pZWxAZmZ3bGwuY2g+LCBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gU3ViamVj dDogW1BBVENIIDEyLzQwXSBkcm0vcGwxMTEvcGwxMTFfZGlzcGxheTogTWFrZSBsb2NhbCBmdW5j dGlvbiBzdGF0aWMKPiAKPiBBbHNvIHJlZmxlY3RlZCBpbiBHbWFpbDoKPiAKPiAgaHR0cHM6Ly9p LmltZ3VyLmNvbS9kNjlZVHp6LnBuZwoKU3RyYW5nZSBpbmRlZWQuIEluIGxvcmUgRXJpYyBpcyBu b3QgaW5jbHVkZWQ6Cmh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2RyaS1kZXZlbC8yMDIwMTExMzEz NDkzOC40MDA0OTQ3LTEzLWxlZS5qb25lc0BsaW5hcm8ub3JnLwoKSSBjb25zaWRlciB0aGlzIGEg Zmx1a2UgaW4gdGhlIGZvcmNlLCBhbmQgd2lsbCBub3Qgd29ycnkgbW9yZSBhYm91dCBpdC4KCglT YW0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==