From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E4DDC844E2 for ; Mon, 16 Nov 2020 12:38:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C67C222265 for ; Mon, 16 Nov 2020 12:38:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727066AbgKPMFZ (ORCPT ); Mon, 16 Nov 2020 07:05:25 -0500 Received: from mga17.intel.com ([192.55.52.151]:33625 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726204AbgKPMFY (ORCPT ); Mon, 16 Nov 2020 07:05:24 -0500 IronPort-SDR: Rp/FfNFjgTg/cwZ6Fta6FTeH+I9UdOB0dZPg5K6LUTpnhGMHJl0DLL+K7MBxzwGDiycMAwyYZH Ql0irWDGLOqw== X-IronPort-AV: E=McAfee;i="6000,8403,9806"; a="150584172" X-IronPort-AV: E=Sophos;i="5.77,482,1596524400"; d="scan'208";a="150584172" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2020 04:05:23 -0800 IronPort-SDR: R5ImTTVJB5cUh+hdnvy5PCho7eVEBKMbWeaQgQlbygRl+10rVepUO+38KG55lOMEeItFXQBb97 Lwz1+7/AhFIA== X-IronPort-AV: E=Sophos;i="5.77,482,1596524400"; d="scan'208";a="367685760" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2020 04:05:22 -0800 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 87F4F208C5; Mon, 16 Nov 2020 14:05:20 +0200 (EET) Date: Mon, 16 Nov 2020 14:05:20 +0200 From: Sakari Ailus To: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org Subject: Re: [PATCH v2 033/106] ccs: Add CCS static data parser library Message-ID: <20201116120520.GC1009@paasikivi.fi.intel.com> References: <20201007084505.25761-1-sakari.ailus@linux.intel.com> <20201007084557.25843-1-sakari.ailus@linux.intel.com> <20201007084557.25843-26-sakari.ailus@linux.intel.com> <20201105115032.53381197@coco.lan> <20201105111807.GB26150@paasikivi.fi.intel.com> <20201105135350.6fbfe79a@coco.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201105135350.6fbfe79a@coco.lan> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Thu, Nov 05, 2020 at 01:53:50PM +0100, Mauro Carvalho Chehab wrote: > Em Thu, 5 Nov 2020 13:18:07 +0200 > Sakari Ailus escreveu: > > > Hi Mauro, > > > > Thanks for the review. > > > > On Thu, Nov 05, 2020 at 11:50:32AM +0100, Mauro Carvalho Chehab wrote: > > > > ... > > > > > > +struct __ccs_data_block_end { > > > > + uint8_t crc[4]; > > > > +} __attribute__((packed)); > > > > + > > > > +#endif /* __CCS_DATA_DEFS_H__ */ > > > > > > Nitpick: why all the above struct/enums start with "__"? > > > > We have two sets of data structure: those that are related to the binary > > file format (these, so they're packed) as well as the in-kernel > > representation. So I've used the underscores to designate these are the > > binary format ones. They're only used in ccs-data.c. > > > > Ok for me, but, IMHO, you should document it somewhere about such > convention. I've added descriptions to the two headers that contain the definitions. That might not hurt elsewhere either, at least for the added files. -- Sakari Ailus