From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] btrfs: Simplify setup_nodes_for_search
Date: Mon, 16 Nov 2020 16:47:21 +0100 [thread overview]
Message-ID: <20201116154721.GP6756@twin.jikos.cz> (raw)
In-Reply-To: <20201113072940.479655-1-nborisov@suse.com>
On Fri, Nov 13, 2020 at 09:29:40AM +0200, Nikolay Borisov wrote:
> The function is needlessly convoluted. Fix that by:
>
> * Removing redundant sret variable definition in both if arms.
>
> * Replace the again/done labels with direct return statements, the
> function is short enough and doesn't do anything special upon exit.
>
> * Remove BUG_ON on split_node returning a positive number - it can't
> happen as split_node returns either 0 or a negative error code.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Added to misc-next, thanks.
prev parent reply other threads:[~2020-11-16 15:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 7:29 [PATCH v2] btrfs: Simplify setup_nodes_for_search Nikolay Borisov
2020-11-13 18:25 ` Josef Bacik
2020-11-16 15:47 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116154721.GP6756@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.