All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Arnaud POULIQUEN <arnaud.pouliquen@st.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Alexander Lobakin <alobakin@pm.me>, Amit Shah <amit@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Suman Anna <s-anna@ti.com>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Ohad Ben-Cohen <ohad@wizery.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	"virtualization@lists.linux-foundation.org" 
	<virtualization@lists.linux-foundation.org>,
	"linux-remoteproc@vger.kernel.org"
	<linux-remoteproc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH virtio] virtio: virtio_console: fix DMA memory allocation for rproc serial
Date: Mon, 16 Nov 2020 16:28:44 +0000	[thread overview]
Message-ID: <20201116162844.GB16619@infradead.org> (raw)
In-Reply-To: <ca183081-5a9f-0104-bf79-5fea544c9271@st.com>

On Mon, Nov 16, 2020 at 11:46:59AM +0100, Arnaud POULIQUEN wrote:
> Hi all,
> 
> On 11/16/20 10:19 AM, Christoph Hellwig wrote:
> > I just noticed this showing up in Linus' tree and I'm not happy.
> > 
> > This whole model of the DMA subdevices in remoteproc is simply broken.
> > 
> > We really need to change the virtio code pass an expicit DMA device (
> > similar to what e.g. the USB and RDMA code does), instead of faking up
> > devices with broken adhoc inheritance of DMA properties and magic poking
> > into device parent relationships.
> 
> For your formation I started some stuff on my side to be able to declare the
> virtio device in DT as a remoteproc child node.
> 
> https://lkml.org/lkml/2020/4/16/1817
> 
> Quite big refactoring, but could be a way to answer...

Yes, that series is exactly what we need to do conceptually (can't
comment on all the nitty grity details as I'm not too familiar with
the remoteproc code).

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Arnaud POULIQUEN <arnaud.pouliquen@st.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>, Amit Shah <amit@kernel.org>,
	Alexander Lobakin <alobakin@pm.me>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"linux-remoteproc@vger.kernel.org"
	<linux-remoteproc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Christoph Hellwig <hch@infradead.org>, Suman Anna <s-anna@ti.com>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH virtio] virtio: virtio_console: fix DMA memory allocation for rproc serial
Date: Mon, 16 Nov 2020 16:28:44 +0000	[thread overview]
Message-ID: <20201116162844.GB16619@infradead.org> (raw)
In-Reply-To: <ca183081-5a9f-0104-bf79-5fea544c9271@st.com>

On Mon, Nov 16, 2020 at 11:46:59AM +0100, Arnaud POULIQUEN wrote:
> Hi all,
> 
> On 11/16/20 10:19 AM, Christoph Hellwig wrote:
> > I just noticed this showing up in Linus' tree and I'm not happy.
> > 
> > This whole model of the DMA subdevices in remoteproc is simply broken.
> > 
> > We really need to change the virtio code pass an expicit DMA device (
> > similar to what e.g. the USB and RDMA code does), instead of faking up
> > devices with broken adhoc inheritance of DMA properties and magic poking
> > into device parent relationships.
> 
> For your formation I started some stuff on my side to be able to declare the
> virtio device in DT as a remoteproc child node.
> 
> https://lkml.org/lkml/2020/4/16/1817
> 
> Quite big refactoring, but could be a way to answer...

Yes, that series is exactly what we need to do conceptually (can't
comment on all the nitty grity details as I'm not too familiar with
the remoteproc code).
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  reply	other threads:[~2020-11-16 16:29 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-04 15:31 [PATCH virtio] virtio: virtio_console: fix DMA memory allocation for rproc serial Alexander Lobakin
2020-11-04 18:21 ` Mathieu Poirier
2020-11-05  3:10 ` Jason Wang
2020-11-05  3:10   ` Jason Wang
2020-11-05 12:22   ` Alexander Lobakin
2020-11-09  6:04     ` Jason Wang
2020-11-09  6:04       ` Jason Wang
2020-11-16  9:19 ` Christoph Hellwig
2020-11-16  9:19   ` Christoph Hellwig
2020-11-16  9:51   ` Michael S. Tsirkin
2020-11-16  9:51     ` Michael S. Tsirkin
2020-11-16 16:27     ` Christoph Hellwig
2020-11-16 16:27       ` Christoph Hellwig
2020-11-16 16:43       ` Alexander Lobakin
2020-11-16 10:46   ` Arnaud POULIQUEN
2020-11-16 10:46     ` Arnaud POULIQUEN
2020-11-16 16:28     ` Christoph Hellwig [this message]
2020-11-16 16:28       ` Christoph Hellwig
2020-11-16 16:39       ` Christoph Hellwig
2020-11-16 16:39         ` Christoph Hellwig
2020-11-17 14:00         ` Arnaud POULIQUEN
2020-11-17 14:00           ` Arnaud POULIQUEN
2020-11-17 14:02           ` Christoph Hellwig
2020-11-17 14:02             ` Christoph Hellwig
2020-11-18 10:16             ` Michael S. Tsirkin
2020-11-18 10:16               ` Michael S. Tsirkin
2020-11-16 12:25   ` Michael S. Tsirkin
2020-11-16 12:25     ` Michael S. Tsirkin
2020-11-16 13:07     ` Alexander Lobakin
2020-11-16 13:12       ` Michael S. Tsirkin
2020-11-16 13:12         ` Michael S. Tsirkin
2020-11-16 16:30       ` Christoph Hellwig
2020-11-16 16:30         ` Christoph Hellwig
2020-12-28 18:54 ` patchwork-bot+linux-remoteproc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201116162844.GB16619@infradead.org \
    --to=hch@infradead.org \
    --cc=alobakin@pm.me \
    --cc=amit@kernel.org \
    --cc=arnaud.pouliquen@st.com \
    --cc=arnd@arndb.de \
    --cc=bjorn.andersson@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mst@redhat.com \
    --cc=ohad@wizery.com \
    --cc=s-anna@ti.com \
    --cc=stable@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.