From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5203CC2D0A3 for ; Mon, 16 Nov 2020 19:04:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F23512225E for ; Mon, 16 Nov 2020 19:04:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="f3nHWDB5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728095AbgKPTEU (ORCPT ); Mon, 16 Nov 2020 14:04:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:53580 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725879AbgKPTEU (ORCPT ); Mon, 16 Nov 2020 14:04:20 -0500 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 52B132225B; Mon, 16 Nov 2020 19:04:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605553459; bh=YQbOeR0Ir0jO5GxTkZ/KPEcLOqI6KXbHLyISKeSbQ2k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f3nHWDB5UYIanun4/6bqobOCfJotTUjTtZItEmpy0wO6KaXjrxdusbSMS4ljgIs1V pDbRIw4hq7DjsHI/TtpuMdrR/of84ih03VU/ZohdCYYh2vZ8V+NmW9wOj8Dsj2ZgmL OKSRtmDgMyutH1MzfMyRjnQs3SXIohzYYhKlIbjs= Date: Mon, 16 Nov 2020 19:04:00 +0000 From: Mark Brown To: Srinivasa Rao Mandadapu Cc: agross@kernel.org, bjorn.andersson@linaro.org, lgirdwood@gmail.com, robh+dt@kernel.org, plai@codeaurora.org, bgoswami@codeaurora.org, perex@perex.cz, tiwai@suse.com, srinivas.kandagatla@linaro.org, rohitkr@codeaurora.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Pavel Machek , V Sujith Kumar Reddy Subject: Re: [PATCH] Asoc: qcom: lpass-platform: Fix memory leak Message-ID: <20201116190400.GE4739@sirena.org.uk> References: <1605416210-14530-1-git-send-email-srivasam@codeaurora.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="brEuL7wsLY8+TuWz" Content-Disposition: inline In-Reply-To: <1605416210-14530-1-git-send-email-srivasam@codeaurora.org> X-Cookie: Immanuel doesn't pun, he Kant. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org --brEuL7wsLY8+TuWz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Nov 15, 2020 at 10:26:50AM +0530, Srinivasa Rao Mandadapu wrote: > lpass_pcm_data is not freed in error paths. Free it in > error paths to avoid memory leak. Please use subject lines reflecting the general style for the subsystem, it makes it easier for people to spot patches that need to be reviewed. --brEuL7wsLY8+TuWz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl+yzSAACgkQJNaLcl1U h9CULgf/enozSv/x01jexTc5wfCzv9oWXsElA/pDZMQvwp2/Hix6fWeuOPzmWIo7 7PYUVqp5i6mJWejVH+qDpIVIwo2V/KzyT81D5JmooPoOglEZzKdiJcj0LK7mkkD+ T21T3qhVwaWml3gna9W8srBFidN3/gJ7+Agd5M3nQbxGtqINtMPBrJ1y7F6CsGhc +pTCkwcpDe/oOhWiV/iifsBhWYmkdCWHypN3vMSDMzuiE5u+PcnZchGhPSdCqrJF FXZ0dMoESRKqUS+MoVa0o3tAL6SEnY/gXvmFEJAw7bYCfpID82GULtwfDuuFmApK qXYtPZY8/noF2WY+pdHO582yoJ12ag== =NfJ5 -----END PGP SIGNATURE----- --brEuL7wsLY8+TuWz-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 200D6C4742C for ; Mon, 16 Nov 2020 19:05:23 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E6D772225E for ; Mon, 16 Nov 2020 19:05:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="s6+8AX+g"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="f3nHWDB5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E6D772225E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 675D81766; Mon, 16 Nov 2020 20:04:28 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 675D81766 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1605553518; bh=YQbOeR0Ir0jO5GxTkZ/KPEcLOqI6KXbHLyISKeSbQ2k=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=s6+8AX+gsNe9ZicpqeDpTIwYY7nBG9LKBGzQvPmMpbDYqnpdKXfDpqT/idpPauEw2 pg+hBUoHs/mtBNN4eX3yqYQq6rcHx9BPAHG5oEekTv5etxwnVI1kxBdsIUEiJyD2rT f0s1ZNe3zMQ1k9wX0kBrZZtdgLuRIrrYQLAlH45g= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id F18C3F80167; Mon, 16 Nov 2020 20:04:27 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6781BF80168; Mon, 16 Nov 2020 20:04:26 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id ED3CEF800D8 for ; Mon, 16 Nov 2020 20:04:23 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz ED3CEF800D8 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="f3nHWDB5" Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 52B132225B; Mon, 16 Nov 2020 19:04:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605553459; bh=YQbOeR0Ir0jO5GxTkZ/KPEcLOqI6KXbHLyISKeSbQ2k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f3nHWDB5UYIanun4/6bqobOCfJotTUjTtZItEmpy0wO6KaXjrxdusbSMS4ljgIs1V pDbRIw4hq7DjsHI/TtpuMdrR/of84ih03VU/ZohdCYYh2vZ8V+NmW9wOj8Dsj2ZgmL OKSRtmDgMyutH1MzfMyRjnQs3SXIohzYYhKlIbjs= Date: Mon, 16 Nov 2020 19:04:00 +0000 From: Mark Brown To: Srinivasa Rao Mandadapu Subject: Re: [PATCH] Asoc: qcom: lpass-platform: Fix memory leak Message-ID: <20201116190400.GE4739@sirena.org.uk> References: <1605416210-14530-1-git-send-email-srivasam@codeaurora.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="brEuL7wsLY8+TuWz" Content-Disposition: inline In-Reply-To: <1605416210-14530-1-git-send-email-srivasam@codeaurora.org> X-Cookie: Immanuel doesn't pun, he Kant. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, V Sujith Kumar Reddy , linux-arm-msm@vger.kernel.org, plai@codeaurora.org, tiwai@suse.com, lgirdwood@gmail.com, robh+dt@kernel.org, bjorn.andersson@linaro.org, agross@kernel.org, srinivas.kandagatla@linaro.org, Pavel Machek , rohitkr@codeaurora.org, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --brEuL7wsLY8+TuWz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Nov 15, 2020 at 10:26:50AM +0530, Srinivasa Rao Mandadapu wrote: > lpass_pcm_data is not freed in error paths. Free it in > error paths to avoid memory leak. Please use subject lines reflecting the general style for the subsystem, it makes it easier for people to spot patches that need to be reviewed. --brEuL7wsLY8+TuWz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl+yzSAACgkQJNaLcl1U h9CULgf/enozSv/x01jexTc5wfCzv9oWXsElA/pDZMQvwp2/Hix6fWeuOPzmWIo7 7PYUVqp5i6mJWejVH+qDpIVIwo2V/KzyT81D5JmooPoOglEZzKdiJcj0LK7mkkD+ T21T3qhVwaWml3gna9W8srBFidN3/gJ7+Agd5M3nQbxGtqINtMPBrJ1y7F6CsGhc +pTCkwcpDe/oOhWiV/iifsBhWYmkdCWHypN3vMSDMzuiE5u+PcnZchGhPSdCqrJF FXZ0dMoESRKqUS+MoVa0o3tAL6SEnY/gXvmFEJAw7bYCfpID82GULtwfDuuFmApK qXYtPZY8/noF2WY+pdHO582yoJ12ag== =NfJ5 -----END PGP SIGNATURE----- --brEuL7wsLY8+TuWz--