From: Vladimir Oltean <olteanv@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Russell King <linux@armlinux.org.uk>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org
Subject: Re: [PATCH v1 net-next] net: dsa: qca: ar9331: add ethtool stats support
Date: Tue, 17 Nov 2020 00:21:46 +0200 [thread overview]
Message-ID: <20201116222146.znetv5u2q2q2vk2j@skbuf> (raw)
In-Reply-To: <20201116133453.270b8db5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Mon, Nov 16, 2020 at 01:34:53PM -0800, Jakub Kicinski wrote:
> You must expose relevant statistics via the normal get_stats64 NDO
> before you start dumping free form stuff in ethtool -S.
Completely agree on the point, Jakub, but to be honest we don't give him
that possibility within the DSA framework today, see .ndo_get_stats64 in
net/dsa/slave.c which returns the generic dev_get_tstats64 implementation,
and not something that hooks into the hardware counters, or into the
driver at all, for that matter.
But it's good that you raise the point, I was thinking too that we
should do better in terms of keeping the software counters in sync with
the hardware. But what would be a good reference for keeping statistics
on an offloaded interface? Is it ok to just populate the netdev counters
based on the hardware statistics? And what about the statistics gathered
today in software, could we return them maybe via something like ifstat
--extended=cpu_hits?
next prev parent reply other threads:[~2020-11-16 22:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 7:35 [PATCH v1 net-next] net: dsa: qca: ar9331: add ethtool stats support Oleksij Rempel
2020-11-15 15:47 ` Andrew Lunn
2020-11-16 21:34 ` Jakub Kicinski
2020-11-16 22:21 ` Vladimir Oltean [this message]
2020-11-16 22:35 ` Jakub Kicinski
2020-11-16 23:00 ` Vladimir Oltean
2020-11-16 23:13 ` Jakub Kicinski
2020-11-16 23:27 ` Vladimir Oltean
2020-11-16 23:30 ` Florian Fainelli
2020-11-17 0:02 ` Jakub Kicinski
2020-11-17 0:10 ` Vladimir Oltean
2020-11-17 0:28 ` Jakub Kicinski
2020-11-20 12:59 ` Oleksij Rempel
2020-11-20 15:33 ` Jakub Kicinski
2020-11-16 23:56 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116222146.znetv5u2q2q2vk2j@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.