From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 248E0C6379D
	for <netdev@archiver.kernel.org>; Wed, 18 Nov 2020 17:40:04 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id B0780248EA
	for <netdev@archiver.kernel.org>; Wed, 18 Nov 2020 17:40:03 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="gWypMLsO"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727767AbgKRRjr (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Wed, 18 Nov 2020 12:39:47 -0500
Received: from mail.kernel.org ([198.145.29.99]:56414 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725943AbgKRRjr (ORCPT <rfc822;netdev@vger.kernel.org>);
        Wed, 18 Nov 2020 12:39:47 -0500
Received: from kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net (unknown [163.114.132.5])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 4919C248D3;
        Wed, 18 Nov 2020 17:39:46 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1605721186;
        bh=LPpvwJI/gBHb8rGQb9ullpKjv8aBduEkbMnbhCeWQq0=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=gWypMLsO8joDfpNGTexSwJr9kWUXpp8mHQvbUGacdiXygvlNmGkbImbmtZ44De2BQ
         eqp9N+Tg6J8hOJ7cZsQrCmFt8evvFSwFH0HxNwM7fvAC/8glhmlrL2eDnEKfRgvu8G
         hVS3LiDBAiyGgjxEyPBLUxW3+16xTHqpjr9LhU0Q=
Date:   Wed, 18 Nov 2020 09:39:45 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Antonio Cardace <acardace@redhat.com>
Cc:     netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
        Michal Kubecek <mkubecek@suse.cz>
Subject: Re: [PATCH net-next v5 3/6] netdevsim: support ethtool ring and
 coalesce settings
Message-ID: <20201118093945.2565691d@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
In-Reply-To: <20201118171827.48143-4-acardace@redhat.com>
References: <20201118171827.48143-1-acardace@redhat.com>
        <20201118171827.48143-4-acardace@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Wed, 18 Nov 2020 18:18:24 +0100 Antonio Cardace wrote:
>  	debugfs_create_bool("report_stats_tx", 0600, dir,
> -			    &ns->ethtool.report_stats_tx);
> +			    &ns->ethtool.pauseparam.report_stats_tx);

Sorry missed that in v4, this belongs in the previous patch, otherwise
patch 2 breaks bisection.