From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06C82C63798 for ; Wed, 18 Nov 2020 11:42:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB694241A5 for ; Wed, 18 Nov 2020 11:42:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727334AbgKRLmh (ORCPT ); Wed, 18 Nov 2020 06:42:37 -0500 Received: from foss.arm.com ([217.140.110.172]:52384 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726204AbgKRLmg (ORCPT ); Wed, 18 Nov 2020 06:42:36 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C5BFDD6E; Wed, 18 Nov 2020 03:42:35 -0800 (PST) Received: from localhost (unknown [10.1.198.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 677373F719; Wed, 18 Nov 2020 03:42:35 -0800 (PST) Date: Wed, 18 Nov 2020 11:42:34 +0000 From: Ionela Voinescu To: mingo@redhat.com, peterz@infradead.org, vincent.guittot@linaro.org, catalin.marinas@arm.com, will@kernel.org, rjw@rjwysocki.net, viresh.kumar@linaro.org Cc: dietmar.eggemann@arm.com, qperret@google.com, valentin.schneider@arm.com, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND v2 0/3] condition EAS enablement on FI support Message-ID: <20201118114233.GB9782@arm.com> References: <20201027180713.7642-1-ionela.voinescu@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201027180713.7642-1-ionela.voinescu@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi guys, On Tuesday 27 Oct 2020 at 18:07:10 (+0000), Ionela Voinescu wrote: > Given the maturity gained by cpufreq-based Frequency Invariance (FI) > support following the patches at [1], this series conditions Energy > Aware Scheduling (EAS) enablement on a frequency invariant system. > > Currently, EAS can be enabled on a system without FI support, leading > to incorrect (energy-wise) task placements. As no warning is emitted, > it could take some debugging effort to track the behavior back to the > lack of FI support; this series changes that by disabling EAS > (and advertising it) when FI support is missing. > > The series is structured as follows: > - 1/3 - create function that can rebuild the scheduling and EAS' > performance domains if EAS' initial conditions change > - 2/3 - arm64: rebuild scheduling and performance domains in the > case of late, counter-driven FI initialisation. > - 3/3 - condition EAS enablement on FI support > > RESEND v2: rebase and retest on v5.10-rc1 > This still applies nicely on v5.10-rc4. Peter, given that 1/3 and 2/3 are acked, do you think there's anything else that needs to be done for this? Thank you, Ionela. > v1 -> v2: > - v1 can be found at [2] > - 1/2 - moved now "static inline" rebuild_sched_domains_energy() stub > in sched/topology.h header, as suggested by Quentin. > - Changed the order of 2/3 and 3/3 to maintain bisection as suggested > by Quentin. > - 3/3 - place the warning under sched_debug() as per Quentin and > Dietmar's recommendations. > > [1] Most recent version at: > https://lore.kernel.org/lkml/20200901205549.30096-1-ionela.voinescu@arm.com/ > [2] https://lore.kernel.org/lkml/20200924123937.20938-1-ionela.voinescu@arm.com/ > > Many thanks, > Ionela. > > Ionela Voinescu (3): > sched/topology,schedutil: wrap sched domains rebuild > arm64: rebuild sched domains on invariance status changes > sched/topology: condition EAS enablement on FIE support > > arch/arm64/kernel/topology.c | 10 ++++++++++ > include/linux/sched/topology.h | 8 ++++++++ > kernel/sched/cpufreq_schedutil.c | 9 +-------- > kernel/sched/topology.c | 27 ++++++++++++++++++++------- > 4 files changed, 39 insertions(+), 15 deletions(-) > > > base-commit: 3650b228f83adda7e5ee532e2b90429c03f7b9ec > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62CDEC56202 for ; Wed, 18 Nov 2020 11:43:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF51A22244 for ; Wed, 18 Nov 2020 11:43:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="C6jvTKaE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF51A22244 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jbUsARJXzs/qNDco+1N5iqnicwhLp3p/uJRTPrC8ej0=; b=C6jvTKaEmRgzDKuXVbJxI6/tE MzoI7hoXwS5sC1FZYiNVNmtZ+3zLuajBhVmcDTMwzyUi20pxs3eMBDExELZk8lOUJ2nZmKnvcbDVm 83NfjZGjD9A9nyw3QZnVKeoXch8pq89n2Zg08Vmjq07OXYzL/BzjI/j5DqJYQiULANZjG4eocT9NI SQyy4xjQU1t4jhmTIr8R7ONK5I49SURVW9t9/VU1YrupBaM+7DTrqb5xRGwcosCJhagHqASA9hI5A 5Wi47OIC2O8tQwwY+HCFer1NLDiq9TWYPszpkGrGxCIEJl9HAW7bCR0FapDh0CtjAuzoHos6gYaoJ l/hWg2onw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfLrI-0003VJ-Qp; Wed, 18 Nov 2020 11:42:44 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfLrF-0003T5-Bi for linux-arm-kernel@lists.infradead.org; Wed, 18 Nov 2020 11:42:42 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C5BFDD6E; Wed, 18 Nov 2020 03:42:35 -0800 (PST) Received: from localhost (unknown [10.1.198.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 677373F719; Wed, 18 Nov 2020 03:42:35 -0800 (PST) Date: Wed, 18 Nov 2020 11:42:34 +0000 From: Ionela Voinescu To: mingo@redhat.com, peterz@infradead.org, vincent.guittot@linaro.org, catalin.marinas@arm.com, will@kernel.org, rjw@rjwysocki.net, viresh.kumar@linaro.org Subject: Re: [PATCH RESEND v2 0/3] condition EAS enablement on FI support Message-ID: <20201118114233.GB9782@arm.com> References: <20201027180713.7642-1-ionela.voinescu@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201027180713.7642-1-ionela.voinescu@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201118_064241_472261_54A9D9B0 X-CRM114-Status: GOOD ( 19.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, qperret@google.com, linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com, valentin.schneider@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi guys, On Tuesday 27 Oct 2020 at 18:07:10 (+0000), Ionela Voinescu wrote: > Given the maturity gained by cpufreq-based Frequency Invariance (FI) > support following the patches at [1], this series conditions Energy > Aware Scheduling (EAS) enablement on a frequency invariant system. > > Currently, EAS can be enabled on a system without FI support, leading > to incorrect (energy-wise) task placements. As no warning is emitted, > it could take some debugging effort to track the behavior back to the > lack of FI support; this series changes that by disabling EAS > (and advertising it) when FI support is missing. > > The series is structured as follows: > - 1/3 - create function that can rebuild the scheduling and EAS' > performance domains if EAS' initial conditions change > - 2/3 - arm64: rebuild scheduling and performance domains in the > case of late, counter-driven FI initialisation. > - 3/3 - condition EAS enablement on FI support > > RESEND v2: rebase and retest on v5.10-rc1 > This still applies nicely on v5.10-rc4. Peter, given that 1/3 and 2/3 are acked, do you think there's anything else that needs to be done for this? Thank you, Ionela. > v1 -> v2: > - v1 can be found at [2] > - 1/2 - moved now "static inline" rebuild_sched_domains_energy() stub > in sched/topology.h header, as suggested by Quentin. > - Changed the order of 2/3 and 3/3 to maintain bisection as suggested > by Quentin. > - 3/3 - place the warning under sched_debug() as per Quentin and > Dietmar's recommendations. > > [1] Most recent version at: > https://lore.kernel.org/lkml/20200901205549.30096-1-ionela.voinescu@arm.com/ > [2] https://lore.kernel.org/lkml/20200924123937.20938-1-ionela.voinescu@arm.com/ > > Many thanks, > Ionela. > > Ionela Voinescu (3): > sched/topology,schedutil: wrap sched domains rebuild > arm64: rebuild sched domains on invariance status changes > sched/topology: condition EAS enablement on FIE support > > arch/arm64/kernel/topology.c | 10 ++++++++++ > include/linux/sched/topology.h | 8 ++++++++ > kernel/sched/cpufreq_schedutil.c | 9 +-------- > kernel/sched/topology.c | 27 ++++++++++++++++++++------- > 4 files changed, 39 insertions(+), 15 deletions(-) > > > base-commit: 3650b228f83adda7e5ee532e2b90429c03f7b9ec > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel