From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Prashant Malani <pmalani@chromium.org>
Cc: Benson Leung <bleung@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: [RFC PATCH 0/3] usb: typec: Product Type time
Date: Wed, 18 Nov 2020 18:00:56 +0300 [thread overview]
Message-ID: <20201118150059.3419-1-heikki.krogerus@linux.intel.com> (raw)
Hi Prashant,
The original discussion [1].
This proposal is in practice a compromise. I came to the conclusion
that we probable should expose the product type separately after all.
The reason for that is because we may in some cases actually know the
product type even when we don't have access to the Discover Identity
response. UCSI for example in practice gives us at least the cable
product type even though it does not let us know the response to the
Discover Identity command.
So my proposal here is that we add an attribute for the product type
itself, showing the product type as a string. Then we also add the
attribute for the product type specific VDOs which we place under the
identity directory more or less the way you originally proposed.
Note. I have not tested these at all.
[1] https://lore.kernel.org/linux-usb/20201023214328.1262883-2-pmalani@chromium.org/
Heikki Krogerus (2):
usb: pd: DFP product types
usb: typec: Add product_type sysfs attribute file for partners and
cables
Prashant Malani (1):
usb: typec: Expose Product Type VDOs via sysfs
Documentation/ABI/testing/sysfs-class-typec | 55 +++++++
drivers/usb/typec/class.c | 173 +++++++++++++++++++-
include/linux/usb/pd_vdo.h | 16 +-
3 files changed, 234 insertions(+), 10 deletions(-)
--
2.29.2
next reply other threads:[~2020-11-18 15:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 15:00 Heikki Krogerus [this message]
2020-11-18 15:00 ` [RFC PATCH 1/3] usb: pd: DFP product types Heikki Krogerus
2020-11-18 15:00 ` [RFC PATCH 2/3] usb: typec: Add product_type sysfs attribute file for partners and cables Heikki Krogerus
2020-11-18 15:57 ` Greg Kroah-Hartman
2020-11-18 17:48 ` Benson Leung
2020-11-19 11:11 ` Heikki Krogerus
2020-11-18 18:53 ` Prashant Malani
2020-11-19 11:05 ` Heikki Krogerus
2020-11-19 11:11 ` Prashant Malani
2020-11-19 14:12 ` Heikki Krogerus
2020-11-18 15:00 ` [RFC PATCH 3/3] usb: typec: Expose Product Type VDOs via sysfs Heikki Krogerus
2020-11-18 15:56 ` Greg Kroah-Hartman
2020-11-19 12:11 ` Heikki Krogerus
2020-11-18 18:39 ` [RFC PATCH 0/3] usb: typec: Product Type time Prashant Malani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201118150059.3419-1-heikki.krogerus@linux.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=bleung@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pmalani@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.