From: Andre Przywara <andre.przywara@arm.com>
To: u-boot@lists.denx.de
Subject: [PATCH v3 0/3] tools/sunxi: Use mkimage for SPL generation
Date: Wed, 18 Nov 2020 17:32:01 +0000 [thread overview]
Message-ID: <20201118173204.5811-1-andre.przywara@arm.com> (raw)
Hi,
an update addressing Samuel's review comments and fixing the broken
tools-only build.
==================
So far creating a bootable SPL image for Allwinner based boards uses
the mksunxiboot tool. Most other platforms seemed to have integrated this
kind of functionality into the common mkimage tool.
Since there is nothing special about the Allwinner image in this respect,
just add support for the so-called "eGON" image type into mkimage. If there
was a particular reason this hasn't been done before, please let me know.
This will eventually allow us to remove mksunxiboot, but I leave it around
for now in case of regressions and since some people depend on it from
external projects.
Patch 1/3 splits some existing sunxi specific header file, so we can
share the eGON header definition between the tools and the SPL.
Patch 2/3 adds the actual support to mkimage, patch 3/3 then switches
the Makefile to use mkimage instead of mksunxiboot.
I tested all 152 Allwinner boards by building each
u-boot-sunxi-with-spl.bin and comparing them against the version created
using mksunxiboot (using SOURCE_DATE_EPOCH and .scmversion to create
reproducible builds, and by reverting just patch 3/3).
All files before and after were identical.
Cheers,
Andre
Changelog v2 .. v3:
- factor out eGON struct into separate header file
- only print extended header information when applicable
- remove redundant alignment
- minor cosmetic fixes
Changelog v1 .. v2:
- Drop already merged cleanup patch (v1 1/3)
- replace relative include path
- remove already defined ALIGN macro
- rebase against current master
Andre Przywara (3):
sunxi: Factor out eGON BROM header description
tools: mkimage: Add Allwinner eGON support
sunxi: Use mkimage for SPL boot image generation
arch/arm/include/asm/arch-sunxi/spl.h | 65 +-----------
common/image.c | 1 +
include/image.h | 1 +
include/sunxi_image.h | 82 ++++++++++++++++
scripts/Makefile.spl | 8 +-
tools/Makefile | 1 +
tools/sunxi_egon.c | 136 ++++++++++++++++++++++++++
7 files changed, 226 insertions(+), 68 deletions(-)
create mode 100644 include/sunxi_image.h
create mode 100644 tools/sunxi_egon.c
--
2.17.5
next reply other threads:[~2020-11-18 17:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 17:32 Andre Przywara [this message]
2020-11-18 17:32 ` [PATCH v3 1/3] sunxi: Factor out eGON BROM header description Andre Przywara
2020-11-18 17:32 ` [PATCH v3 2/3] tools: mkimage: Add Allwinner eGON support Andre Przywara
2020-11-19 4:05 ` Samuel Holland
2020-11-18 17:32 ` [PATCH v3 3/3] sunxi: Use mkimage for SPL boot image generation Andre Przywara
2020-11-19 4:06 ` [PATCH v3 0/3] tools/sunxi: Use mkimage for SPL generation Samuel Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201118173204.5811-1-andre.przywara@arm.com \
--to=andre.przywara@arm.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.