All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tao Zhou <t1zhou@163.com>
To: "Guilherme G. Piccoli" <gpiccoli@canonical.com>
Cc: vincent.guittot@linaro.org, bsegall@google.com,
	dietmar.eggemann@arm.com, juri.lelli@redhat.com,
	zohooouoto@zoho.com.cn, mgorman@suse.de, mingo@redhat.com,
	ouwen210@hotmail.com, pauld@redhat.com, peterz@infradead.org,
	pkondeti@codeaurora.org, rostedt@goodmis.org,
	Jay Vosburgh <jay.vosburgh@canonical.com>,
	Gavin Guo <gavin.guo@canonical.com>,
	halves@canonical.com, nivedita.singhvi@canonical.com,
	linux-kernel@vger.kernel.org, t1zhou@163.com
Subject: Re: [PATCH v3] sched/fair: fix unthrottle_cfs_rq for leaf_cfs_rq list
Date: Thu, 19 Nov 2020 07:30:39 +0800	[thread overview]
Message-ID: <20201118233039.GA6015@geo.homenetwork> (raw)
In-Reply-To: <17fc60a3-cc50-7cff-eb46-904c2f0c416e@canonical.com>

Hi Guilherme,

On Wed, Nov 18, 2020 at 07:56:38PM -0300, Guilherme G. Piccoli wrote:
> Hi Vincent (and all CCed), I'm sorry to ping about such "old" patch, but
> we experienced a similar condition to what this patch addresses; it's an
> older kernel (4.15.x) but when suggesting the users to move to an
> updated 5.4.x kernel, we noticed that this patch is not there, although
> similar ones are (like [0] and [1]).
> 
> So, I'd like to ask if there's any particular reason to not backport
> this fix to stable kernels, specially the longterm 5.4. The main reason
> behind the question is that the code is very complex for non-experienced
> scheduler developers, and I'm afraid in suggesting such backport to 5.4
> and introduce complex-to-debug issues.
> 
> Let me know your thoughts Vincent (and all CCed), thanks in advance.
> Cheers,
> 
> 
> Guilherme
> 
> 
> P.S. For those that deleted this thread from the email client, here's a
> link:
> https://lore.kernel.org/lkml/20200513135528.4742-1-vincent.guittot@linaro.org/
> 
> 
> [0]
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fe61468b2cb
> 
> [1]
> https://lore.kernel.org/lkml/20200506141821.GA9773@lorien.usersys.redhat.com/
> <- great thread BTW!

Backport this patch to 5.4 need runnable_avg. but it is not introduced in 5.4
that time(please correct me if I am wrong).


Thanks,
Tao


  reply	other threads:[~2020-11-18 23:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-18 22:56 [PATCH v3] sched/fair: fix unthrottle_cfs_rq for leaf_cfs_rq list Guilherme G. Piccoli
2020-11-18 23:30 ` Tao Zhou [this message]
2020-11-18 23:50 ` Tao Zhou
2020-11-19  0:33   ` Tao Zhou
2020-11-19  8:36     ` Vincent Guittot
2020-11-19 11:34       ` Guilherme G. Piccoli
2020-11-19 13:25         ` Vincent Guittot
2020-11-19 14:07           ` Guilherme Piccoli
2021-06-24 10:29           ` Po-Hsu Lin
2021-06-24 12:31             ` Vincent Guittot
  -- strict thread matches above, loose matches on Subject: below --
2020-05-13 13:55 Vincent Guittot
2020-05-13 18:25 ` bsegall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201118233039.GA6015@geo.homenetwork \
    --to=t1zhou@163.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=gavin.guo@canonical.com \
    --cc=gpiccoli@canonical.com \
    --cc=halves@canonical.com \
    --cc=jay.vosburgh@canonical.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=nivedita.singhvi@canonical.com \
    --cc=ouwen210@hotmail.com \
    --cc=pauld@redhat.com \
    --cc=peterz@infradead.org \
    --cc=pkondeti@codeaurora.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=zohooouoto@zoho.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.