From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A26D4C6379F for ; Thu, 19 Nov 2020 15:46:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 57760246CA for ; Thu, 19 Nov 2020 15:46:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="eJFgy/ER" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728910AbgKSPqi (ORCPT ); Thu, 19 Nov 2020 10:46:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:42152 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728583AbgKSPqh (ORCPT ); Thu, 19 Nov 2020 10:46:37 -0500 Received: from kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 813182224A; Thu, 19 Nov 2020 15:46:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605800796; bh=ZvKprxlPeDR11nAv0IeB4RNZKc7/A57CYBYK8dwYGvA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=eJFgy/ERDAHnV44gummxbYRBsX1kbc6TtE7RiXMtxbNIkKe7OhRg5AJfcPrxFKqjD RvGoJEuoxmZSF+VACQj2A8eU2SVNDpagHniFKlgF8AkQdfRkaQSpgD5aLptwItPHad ogoqmgOfEn08wfYIcOdiAOnWKZDBDMa2FN3swJpI= Date: Thu, 19 Nov 2020 07:46:34 -0800 From: Jakub Kicinski To: Guenter Roeck Cc: Tao Ren , Andrew Lunn , Jean Delvare , Jonathan Corbet , Alexei Starovoitov , Daniel Borkmann , "David S . Miller" , Jesper Dangaard Brouer , John Fastabend , linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, openbmc@lists.ozlabs.org, taoren@fb.com, mikechoi@fb.com Subject: Re: [PATCH v2 0/2] hwmon: (max127) Add Maxim MAX127 hardware monitoring Message-ID: <20201119074634.2e9cb21b@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20201119012653.GA249502@roeck-us.net> References: <20201118230929.18147-1-rentao.bupt@gmail.com> <20201118232719.GI1853236@lunn.ch> <20201118234252.GA18681@taoren-ubuntu-R90MNF91> <20201119010119.GA248686@roeck-us.net> <20201119012653.GA249502@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Wed, 18 Nov 2020 17:26:53 -0800 Guenter Roeck wrote: > On Wed, Nov 18, 2020 at 05:01:19PM -0800, Guenter Roeck wrote: > > On Wed, Nov 18, 2020 at 03:42:53PM -0800, Tao Ren wrote: > > > On Thu, Nov 19, 2020 at 12:27:19AM +0100, Andrew Lunn wrote: > > > > On Wed, Nov 18, 2020 at 03:09:27PM -0800, rentao.bupt@gmail.com wrote: > > > > > From: Tao Ren > > > > > > > > > > The patch series adds hardware monitoring driver for the Maxim MAX127 > > > > > chip. > > > > > > > > Hi Tao > > > > > > > > Why are using sending a hwmon driver to the networking mailing list? > > > > > > > > Andrew > > > > > > Hi Andrew, > > > > > > I added netdev because the mailing list is included in "get_maintainer.pl > > > Documentation/hwmon/index.rst" output. Is it the right command to find > > > reviewers? Could you please suggest? Thank you. > > > > I have no idea why running get_maintainer.pl on > > Documentation/hwmon/index.rst returns such a large list of mailing > > lists and people. For some reason it includes everyone in the XDP > > maintainer list. If anyone has an idea how that happens, please > > let me know - we'll want to get this fixed to avoid the same problem > > in the future. > > I found it. The XDP maintainer entry has: > > K: xdp > > This matches Documentation/hwmon/index.rst. > > $ grep xdp Documentation/hwmon/index.rst > xdpe12284 > > It seems to me that a context match such as "xdp" in MAINTAINERS isn't > really appropriate. "xdp" matches a total of 348 files in the kernel. > The large majority of those is not XDP related. The maintainers > of XDP (and all the listed mailing lists) should not be surprised > to get a large number of odd review requests if they want to review > every single patch on files which include the term "xdp". Agreed, we should fix this. For maintainers with high patch volume life would be so much easier if people CCed the right folks to get reviews, so we should try our best to fix get_maintainer. XDP folks, any opposition to changing the keyword / filename to: [^a-z0-9]xdp[^a-z0-9] ? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18FE6C63697 for ; Thu, 19 Nov 2020 15:48:32 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39B5620643 for ; Thu, 19 Nov 2020 15:48:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="eJFgy/ER" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39B5620643 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4CcPGf4HHszDqlF for ; Fri, 20 Nov 2020 02:48:26 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=kuba@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=default header.b=eJFgy/ER; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4CcPDb6vpRzDqlr for ; Fri, 20 Nov 2020 02:46:39 +1100 (AEDT) Received: from kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 813182224A; Thu, 19 Nov 2020 15:46:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605800796; bh=ZvKprxlPeDR11nAv0IeB4RNZKc7/A57CYBYK8dwYGvA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=eJFgy/ERDAHnV44gummxbYRBsX1kbc6TtE7RiXMtxbNIkKe7OhRg5AJfcPrxFKqjD RvGoJEuoxmZSF+VACQj2A8eU2SVNDpagHniFKlgF8AkQdfRkaQSpgD5aLptwItPHad ogoqmgOfEn08wfYIcOdiAOnWKZDBDMa2FN3swJpI= Date: Thu, 19 Nov 2020 07:46:34 -0800 From: Jakub Kicinski To: Guenter Roeck Subject: Re: [PATCH v2 0/2] hwmon: (max127) Add Maxim MAX127 hardware monitoring Message-ID: <20201119074634.2e9cb21b@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20201119012653.GA249502@roeck-us.net> References: <20201118230929.18147-1-rentao.bupt@gmail.com> <20201118232719.GI1853236@lunn.ch> <20201118234252.GA18681@taoren-ubuntu-R90MNF91> <20201119010119.GA248686@roeck-us.net> <20201119012653.GA249502@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hwmon@vger.kernel.org, Andrew Lunn , Jean Delvare , Jesper Dangaard Brouer , Daniel Borkmann , Jonathan Corbet , netdev@vger.kernel.org, openbmc@lists.ozlabs.org, linux-doc@vger.kernel.org, John Fastabend , Alexei Starovoitov , linux-kernel@vger.kernel.org, taoren@fb.com, Tao Ren , bpf@vger.kernel.org, mikechoi@fb.com, "David S . Miller" Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Wed, 18 Nov 2020 17:26:53 -0800 Guenter Roeck wrote: > On Wed, Nov 18, 2020 at 05:01:19PM -0800, Guenter Roeck wrote: > > On Wed, Nov 18, 2020 at 03:42:53PM -0800, Tao Ren wrote: > > > On Thu, Nov 19, 2020 at 12:27:19AM +0100, Andrew Lunn wrote: > > > > On Wed, Nov 18, 2020 at 03:09:27PM -0800, rentao.bupt@gmail.com wrote: > > > > > From: Tao Ren > > > > > > > > > > The patch series adds hardware monitoring driver for the Maxim MAX127 > > > > > chip. > > > > > > > > Hi Tao > > > > > > > > Why are using sending a hwmon driver to the networking mailing list? > > > > > > > > Andrew > > > > > > Hi Andrew, > > > > > > I added netdev because the mailing list is included in "get_maintainer.pl > > > Documentation/hwmon/index.rst" output. Is it the right command to find > > > reviewers? Could you please suggest? Thank you. > > > > I have no idea why running get_maintainer.pl on > > Documentation/hwmon/index.rst returns such a large list of mailing > > lists and people. For some reason it includes everyone in the XDP > > maintainer list. If anyone has an idea how that happens, please > > let me know - we'll want to get this fixed to avoid the same problem > > in the future. > > I found it. The XDP maintainer entry has: > > K: xdp > > This matches Documentation/hwmon/index.rst. > > $ grep xdp Documentation/hwmon/index.rst > xdpe12284 > > It seems to me that a context match such as "xdp" in MAINTAINERS isn't > really appropriate. "xdp" matches a total of 348 files in the kernel. > The large majority of those is not XDP related. The maintainers > of XDP (and all the listed mailing lists) should not be surprised > to get a large number of odd review requests if they want to review > every single patch on files which include the term "xdp". Agreed, we should fix this. For maintainers with high patch volume life would be so much easier if people CCed the right folks to get reviews, so we should try our best to fix get_maintainer. XDP folks, any opposition to changing the keyword / filename to: [^a-z0-9]xdp[^a-z0-9] ?