From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D312C6379D for ; Thu, 19 Nov 2020 09:29:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 14F35246D1 for ; Thu, 19 Nov 2020 09:29:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="W7Ip5bay" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726970AbgKSJ32 (ORCPT ); Thu, 19 Nov 2020 04:29:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726778AbgKSJ32 (ORCPT ); Thu, 19 Nov 2020 04:29:28 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8BD0C0613CF for ; Thu, 19 Nov 2020 01:29:27 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id p22so6461814wmg.3 for ; Thu, 19 Nov 2020 01:29:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3JcU1zb6u51rjqw92Mq4g5Cn0LJ6Or+HL8YfF22EvLM=; b=W7Ip5bayzomghQnl06eSsIee8Qt9OFEXsbQgZAju7Tck5ryIp1znlAMWCoqtknPV8g 7W9QBI+GXm8CVeKN0dmt1LkNVrGZSzQPCobGQsnqsZ6dOVv+gwgD1a9VjF5ZFDCCtYwr /EYieeI32R/rOVJ4pEC98SoLb/+N3OSHIvxHTMy+Ktm0yU1G/nCsQF9gaVaoNbz/PVTA VVw/g9QzJaFDotVxD4nVL2q8aRMe8BmPhEqNd0khTLpEObgDnT+AMBKhSGOYSCuGTE1S 2DrWO4rBDWth99p4T/4QJrH5VDXlcuWC5NKtZqetOQLMQIeJ1+yk/V1bHfVxqIfaMBaI ijdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3JcU1zb6u51rjqw92Mq4g5Cn0LJ6Or+HL8YfF22EvLM=; b=kBSxbRVx8T27Zbflv+XzIEiDDZkv6C6Xvip3ziDKRji6NZcVdCQAMlSNeg884rNjx9 asaBOYyhgXi/dyhZXcdD8L5QfoWr7XQ/qlMoTapa4Ijfpg9+44t1FTbtelYkjESeRvhM Nu17tb8R5lBrScstazs1XMizb3GlIpuQB7qJ9oC0H4HS0+I87n3zUrsWIA3stif3rN/8 QvUlXRK/Yuvlb5sjV4UxxWOmGphfaXrrzcIWrhOu6pQZMflr/YHeL+kuRGFhCoAKg/H2 maFknMoOBD7yz5o2Ey+jt2F7PoTuf+HVd1FBJKbBZoal/Ny4i3UAiWzr6zyoxI+Gp4Hn bKmA== X-Gm-Message-State: AOAM530doUaEgYR00Yv6FgvyRDXVnBKP/JV1Ugo0b9PoTYA2f6HQPAnb ZKDQWh5fj3QoSQp8LHx+3cFroHaEzD2u8A== X-Google-Smtp-Source: ABdhPJzZT2RkNoWhXvP6tMmxJ/IWICezm7c5mwJnpHvk8eoIY48sGpyqV3pAwPLpkUwa+COXNIsc0A== X-Received: by 2002:a1c:a5d8:: with SMTP id o207mr3536870wme.0.1605778166295; Thu, 19 Nov 2020 01:29:26 -0800 (PST) Received: from google.com ([2a00:79e0:d:210:f693:9fff:fef4:a7ef]) by smtp.gmail.com with ESMTPSA id j4sm37543361wrn.83.2020.11.19.01.29.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Nov 2020 01:29:25 -0800 (PST) Date: Thu, 19 Nov 2020 09:29:22 +0000 From: Quentin Perret To: Will Deacon Cc: linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin Marinas , Marc Zyngier , Greg Kroah-Hartman , Peter Zijlstra , Morten Rasmussen , Qais Yousef , Suren Baghdasaryan , Tejun Heo , Li Zefan , Johannes Weiner , Ingo Molnar , Juri Lelli , Vincent Guittot , kernel-team@android.com Subject: Re: [PATCH v3 09/14] cpuset: Don't use the cpu_possible_mask as a last resort for cgroup v1 Message-ID: <20201119092922.GC2416649@google.com> References: <20201113093720.21106-1-will@kernel.org> <20201113093720.21106-10-will@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201113093720.21106-10-will@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 13 Nov 2020 at 09:37:14 (+0000), Will Deacon wrote: > If the scheduler cannot find an allowed CPU for a task, > cpuset_cpus_allowed_fallback() will widen the affinity to cpu_possible_mask > if cgroup v1 is in use. > > In preparation for allowing architectures to provide their own fallback > mask, just return early if we're not using cgroup v2 and allow > select_fallback_rq() to figure out the mask by itself. > > Cc: Li Zefan > Cc: Tejun Heo > Cc: Johannes Weiner > Signed-off-by: Will Deacon That makes select_fallback_rq() slightly more expensive if you're using cgroup v1, but I don't expect that be really measurable in real-world workloads, so: Reviewed-by: Quentin Perret Thanks, Quentin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 938E0C388F9 for ; Thu, 19 Nov 2020 09:32:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D9E32468D for ; Thu, 19 Nov 2020 09:32:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="yfAYKmwL"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="W7Ip5bay" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D9E32468D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bXf+GBVh6UxTQe9pASA/6sHh/nh7d4KZ5Kp4UvqsDno=; b=yfAYKmwL/WZLHeVeDqhzk9cOO qPs+V6btiC3LnfqCh17eSco1vLH9OIj2BynTUJdyhX507RdDU6rkOAkNwkNjc3cJ3fJ/Nen6PXLWa 7Sg7YL/yXyoG6/D8Z2Vqio/OEFYzwDvc8tNbmbMCsQa2uOkoClx0thCkVvlF9mNvui29K/QE8O5W9 04P0JlbX0W7PtFGm4AZ4s4Skjqfttve2QfUE0IAVlSTxf3w8UpAhhEPXU2tiQ0J1SJ48vOOKEgOJx IINT4HQnBKC9RFlSCdFMZ77/82hEh9u8yymFhEEdMi5fKwQt3lSG+8Z6BfuZsqb8Y2pf3QxZkWx3R 9WUlQzLIQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfgG5-0007Pj-UA; Thu, 19 Nov 2020 09:29:42 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfgFt-0007LI-9v for linux-arm-kernel@lists.infradead.org; Thu, 19 Nov 2020 09:29:30 +0000 Received: by mail-wm1-x341.google.com with SMTP id a3so6072903wmb.5 for ; Thu, 19 Nov 2020 01:29:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3JcU1zb6u51rjqw92Mq4g5Cn0LJ6Or+HL8YfF22EvLM=; b=W7Ip5bayzomghQnl06eSsIee8Qt9OFEXsbQgZAju7Tck5ryIp1znlAMWCoqtknPV8g 7W9QBI+GXm8CVeKN0dmt1LkNVrGZSzQPCobGQsnqsZ6dOVv+gwgD1a9VjF5ZFDCCtYwr /EYieeI32R/rOVJ4pEC98SoLb/+N3OSHIvxHTMy+Ktm0yU1G/nCsQF9gaVaoNbz/PVTA VVw/g9QzJaFDotVxD4nVL2q8aRMe8BmPhEqNd0khTLpEObgDnT+AMBKhSGOYSCuGTE1S 2DrWO4rBDWth99p4T/4QJrH5VDXlcuWC5NKtZqetOQLMQIeJ1+yk/V1bHfVxqIfaMBaI ijdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3JcU1zb6u51rjqw92Mq4g5Cn0LJ6Or+HL8YfF22EvLM=; b=go4b5qKYzlzfe7qWL6hJf2znhH3wHmAqtkly1tgetYX6xwJ6ag4a8oMcWNyHT6Fm2Z axEoIVgDNtasXuzDdesbmknqPyGjAcFQaJdzPS1MeY1BHm8UWw9Od+qf/Rtr3qPV/Hu4 S6IT26iGQYKLxtzq3EEDNeqiGgkQYrlL96tBQ59/fYkZofmlizGLVryIdwOUnxUsHtru Onhh264eyj6+gP5hf2zCAS7NtTiwSS8n0Pe+vpBjomt6IJrb0iAf7HQCanIU2+MHRXkz d+HD6u1KmjXwmCG/ZUo88oXO78FWFWB36m7VFoz7KyeLacbNsmoiUkwquqjAKLEH1Gl7 4S0w== X-Gm-Message-State: AOAM532zOzlGDPMjE0sk0HLOGisYuoSNMOx8PREEryepYKsvo9XQpDZV ieA3QcMH4buJwWoImmz/OcsfvA== X-Google-Smtp-Source: ABdhPJzZT2RkNoWhXvP6tMmxJ/IWICezm7c5mwJnpHvk8eoIY48sGpyqV3pAwPLpkUwa+COXNIsc0A== X-Received: by 2002:a1c:a5d8:: with SMTP id o207mr3536870wme.0.1605778166295; Thu, 19 Nov 2020 01:29:26 -0800 (PST) Received: from google.com ([2a00:79e0:d:210:f693:9fff:fef4:a7ef]) by smtp.gmail.com with ESMTPSA id j4sm37543361wrn.83.2020.11.19.01.29.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Nov 2020 01:29:25 -0800 (PST) Date: Thu, 19 Nov 2020 09:29:22 +0000 From: Quentin Perret To: Will Deacon Subject: Re: [PATCH v3 09/14] cpuset: Don't use the cpu_possible_mask as a last resort for cgroup v1 Message-ID: <20201119092922.GC2416649@google.com> References: <20201113093720.21106-1-will@kernel.org> <20201113093720.21106-10-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201113093720.21106-10-will@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201119_042929_492631_1B188B61 X-CRM114-Status: GOOD ( 14.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Marc Zyngier , kernel-team@android.com, Vincent Guittot , Juri Lelli , Ingo Molnar , Peter Zijlstra , Catalin Marinas , Johannes Weiner , linux-kernel@vger.kernel.org, Qais Yousef , Li Zefan , Greg Kroah-Hartman , Tejun Heo , Suren Baghdasaryan , Morten Rasmussen , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Friday 13 Nov 2020 at 09:37:14 (+0000), Will Deacon wrote: > If the scheduler cannot find an allowed CPU for a task, > cpuset_cpus_allowed_fallback() will widen the affinity to cpu_possible_mask > if cgroup v1 is in use. > > In preparation for allowing architectures to provide their own fallback > mask, just return early if we're not using cgroup v2 and allow > select_fallback_rq() to figure out the mask by itself. > > Cc: Li Zefan > Cc: Tejun Heo > Cc: Johannes Weiner > Signed-off-by: Will Deacon That makes select_fallback_rq() slightly more expensive if you're using cgroup v1, but I don't expect that be really measurable in real-world workloads, so: Reviewed-by: Quentin Perret Thanks, Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel