From: Michal Hocko <mhocko@suse.com>
To: Rik van Riel <riel@surriel.com>
Cc: hughd@google.com, xuyu@linux.alibaba.com,
akpm@linux-foundation.org, mgorman@suse.de, aarcange@redhat.com,
willy@infradead.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com, linux-mm@kvack.org, vbabka@suse.cz,
Andrey Grodzovsky <andrey.grodzovsky@amd.com>,
Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 2/2] mm,thp,shm: limit gfp mask to no more than specified
Date: Thu, 19 Nov 2020 10:38:42 +0100 [thread overview]
Message-ID: <20201119093842.GC12284@dhcp22.suse.cz> (raw)
In-Reply-To: <05f80e300fd4907b99837b5973db8985b7312d3f.camel@surriel.com>
On Fri 13-11-20 22:40:40, Rik van Riel wrote:
> On Thu, 2020-11-12 at 12:22 +0100, Michal Hocko wrote:
> > [Cc Chris for i915 and Andray]
> >
> > On Thu 05-11-20 14:15:08, Rik van Riel wrote:
> > > Matthew Wilcox pointed out that the i915 driver opportunistically
> > > allocates tmpfs memory, but will happily reclaim some of its
> > > pool if no memory is available.
> >
> > It would be good to explicitly mention the requested gfp flags for
> > those
> > allocations. i915 uses __GFP_NORETRY | __GFP_NOWARN, or GFP_KERNEL.
> > Is
> > __shmem_rw really meant to not allocate from highmeme/movable zones?
> > Can
> > it be ever backed by THPs?
>
> You are right, I need to copy the zone flags __GFP_DMA
> through
> __GFP_MOVABLE straight from the limiting gfp_mask
> into the gfp_mask used for THP allocations, and not use
> the default THP zone flags if the caller specifies something
> else.
>
> I'll send out a new version that fixes that.
Can we make one step back here and actually check whether all this is
actually needed for those shmem users before adding more hacks here and
there?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2020-11-19 9:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 19:15 [PATCH 0/2] mm,thp,shm: limit shmem THP alloc gfp_mask Rik van Riel
2020-11-05 19:15 ` [PATCH 1/2] mm,thp,shmem: " Rik van Riel
2020-11-12 10:52 ` Michal Hocko
2020-11-14 3:44 ` Rik van Riel
2020-11-14 3:44 ` Rik van Riel
2020-11-19 9:37 ` Michal Hocko
2020-11-05 19:15 ` [PATCH 2/2] mm,thp,shm: limit gfp mask to no more than specified Rik van Riel
2020-11-06 3:05 ` Hillf Danton
2020-11-06 17:53 ` Rik van Riel
2020-11-06 17:53 ` Rik van Riel
2020-11-07 1:58 ` Hillf Danton
2020-11-12 11:22 ` Michal Hocko
2020-11-14 3:40 ` Rik van Riel
2020-11-14 3:40 ` Rik van Riel
2020-11-19 9:38 ` Michal Hocko [this message]
2020-11-23 19:39 ` Rik van Riel
2020-11-23 19:39 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201119093842.GC12284@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andrey.grodzovsky@amd.com \
--cc=chris@chris-wilson.co.uk \
--cc=hughd@google.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=riel@surriel.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=xuyu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.