Re: [igt-dev] [PATCH v5 8/8] tests/fbdev: Add tests for read/writing with NULL-pointer buffers

[Petri Latvala <petri.latvala@intel.com>]

On Thu, Nov 19, 2020 at 02:47:46PM +0100, Thomas Zimmermann wrote:
> Trying to read and write with a NULL-pointer buffer should fail and
> report EFAULT.
> 
> v4:
> 	* replace igt_require() by igt_assert() in "nullptr" (Petri)

But they're still igt_requires in there?


-- 
Petri Latvala


> 	* add nullptr test to CI
> v3:
> 	* put igt_describe() before igt_subtest() (Petri)
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
>  tests/fbdev.c                         | 11 +++++++++++
>  tests/intel-ci/fast-feedback.testlist |  1 +
>  2 files changed, 12 insertions(+)
> 
> diff --git a/tests/fbdev.c b/tests/fbdev.c
> index 62aa99b4..c6139124 100644
> --- a/tests/fbdev.c
> +++ b/tests/fbdev.c
> @@ -229,6 +229,17 @@ static void framebuffer_tests(int fd)
>  		igt_assert_f(ret == 0, "read at EOF, ret=%zd\n", ret);
>  	}
>  
> +	igt_describe("Check framebuffer access with NULL");
> +	igt_subtest("nullptr") {
> +		ssize_t ret;
> +
> +		ret = pread(fd, NULL, fix_info.smem_len, 0);
> +		igt_require_f((ret == -1) && (errno == EFAULT), "reading into NULL did not return EFAULT, ret=%zd\n", ret);
> +
> +		ret = pwrite(fd, NULL, fix_info.smem_len, 0);
> +		igt_require_f((ret == -1) && (errno == EFAULT), "writing from NULL did not return EFAULT, ret=%zd\n", ret);
> +	}
> +
>  	igt_fixture {
>  		free(buf);
>  		memset(map, 0, fix_info.smem_len); // don't leave garbage on the screen
> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
> index 0423de80..71bbd173 100644
> --- a/tests/intel-ci/fast-feedback.testlist
> +++ b/tests/intel-ci/fast-feedback.testlist
> @@ -4,6 +4,7 @@ igt@core_auth@basic-auth
>  igt@debugfs_test@read_all_entries
>  igt@fbdev@eof
>  igt@fbdev@info
> +igt@fbdev@nullptr
>  igt@fbdev@read
>  igt@fbdev@unaligned-read
>  igt@fbdev@unaligned-write
> -- 
> 2.29.2
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev