From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C57CEC63697 for ; Thu, 19 Nov 2020 16:44:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E13F2222A for ; Thu, 19 Nov 2020 16:44:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="k4TottIk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728836AbgKSQoV (ORCPT ); Thu, 19 Nov 2020 11:44:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:54488 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727853AbgKSQoV (ORCPT ); Thu, 19 Nov 2020 11:44:21 -0500 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 084F222227; Thu, 19 Nov 2020 16:44:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605804260; bh=X0dkfAQ/RZZ0vc2DWgesSKsb7UCpnk9G0pl0RaG4zEU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k4TottIk5krhLkqXtTph8vd7A6u5ljjlWbxWAjXe7Z6sXYTNYXXzCMAmXoSwHW9xt lp2lRVO+8F83dkUQ6edvDpjIdmhyWiyoHgylpmZr4ZHEDl5k1b+7IYCN9lKCYwG1NV hzMVdWYRKIw5zsRHRpKcB7LT73Rf0cTKUh84Cf4s= Date: Thu, 19 Nov 2020 16:44:13 +0000 From: Will Deacon To: Quentin Perret Cc: linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin Marinas , Marc Zyngier , Greg Kroah-Hartman , Peter Zijlstra , Morten Rasmussen , Qais Yousef , Suren Baghdasaryan , Tejun Heo , Li Zefan , Johannes Weiner , Ingo Molnar , Juri Lelli , Vincent Guittot , kernel-team@android.com Subject: Re: [PATCH v3 11/14] sched: Reject CPU affinity changes based on arch_cpu_allowed_mask() Message-ID: <20201119164412.GE4582@willie-the-truck> References: <20201113093720.21106-1-will@kernel.org> <20201113093720.21106-12-will@kernel.org> <20201119094744.GE2416649@google.com> <20201119110723.GE3946@willie-the-truck> <20201119143012.GA2458028@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201119143012.GA2458028@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 19, 2020 at 02:30:12PM +0000, Quentin Perret wrote: > On Thursday 19 Nov 2020 at 11:07:24 (+0000), Will Deacon wrote: > > Yeah, the cpuset code ignores the return value of set_cpus_allowed_ptr() in > > update_tasks_cpumask() so the failure won't be propagated, but then again I > > think that might be the right thing to do. Nothing prevents 32-bit and > > 64-bit tasks from co-existing in the same cpuseti afaict, so forcing the > > 64-bit tasks onto the 32-bit-capable cores feels much worse than the > > approach taken here imo. > > Ack. And thinking about it more, failing the cgroup operation wouldn't > guarantee that the task's affinity and the cpuset are aligned anyway. We > could still exec into a 32 bit task from within a 64 bit-only cpuset. > > > The interesting case is what happens if the cpuset for a 32-bit task is > > changed to contain only the 64-bit-only cores. I think that's a userspace > > bug > > Maybe, but I think Android will do exactly that in some cases :/ > > > but the fallback rq selection should avert disaster. > > I thought _this_ patch was 'fixing' this case by making the cpuset > operation pretty much a nop on the task affinity? The fallback rq stuff > is all about hotplug no? Yeah, sorry, I wasn't clear. This patch postpones disaster until hotplug off time, when cpuset_cpus_allowed_fallback() will fail and select_fallback_rq() will have to step in. Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EA81C6369E for ; Thu, 19 Nov 2020 16:45:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B1BA12222A for ; Thu, 19 Nov 2020 16:45:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Yrii+Gws"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="k4TottIk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1BA12222A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SG91W4Lb94wjtjE9OucEuogzyedy4ugOS5mZQom7ynU=; b=Yrii+GwsJ0YE4ONPdtVopr9Ff mFBuAc/ldVucnuAhQ+vZ1fAFZeV4nFbGDd+fXFvhFSgwFlYCyB6inSiPNvVea3cKPDb/Zl1xV5DzW 8A5Er/iGCl8bWFX2HEpqlqKQ9IphStC5PaMFPUd/EECtU1t/iV34Hc/5r1+wXD/+F5WUIBz45JkEh qrc9X9OUVVl3Xu0YWC5V58A/7VZvvmzdpUn3HFpFzBN391CbOlcD9+ADh6QBess5cpE0NWggEHN12 h4pyTCqV6Ka8tuccAYZ6rcZfgzjcBsXcNU4qHDXXug9kg+22lEQQKyfWXwz+Qn8JJtnkx7eoubiNr 4WiFLHKfg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfn2p-0000W5-Dg; Thu, 19 Nov 2020 16:44:27 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfn2j-0000Uf-J5 for linux-arm-kernel@lists.infradead.org; Thu, 19 Nov 2020 16:44:23 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 084F222227; Thu, 19 Nov 2020 16:44:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605804260; bh=X0dkfAQ/RZZ0vc2DWgesSKsb7UCpnk9G0pl0RaG4zEU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k4TottIk5krhLkqXtTph8vd7A6u5ljjlWbxWAjXe7Z6sXYTNYXXzCMAmXoSwHW9xt lp2lRVO+8F83dkUQ6edvDpjIdmhyWiyoHgylpmZr4ZHEDl5k1b+7IYCN9lKCYwG1NV hzMVdWYRKIw5zsRHRpKcB7LT73Rf0cTKUh84Cf4s= Date: Thu, 19 Nov 2020 16:44:13 +0000 From: Will Deacon To: Quentin Perret Subject: Re: [PATCH v3 11/14] sched: Reject CPU affinity changes based on arch_cpu_allowed_mask() Message-ID: <20201119164412.GE4582@willie-the-truck> References: <20201113093720.21106-1-will@kernel.org> <20201113093720.21106-12-will@kernel.org> <20201119094744.GE2416649@google.com> <20201119110723.GE3946@willie-the-truck> <20201119143012.GA2458028@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201119143012.GA2458028@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201119_114421_913854_F40C295B X-CRM114-Status: GOOD ( 21.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Marc Zyngier , kernel-team@android.com, Vincent Guittot , Juri Lelli , Ingo Molnar , Peter Zijlstra , Catalin Marinas , Johannes Weiner , linux-kernel@vger.kernel.org, Qais Yousef , Li Zefan , Greg Kroah-Hartman , Tejun Heo , Suren Baghdasaryan , Morten Rasmussen , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 19, 2020 at 02:30:12PM +0000, Quentin Perret wrote: > On Thursday 19 Nov 2020 at 11:07:24 (+0000), Will Deacon wrote: > > Yeah, the cpuset code ignores the return value of set_cpus_allowed_ptr() in > > update_tasks_cpumask() so the failure won't be propagated, but then again I > > think that might be the right thing to do. Nothing prevents 32-bit and > > 64-bit tasks from co-existing in the same cpuseti afaict, so forcing the > > 64-bit tasks onto the 32-bit-capable cores feels much worse than the > > approach taken here imo. > > Ack. And thinking about it more, failing the cgroup operation wouldn't > guarantee that the task's affinity and the cpuset are aligned anyway. We > could still exec into a 32 bit task from within a 64 bit-only cpuset. > > > The interesting case is what happens if the cpuset for a 32-bit task is > > changed to contain only the 64-bit-only cores. I think that's a userspace > > bug > > Maybe, but I think Android will do exactly that in some cases :/ > > > but the fallback rq selection should avert disaster. > > I thought _this_ patch was 'fixing' this case by making the cpuset > operation pretty much a nop on the task affinity? The fallback rq stuff > is all about hotplug no? Yeah, sorry, I wasn't clear. This patch postpones disaster until hotplug off time, when cpuset_cpus_allowed_fallback() will fail and select_fallback_rq() will have to step in. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel