All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Tom Seewald <tseewald@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] cxbgb4: Fix build failure when CHELSIO_TLS_DEVICE=n
Date: Fri, 20 Nov 2020 07:35:02 -0800	[thread overview]
Message-ID: <20201120073502.4beeb482@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <CAARYdbivN7N-xwqvgq7pdyeY9UOBL=aGr97AHMsMP1TvR-3Qog@mail.gmail.com>

On Fri, 20 Nov 2020 00:54:00 -0600 Tom Seewald wrote:
> > Seems to me that CHELSIO_T4 should depend on (TLS || TLS=n), the
> > CONFIG_CHELSIO_TLS_DEVICE has the dependency but AFAICT nothing prevents
> > CONFIG_CHELSIO_TLS_DEVICE=m and CHELSIO_T4=y and cxgb4_main.c is under
> > the latter.  
> 
> You are right, adding (TLS || TLS=n) for CHELSIO_T4 resolves the build
> error I am encountering.

Great, please submit a patch.

  reply	other threads:[~2020-11-20 15:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-16  2:31 [PATCH] cxbgb4: Fix build failure when CHELSIO_TLS_DEVICE=n Tom Seewald
2020-11-17 22:25 ` Jakub Kicinski
2020-11-19  5:40   ` Tom Seewald
2020-11-19 17:37     ` Jakub Kicinski
2020-11-20  6:54       ` Tom Seewald
2020-11-20 15:35         ` Jakub Kicinski [this message]
2020-11-20 19:25           ` [PATCH] cxgb4: Fix build failure when CONFIG_TLS=m Tom Seewald
2020-11-21 21:12             ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201120073502.4beeb482@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=tseewald@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.