From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A95DC2D0E4 for ; Fri, 20 Nov 2020 21:12:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D835F22253 for ; Fri, 20 Nov 2020 21:12:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="pJGYauTh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727728AbgKTVMb (ORCPT ); Fri, 20 Nov 2020 16:12:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:46678 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727170AbgKTVMa (ORCPT ); Fri, 20 Nov 2020 16:12:30 -0500 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DC1BC2224E; Fri, 20 Nov 2020 21:12:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605906750; bh=IW/0CqYx7CjcxKIxYFcqbCGZrF/sWhZlxknCCzqWq2Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pJGYauThBox6wrZGaIrmijJ4ugNLPpa7pdhpwIjXjU+qhqGGEbgcmcbvg2ondl+si tO9jl22r1+W2Prd3+o6wv0zM424lk33ruoUbpvAP3cPiUZpH+mYf7Gmawk1JyVs3Zu gFtaJOtbEWVVdw+4QRkXI1u1U3RB+Pa0M7Vwil8w= Date: Fri, 20 Nov 2020 13:12:28 -0800 From: Jakub Kicinski To: Eelco Chaudron Cc: netdev@vger.kernel.org, davem@davemloft.net, dev@openvswitch.org, pshelar@ovn.org, bindiyakurle@gmail.com, i.maximets@ovn.org, mcroce@linux.microsoft.com Subject: Re: [PATCH net] net: openvswitch: fix TTL decrement action netlink message format Message-ID: <20201120131228.489c3b52@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <160577663600.7755.4779460826621858224.stgit@wsfd-netdev64.ntdv.lab.eng.bos.redhat.com> References: <160577663600.7755.4779460826621858224.stgit@wsfd-netdev64.ntdv.lab.eng.bos.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 19 Nov 2020 04:04:04 -0500 Eelco Chaudron wrote: > Currently, the openvswitch module is not accepting the correctly formated > netlink message for the TTL decrement action. For both setting and getting > the dec_ttl action, the actions should be nested in the > OVS_DEC_TTL_ATTR_ACTION attribute as mentioned in the openvswitch.h uapi. IOW this change will not break any known user space, correct? But existing OvS user space already expects it to work like you make it work now? What's the harm in leaving it as is? > Fixes: 744676e77720 ("openvswitch: add TTL decrement action") > Signed-off-by: Eelco Chaudron Can we get a review from OvS folks? Matteo looks good to you (as the original author)? > - err = __ovs_nla_copy_actions(net, attr, key, sfa, eth_type, > + err = __ovs_nla_copy_actions(net, actions, key, sfa, eth_type, > vlan_tci, mpls_label_count, log); > if (err) > return err; You're not canceling any nests on error, I assume this is normal. > + add_nested_action_end(*sfa, action_start); > add_nested_action_end(*sfa, start); > return 0; > }