From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3636FC63798 for ; Fri, 20 Nov 2020 13:34:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D3EDC222C3 for ; Fri, 20 Nov 2020 13:34:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tuBii7JJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728399AbgKTNeH (ORCPT ); Fri, 20 Nov 2020 08:34:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728104AbgKTNeG (ORCPT ); Fri, 20 Nov 2020 08:34:06 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1C4AC0613CF for ; Fri, 20 Nov 2020 05:34:05 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id l1so10020525wrb.9 for ; Fri, 20 Nov 2020 05:34:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0DnufIVx5k+ikoA08x3/TY3NmZ4fqJGmV9/jnWsQi+Q=; b=tuBii7JJ9llmFjqxkhQh9JT06URno1cMKMbuUGj6d6hY1jJ1vXBCjORiW7l49jWqQS q7Gbf70245JD02MYPFcCMEVxazJ+IQbH8TZXr3oD/53dTpNwHNz+NjrkyemBYNRIMwBn 4FOlfaYamciW6SDmc/HaXZZq5uhZyKJ92LfaOoX+CViW1xiUPo4j9fMtGQxIohsuVMeq CYspkdRvnEy1NM1M4J2feOGVfLOzhvsRYH6Ec9nXYvSHQr+CQ6DPgVKUlDKmibQljFUo KMNf40oSZs3e7icn9EZzCyovdpV7RlUk58tNEpcMge4CsXhazPdMNbBzBnaGN2lRKaHq wZLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=0DnufIVx5k+ikoA08x3/TY3NmZ4fqJGmV9/jnWsQi+Q=; b=bMo5IHW4Vr6tB85Nsuz1zSch8dhOfO2QCmvmz/KFh6kf9EAA4nsZz6jRNo2ATEw3xy gaj+h0Co+rzWNoDEVWtpCKKECCyoQ+IUex/KENe3mO6QLolWE7O0ljafhvOC23Vxeuz9 m6lfaKlP1kes7NiANGcKzplXJsmxB1HiJvWEroWdujX50nPN6z0+hohDQ31ZqVWHp664 jD5pcv0DZ3GFzug0GiT3GlgvUWgG+GtOA7m/zzumGlnd9Zj7fniodrFP3NOsS6EV8brS cCDlviqci8/gFOO3y3142VJr1BRWLYut/AZ5Ni1c/qU2C1kJT3F75XeXKkDBnWeUCfP0 thDw== X-Gm-Message-State: AOAM532Agx+BMRHZ65WzzNNz17bQzC/yq8/040xN5bxie9uTQSkxQLBz StC6mWCQ6hD4iZ8MFhgcygM= X-Google-Smtp-Source: ABdhPJz/NZ0LG3uk3iDJftKMcB3386fuGyk45ubTHbxhwqN+k4nxrlf4bzU5TXNQbpo35io6sxappQ== X-Received: by 2002:adf:f2ce:: with SMTP id d14mr15691029wrp.94.1605879244592; Fri, 20 Nov 2020 05:34:04 -0800 (PST) Received: from eldamar (80-218-24-251.dclient.hispeed.ch. [80.218.24.251]) by smtp.gmail.com with ESMTPSA id g138sm4216048wme.39.2020.11.20.05.34.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Nov 2020 05:34:02 -0800 (PST) Sender: Salvatore Bonaccorso Date: Fri, 20 Nov 2020 14:34:00 +0100 From: Salvatore Bonaccorso To: Andrey Zhizhikin Cc: stable@vger.kernel.org, Leo Yan , Alexander Shishkin , Jiri Olsa , Mark Rutland , Namhyung Kim , Peter Zijlstra , Suzuki Poulouse , Tor Jeremiassen , linux-arm-kernel@lists.infradead.org, Arnaldo Carvalho de Melo , Guenter Roeck , Greg Kroah-Hartman Subject: Re: [PATCH] Revert "perf cs-etm: Move definition of 'traceid_list' global variable from header file" Message-ID: <20201120133400.GA405401@eldamar.lan> References: <20201120073909.357536-1-carnil@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Andrey, On Fri, Nov 20, 2020 at 10:54:22AM +0100, Andrey Zhizhikin wrote: > On Fri, Nov 20, 2020 at 8:39 AM Salvatore Bonaccorso wrote: > > > > This reverts commit 168200b6d6ea0cb5765943ec5da5b8149701f36a upstream. > > (but only from 4.19.y) > > This revert would fail the build of 4.19.y with gcc10, I believe the > original commit was introduced to address exactly this case. If this > is intended behavior that 4.19.y is not compiled with newer gcc > versions - then this revert is OK. TTBOMK, this would not regress the build for newer gcc (specifically gcc10) as 4.19.158 is failing perf tool builds there as well (without the above commit reverted). Just as an example v4.19.y does not have cff20b3151cc ("perf tests bp_account: Make global variable static") which is there in v5.6-rc6 to fix build failures with 10.0.1. But it did regress builds with older gcc's as for instance used in Debian buster (gcc 8.3.0) since 4.19.152. Do I possibly miss something? If there is a solution to make it build with newer GCCs and *not* regress previously working GCC versions then this is surely the best outcome though. Regards, Salvatore From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66845C5519F for ; Fri, 20 Nov 2020 13:34:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1E4622272 for ; Fri, 20 Nov 2020 13:34:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Xx27HJqd"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tuBii7JJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1E4622272 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+TbRqz3N5N3xG8J7MHvcrdIbkf6G1SaQSkD3iHo3340=; b=Xx27HJqdeu4pIwK5w0+ysRqkc K1l+vrYwuPz2hCnCi2VjeVdnVeakbsZsb3nLWQJsTESpXizZPc1fAKrPlWIxae5DOr5D4j4bzOP81 v+agaug2OYwe1TbUub64Cr+2wuAHFVgkNUO+uWptT07u2io2wYYqX2XKtLFpmcQu7eNMajT+DjZrp x2b4CmKNHs3fLxDzsvxTgfIxzj/SkY6g2BtXUAJEg5pNJIOrKqpfaUKF5UXFdaWax1g11TU0AsJvq ehwgDBvtt4gC4RejyVvJdh19aC54gAvIybPCEA3mNKkabiC+FIXbNtVzh8uifhhHpQtQfSRX1S9/4 YQm1I9h+A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kg6YC-0003pd-7I; Fri, 20 Nov 2020 13:34:08 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kg6Y9-0003on-KJ for linux-arm-kernel@lists.infradead.org; Fri, 20 Nov 2020 13:34:06 +0000 Received: by mail-wr1-x442.google.com with SMTP id s8so10017844wrw.10 for ; Fri, 20 Nov 2020 05:34:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0DnufIVx5k+ikoA08x3/TY3NmZ4fqJGmV9/jnWsQi+Q=; b=tuBii7JJ9llmFjqxkhQh9JT06URno1cMKMbuUGj6d6hY1jJ1vXBCjORiW7l49jWqQS q7Gbf70245JD02MYPFcCMEVxazJ+IQbH8TZXr3oD/53dTpNwHNz+NjrkyemBYNRIMwBn 4FOlfaYamciW6SDmc/HaXZZq5uhZyKJ92LfaOoX+CViW1xiUPo4j9fMtGQxIohsuVMeq CYspkdRvnEy1NM1M4J2feOGVfLOzhvsRYH6Ec9nXYvSHQr+CQ6DPgVKUlDKmibQljFUo KMNf40oSZs3e7icn9EZzCyovdpV7RlUk58tNEpcMge4CsXhazPdMNbBzBnaGN2lRKaHq wZLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=0DnufIVx5k+ikoA08x3/TY3NmZ4fqJGmV9/jnWsQi+Q=; b=I7lzfQYEJ4K0IIfr0bM6xKHN6aOUI1nioiYaVfPxLfaW+5ZvfHe439xRind5R6LtIf DUp7Sg3F2Z7bunTNif0L9iLRu/69AGPqIrE3ZkePJdE7a4y6gcrggMnDxSi0vufrkO2j mJhFattK/FFhpYulP4hpAvwJQMCwcCNbkIZwF7UrlRbLIkOEdo87IxdIgHSsaVe+lq2X q6pM0RWibuBFulFeqHNnkKNcZx3RqouU00YLOk8ibntY08unb0ty88lZ8JYnSA6iYUmf T9G6ji6cFD/7IPoHv0sTj64z8RDmpWGPi7yit7cn8i41DpiU1rYzvl8GIfnGJGQCPasw EOOg== X-Gm-Message-State: AOAM533DhdjpIvkqCWgnjCJxcDaTF+ZGTPTjrWZLirCtCjZhdwqk1BDk dHcVbBzTdsQgUr+cWvHVG44= X-Google-Smtp-Source: ABdhPJz/NZ0LG3uk3iDJftKMcB3386fuGyk45ubTHbxhwqN+k4nxrlf4bzU5TXNQbpo35io6sxappQ== X-Received: by 2002:adf:f2ce:: with SMTP id d14mr15691029wrp.94.1605879244592; Fri, 20 Nov 2020 05:34:04 -0800 (PST) Received: from eldamar (80-218-24-251.dclient.hispeed.ch. [80.218.24.251]) by smtp.gmail.com with ESMTPSA id g138sm4216048wme.39.2020.11.20.05.34.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Nov 2020 05:34:02 -0800 (PST) Date: Fri, 20 Nov 2020 14:34:00 +0100 From: Salvatore Bonaccorso To: Andrey Zhizhikin Subject: Re: [PATCH] Revert "perf cs-etm: Move definition of 'traceid_list' global variable from header file" Message-ID: <20201120133400.GA405401@eldamar.lan> References: <20201120073909.357536-1-carnil@debian.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201120_083405_734123_2F3A3FDB X-CRM114-Status: GOOD ( 15.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Suzuki Poulouse , Alexander Shishkin , Greg Kroah-Hartman , stable@vger.kernel.org, Tor Jeremiassen , Arnaldo Carvalho de Melo , Peter Zijlstra , Guenter Roeck , Leo Yan , Namhyung Kim , Jiri Olsa , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrey, On Fri, Nov 20, 2020 at 10:54:22AM +0100, Andrey Zhizhikin wrote: > On Fri, Nov 20, 2020 at 8:39 AM Salvatore Bonaccorso wrote: > > > > This reverts commit 168200b6d6ea0cb5765943ec5da5b8149701f36a upstream. > > (but only from 4.19.y) > > This revert would fail the build of 4.19.y with gcc10, I believe the > original commit was introduced to address exactly this case. If this > is intended behavior that 4.19.y is not compiled with newer gcc > versions - then this revert is OK. TTBOMK, this would not regress the build for newer gcc (specifically gcc10) as 4.19.158 is failing perf tool builds there as well (without the above commit reverted). Just as an example v4.19.y does not have cff20b3151cc ("perf tests bp_account: Make global variable static") which is there in v5.6-rc6 to fix build failures with 10.0.1. But it did regress builds with older gcc's as for instance used in Debian buster (gcc 8.3.0) since 4.19.152. Do I possibly miss something? If there is a solution to make it build with newer GCCs and *not* regress previously working GCC versions then this is surely the best outcome though. Regards, Salvatore _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel