From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77458C63798 for ; Fri, 20 Nov 2020 18:34:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1CAAF24137 for ; Fri, 20 Nov 2020 18:34:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=fossekall.de header.i=@fossekall.de header.b="dwT135xF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730820AbgKTSdv (ORCPT ); Fri, 20 Nov 2020 13:33:51 -0500 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.54]:16462 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730557AbgKTSdu (ORCPT ); Fri, 20 Nov 2020 13:33:50 -0500 X-Greylist: delayed 364 seconds by postgrey-1.27 at vger.kernel.org; Fri, 20 Nov 2020 13:33:48 EST DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1605897227; s=strato-dkim-0002; d=fossekall.de; h=In-Reply-To:References:Message-ID:Subject:Cc:To:From:Date: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=xudo2I6VKOadttIlQPFdDdwbEKk8bWqHc6a0qA4f9L0=; b=dwT135xFlanjpCBsjTQAXCGyX2fyPwRBZXQQzJqGUh52wc7awX0GN94kQQ3TyplUN6 d7wBL20a/SkgBE5bUPBQOckskY3N883LQ+oRfUiaDZjCqKHi5ce5iGik4/HB1fDKgWkz nUB5DI127lrJISwVdn7+6wkqV3HWfsu8boW8icvfYvVh9A5plt4KCacw7113bDwM5fHJ EDNL0R3IyuocggbbiY0KCV+CzkCWL02+dhQPeXB7yUlzox8z8fdtNY2PGE98RTID/xyG hhOuxgl9ztyCKUPZVUiRO3r1xRczPNh/q3+yyPJ3I5cn3wce7ModUkbLjsgp7sbNI3ll N5eQ== X-RZG-AUTH: ":O2kGeEG7b/pS1EzgE2y7nF0STYsSLflpbjNKxx7cGrBOdI6BL9pkS3QW19mO7I+/JwRspuzJFZuRzQ==" X-RZG-CLASS-ID: mo00 Received: from aerfugl by smtp.strato.de (RZmta 47.3.4 AUTH) with ESMTPSA id g02087wAKIRftpy (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Fri, 20 Nov 2020 19:27:41 +0100 (CET) Received: from koltrast.a98shuttle.de ([192.168.1.27] helo=a98shuttle.de) by aerfugl with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1kgB8G-0001sg-EU; Fri, 20 Nov 2020 19:27:40 +0100 Date: Fri, 20 Nov 2020 19:27:39 +0100 From: Michael Klein To: Maxime Ripard Cc: Rob Herring , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: sun8i-h2-plus-bananapi-m2-zero: add gpio-line-names Message-ID: <20201120182739.GA3734181@a98shuttle.de> References: <20201115222425.2885427-1-michael@fossekall.de> <20201120155252.kfkavrn4wpqzmbyc@gilmour> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20201120155252.kfkavrn4wpqzmbyc@gilmour> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thank you for having a look at the patch! On Fri, Nov 20, 2020 at 04:52:52PM +0100, Maxime Ripard wrote: >On Sun, Nov 15, 2020 at 11:24:25PM +0100, Michael Klein wrote: >> Add gpio-line-names as documented in the Banana Pi wiki [1] and in the >> schematics [2]. >> >> [1]: http://wiki.banana-pi.org/Banana_Pi_BPI-M2_ZERO#GPIO_PIN_define >> [2]: https://drive.google.com/file/d/0B4PAo2nW2KfnMW5sVkxWSW9qa28/view >> >> Signed-off-by: Michael Klein >> --- >> .../dts/sun8i-h2-plus-bananapi-m2-zero.dts | 64 +++++++++++++++++++ >> 1 file changed, 64 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts >> index 4c6704e4c57e..b4ddfaf01b45 100644 >> --- a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts >> +++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts >> @@ -136,6 +136,70 @@ bluetooth { >> >> }; >> >> +&pio { >> + gpio-line-names = >> + /* PA */ >> + "UART2-TX", "UART2-RX", "UART2-RTS", "UART2-CTS", >> + "UART0-TXD", "UART0-RXD", "PWM1", "PA7-EINT7", >> + "PA8-EINT8", "PA9-EINT9", "PA10-EINT10", "TWI0-SCK", >> + "TWI0-SDA", "UART3-TX", "UART3-RX", "UART3-RTS", >> + "UART3-CTS", "PA17-EINT17", "TWI1-SCK", "TWI1-SDA", >> + "PA20-EINT20", "PA21-EINT21", "", "", >> + "", "", "", "", "", "", "", "", > >IIRC, the point is to have the pin names that the vendor publishes. > >Looking at Documentation/devicetree/bindings/gpio/gpio.txt, it says: > >""" >Optionally, a GPIO controller may have a "gpio-line-names" property. This is >an array of strings defining the names of the GPIO lines going out of the >GPIO controller. This name should be the most meaningful producer name >for the system, such as a rail name indicating the usage. Package names >such as pin name are discouraged: such lines have opaque names (since they >are by definition generic purpose) and such names are usually not very >helpful. >""" > >In this case, from the link you gave above, I think having the CON*-P* >names make more sense. Hm, but these are the pin names (of the connector) and should thus not be used, right? For e.g. the PA0 pin, the wiki link gives three candidates: - CON2-P13 (GPIO Pin Name -> pin 13 of the 40 pin GPIO header) - UART2-TX (Default Function) - PA0-EINT0 (Function2 : GPIO) IMHO, the CON*-P* name is the least helpful of the above, as it tells nothing about the usage. I'm not sure about the other two names, though. Michael From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53E21C63777 for ; Fri, 20 Nov 2020 18:28:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9A9522464 for ; Fri, 20 Nov 2020 18:28:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aKdaIhvI"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=fossekall.de header.i=@fossekall.de header.b="D9VKQLkH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9A9522464 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fossekall.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4rJoXM54OvlEbmRD9W+PhUXHjFRCvWlX3NXN+GLBwxk=; b=aKdaIhvIeu+/fBhngvc77fbax wXzLrQHIe59gyBXgRMOssQKYijU2GAD5GqYDk0PhO4WkFYqrWR1kbEAZa9esLem686U03pnRnjzP5 4KotmKnC5h6ngeTZlD38xU8hQ9Hu408igXaUHRc2B8altkz7ezR1ANhH0TPXRSHHR+6H7QQ623/F/ u5Yt/u9DwR95sUQubIHJB7Pt1ZhogyqZmlTZKQ68W6UCSuSuG2fuArHGnZi1dMAlA/ffRjSUizrGC 4uQSLzeRcKM6V19PsOLuqzQYqTdu1zeoQ6SO2rxHRJ/2BVkaErnlfd0KAuRstb9pBYoOJOjLEleZH uEJYzbHjw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kgB8Q-0000ut-98; Fri, 20 Nov 2020 18:27:50 +0000 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.52]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kgB8N-0000tu-NV for linux-arm-kernel@lists.infradead.org; Fri, 20 Nov 2020 18:27:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1605896864; s=strato-dkim-0002; d=fossekall.de; h=In-Reply-To:References:Message-ID:Subject:Cc:To:From:Date: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=xudo2I6VKOadttIlQPFdDdwbEKk8bWqHc6a0qA4f9L0=; b=D9VKQLkHP0YBybgKnpOH5QA7Xo+Du8xINbEHK5bLjTKMqbMwc5pOAer2dAK0OZBXJh UeqIhcSlXEHvwbN7qx2xwzjvqLde7QQly7coCjJYl6mTvW1uTkCkzyjJxNczZZzThfk7 4/doKq17JzB/hbxVQvIjsx28S/6uAccnLf/wO1AI0KuuFygQ4AbCNejnMNL8U87/rKQb TjTBEyksAUpdxn/EDeqkkvJEmt5PZDx0ts5OxiaFXx/QPMGFjdB3Pi6EVtnz7BaA78Th IByQRY/pmHtTqpX1O59r5C67C8cSy8HXJktFTnKNVqcL8Y4yr3Jr10KxfM/OqJFOwdBC loBg== X-RZG-AUTH: ":O2kGeEG7b/pS1EzgE2y7nF0STYsSLflpbjNKxx7cGrBOdI6BL9pkS3QW19mO7I+/JwRspuzJFZuRzQ==" X-RZG-CLASS-ID: mo00 Received: from aerfugl by smtp.strato.de (RZmta 47.3.4 AUTH) with ESMTPSA id g02087wAKIRftpy (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Fri, 20 Nov 2020 19:27:41 +0100 (CET) Received: from koltrast.a98shuttle.de ([192.168.1.27] helo=a98shuttle.de) by aerfugl with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1kgB8G-0001sg-EU; Fri, 20 Nov 2020 19:27:40 +0100 Date: Fri, 20 Nov 2020 19:27:39 +0100 From: Michael Klein To: Maxime Ripard Subject: Re: [PATCH] ARM: dts: sun8i-h2-plus-bananapi-m2-zero: add gpio-line-names Message-ID: <20201120182739.GA3734181@a98shuttle.de> References: <20201115222425.2885427-1-michael@fossekall.de> <20201120155252.kfkavrn4wpqzmbyc@gilmour> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201120155252.kfkavrn4wpqzmbyc@gilmour> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201120_132747_996368_7F78E20A X-CRM114-Status: GOOD ( 18.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Chen-Yu Tsai , Rob Herring , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thank you for having a look at the patch! On Fri, Nov 20, 2020 at 04:52:52PM +0100, Maxime Ripard wrote: >On Sun, Nov 15, 2020 at 11:24:25PM +0100, Michael Klein wrote: >> Add gpio-line-names as documented in the Banana Pi wiki [1] and in the >> schematics [2]. >> >> [1]: http://wiki.banana-pi.org/Banana_Pi_BPI-M2_ZERO#GPIO_PIN_define >> [2]: https://drive.google.com/file/d/0B4PAo2nW2KfnMW5sVkxWSW9qa28/view >> >> Signed-off-by: Michael Klein >> --- >> .../dts/sun8i-h2-plus-bananapi-m2-zero.dts | 64 +++++++++++++++++++ >> 1 file changed, 64 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts >> index 4c6704e4c57e..b4ddfaf01b45 100644 >> --- a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts >> +++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts >> @@ -136,6 +136,70 @@ bluetooth { >> >> }; >> >> +&pio { >> + gpio-line-names = >> + /* PA */ >> + "UART2-TX", "UART2-RX", "UART2-RTS", "UART2-CTS", >> + "UART0-TXD", "UART0-RXD", "PWM1", "PA7-EINT7", >> + "PA8-EINT8", "PA9-EINT9", "PA10-EINT10", "TWI0-SCK", >> + "TWI0-SDA", "UART3-TX", "UART3-RX", "UART3-RTS", >> + "UART3-CTS", "PA17-EINT17", "TWI1-SCK", "TWI1-SDA", >> + "PA20-EINT20", "PA21-EINT21", "", "", >> + "", "", "", "", "", "", "", "", > >IIRC, the point is to have the pin names that the vendor publishes. > >Looking at Documentation/devicetree/bindings/gpio/gpio.txt, it says: > >""" >Optionally, a GPIO controller may have a "gpio-line-names" property. This is >an array of strings defining the names of the GPIO lines going out of the >GPIO controller. This name should be the most meaningful producer name >for the system, such as a rail name indicating the usage. Package names >such as pin name are discouraged: such lines have opaque names (since they >are by definition generic purpose) and such names are usually not very >helpful. >""" > >In this case, from the link you gave above, I think having the CON*-P* >names make more sense. Hm, but these are the pin names (of the connector) and should thus not be used, right? For e.g. the PA0 pin, the wiki link gives three candidates: - CON2-P13 (GPIO Pin Name -> pin 13 of the 40 pin GPIO header) - UART2-TX (Default Function) - PA0-EINT0 (Function2 : GPIO) IMHO, the CON*-P* name is the least helpful of the above, as it tells nothing about the usage. I'm not sure about the other two names, though. Michael _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel