From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D3A3C56202 for ; Sat, 21 Nov 2020 00:58:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B91BD2408E for ; Sat, 21 Nov 2020 00:58:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="c79DgVHR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728084AbgKUA6L (ORCPT ); Fri, 20 Nov 2020 19:58:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:37242 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727163AbgKUA6L (ORCPT ); Fri, 20 Nov 2020 19:58:11 -0500 Received: from paulmck-ThinkPad-P72.home (50-39-104-11.bvtn.or.frontiernet.net [50.39.104.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 39D2523A65; Sat, 21 Nov 2020 00:58:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605920290; bh=pa7X5LSCIRGbHalxNdy/uOANYLTxDAJNOOjXtkJXTyA=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=c79DgVHRz/6UGcT2Cd/MgUZEkJJ+5bpglJSWGj2NBT7g7VVAmIPQMxxUclBR6gjxd CruQ7eceZKVRt26Fj6w6pl5Kgf8fB53Wrazqoa0Qvpwl+VUJaBWhMdZWTnTZ0M5knV M0ROekPqOl0+luJ3Nm8+A2yecRSX9Sm2iECsSwKM= Received: by paulmck-ThinkPad-P72.home (Postfix, from userid 1000) id DA89D3522A6E; Fri, 20 Nov 2020 16:58:09 -0800 (PST) Date: Fri, 20 Nov 2020 16:58:09 -0800 From: "Paul E. McKenney" To: rcu@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com, mingo@kernel.org, jiangshanlai@gmail.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com, joel@joelfernandes.org Subject: Re: [PATCH tip/core/rcu 0/5] Provide SRCU polling grace-period interfaces Message-ID: <20201121005809.GA16795@paulmck-ThinkPad-P72> Reply-To: paulmck@kernel.org References: <20201117004017.GA7444@paulmck-ThinkPad-P72> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201117004017.GA7444@paulmck-ThinkPad-P72> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! This is V2 of the series provides a polling interface for SRCU grace periods. The API is still as follows: unsigned long start_poll_synchronize_srcu(struct srcu_struct *ssp) Returns a "cookie" that can be thought of as a snapshot of the specified SRCU instance's grace-period sequence number. Also ensures that enough future grace periods happen to eventually make the grace-period sequence number reach the cookie. bool poll_state_synchronize_srcu(struct srcu_struct *ssp, unsigned long cookie) Given a cookie from start_poll_synchronize_srcu(), returns true if at least one full SRCU grace period has elapsed in the meantime. Given finite SRCU readers in a well-behaved kernel, the following code will complete in finite time: cookie = start_poll_synchronize_srcu(&my_srcu); while (!poll_state_synchronize_srcu(&my_srcu, cookie)) schedule_timeout_uninterruptible(1); unsigned long get_state_synchronize_srcu(struct srcu_struct *ssp) Like start_poll_synchronize_srcu(), except that it does not start any grace periods. This means that the following code is -not- guaranteed to complete: cookie = get_state_synchronize_srcu(&my_srcu); while (!poll_state_synchronize_srcu(&my_srcu, cookie)) schedule_timeout_uninterruptible(1); Use this if you know that something else will be starting the needed SRCU grace periods. This might also be useful if you had items that were likely to be reused before the SRCU grace period elapsed, so that you avoid burning CPU on SRCU grace periods that prove to be unnecessary. Or if you don't want to have more than (say) 100 SRCU grace periods per seconds, in which case you might use a timer to start the grace periods. Or maybe you don't bother starting the SRCU grace period until some sort of emergency situation has arisen. Or... OK, maybe no one needs it, but rcutorture does need it, so here it is anyway. The patches in this version of the series are as follows: 1. Make Tiny SRCU use multi-bit grace-period counter. 2. Provide internal interface to start a Tiny SRCU grace period. 3. Provide internal interface to start a Tree SRCU grace period. 4. Provide polling interfaces for Tiny SRCU grace periods. 5. Provide polling interfaces for Tree SRCU grace periods. 6. Document polling interfaces for Tree SRCU grace periods. Changes from v1: o Added EXPORT_SYMBOL_GPL() to allow rcutorture testing when rcutorture is built as a module. o Applied review feedback from Neeraj Upadhyay. o Updated RCU requirements documentation. Thanx, Paul ------------------------------------------------------------------------ Documentation/RCU/Design/Requirements/Requirements.rst | 18 ++ include/linux/rcupdate.h | 2 include/linux/srcu.h | 3 include/linux/srcutiny.h | 5 kernel/rcu/srcutiny.c | 76 ++++++++- kernel/rcu/srcutree.c | 133 ++++++++++++----- 6 files changed, 191 insertions(+), 46 deletions(-)