From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 16BC4C388F9
	for <netdev@archiver.kernel.org>; Sat, 21 Nov 2020 23:40:37 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id C692220A8B
	for <netdev@archiver.kernel.org>; Sat, 21 Nov 2020 23:40:36 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="H6ziNHrA"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726536AbgKUXTy (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Sat, 21 Nov 2020 18:19:54 -0500
Received: from mail.kernel.org ([198.145.29.99]:54870 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726176AbgKUXTx (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sat, 21 Nov 2020 18:19:53 -0500
Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.1])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 55A9921D46;
        Sat, 21 Nov 2020 23:19:53 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1606000793;
        bh=ybs2YhYmDs/f8E56sygvXFyrNxO4LzNuJCKiFRCMPTY=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=H6ziNHrAzFxFhyETUoA6SH+RR+7J/bFF+jv3Ha2H9o4YgVl60jUuvbWd+HhM2og+0
         1L51wThSab4XMB89+1fenT0/QjmKp5nImWcCaRVl5WRNLmKzZ5cSePnDE/2EadDlXT
         UEg9+zifHxiH/tO9NjE3KPMtyDA9nBoymy2L1fXg=
Date:   Sat, 21 Nov 2020 15:19:52 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Jens Axboe <axboe@kernel.dk>
Cc:     Networking <netdev@vger.kernel.org>
Subject: Re: [PATCH] tun: honor IOCB_NOWAIT flag
Message-ID: <20201121151952.6a0d9c46@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <e9451860-96cc-c7c7-47b8-fe42cadd5f4c@kernel.dk>
References: <e9451860-96cc-c7c7-47b8-fe42cadd5f4c@kernel.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Fri, 20 Nov 2020 07:59:54 -0700 Jens Axboe wrote:
> tun only checks the file O_NONBLOCK flag, but it should also be checking
> the iocb IOCB_NOWAIT flag. Any fops using ->read/write_iter() should check
> both, otherwise it breaks users that correctly expect O_NONBLOCK semantics
> if IOCB_NOWAIT is set.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Jens Axboe <axboe@kernel.dk>

Applied, thanks!