From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6CA0C388F9 for ; Sun, 22 Nov 2020 00:59:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E82F2083B for ; Sun, 22 Nov 2020 00:59:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=roeck-us.net header.i=@roeck-us.net header.b="g2jetLwo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726431AbgKVA6q (ORCPT ); Sat, 21 Nov 2020 19:58:46 -0500 Received: from gproxy6-pub.mail.unifiedlayer.com ([67.222.39.168]:53327 "EHLO gproxy6-pub.mail.unifiedlayer.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726398AbgKVA6q (ORCPT ); Sat, 21 Nov 2020 19:58:46 -0500 Received: from cmgw10.unifiedlayer.com (unknown [10.9.0.10]) by gproxy6.mail.unifiedlayer.com (Postfix) with ESMTP id AFAC61E06A1 for ; Sat, 21 Nov 2020 17:58:45 -0700 (MST) Received: from bh-25.webhostbox.net ([208.91.199.152]) by cmsmtp with ESMTP id gdiHkjOcyDlydgdiHkYwhT; Sat, 21 Nov 2020 17:58:45 -0700 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.3 cv=CLQEoyjD c=1 sm=1 tr=0 a=QNED+QcLUkoL9qulTODnwA==:117 a=2cfIYNtKkjgZNaOwnGXpGw==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=8nJEP1OIZ-IA:10:nop_charset_1 a=nNwsprhYR40A:10:nop_rcvd_month_year a=evQFzbml-YQA:10:endurance_base64_authed_username_1 a=iH7RfIX4AAAA:20 a=VwQbUJbxAAAA:8 a=_jlGtV7tAAAA:8 a=45O7cDBGXuf8goJbQyUA:9 a=wPNLvfGTeEIA:10:nop_charset_2 a=AjGcO6oz07-iQ99wixmX:22 a=nlm17XC03S6CtCLSeiRr:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=roeck-us.net; s=default; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=S/pOiXpWjEsaacuWigI3ywSsIkJVWsK1kqJYF6zuk3M=; b=g2jetLwoW4PYEjEn9CpkWgiaPc iCUWhOmPnIUPYyZZo0Iow57mdl8eb6tctDL0pFYDoITownskWcYkYHxqimlup695qieQdi90gTWfw wubhKNygP59vPinwKUQbN/mgpSYu2Uad2WTaszHML3W45Yp5CXn9iu9c+f5iB9AbKC5bI40m3CbJc 0W3L7SYmGVC/LZ4aLt4cM+oTnKLh2TsjvLsZ/Ta7rdfrqbk+TgodsXj/HXpsGNALTuO3wKqQ5mDKL GVAv5K3Z/8eWwPQX9o/dVTG3g9wgoPjLdOwAOtcKfDDpeXF8Kq9Z/6aLQ6isYOSSorizVwWEaqcxB vTwfjMXQ==; Received: from 108-223-40-66.lightspeed.sntcca.sbcglobal.net ([108.223.40.66]:41844 helo=localhost) by bh-25.webhostbox.net with esmtpa (Exim 4.93) (envelope-from ) id 1kgdiG-0018bJ-MI; Sun, 22 Nov 2020 00:58:44 +0000 Date: Sat, 21 Nov 2020 16:58:43 -0800 From: Guenter Roeck To: Joe Perches Cc: "Gustavo A. R. Silva" , Marius Zachmann , Jean Delvare , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 086/141] hwmon: (corsair-cpro) Fix fall-through warnings for Clang Message-ID: <20201122005843.GA120539@roeck-us.net> References: <20201121185010.GB114144@roeck-us.net> <7456d8ffa0e980e52964c539081228dff4627ae3.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7456d8ffa0e980e52964c539081228dff4627ae3.camel@perches.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-BWhitelist: no X-Source-IP: 108.223.40.66 X-Source-L: No X-Exim-ID: 1kgdiG-0018bJ-MI X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 108-223-40-66.lightspeed.sntcca.sbcglobal.net (localhost) [108.223.40.66]:41844 X-Source-Auth: guenter@roeck-us.net X-Email-Count: 3 X-Source-Cap: cm9lY2s7YWN0aXZzdG07YmgtMjUud2ViaG9zdGJveC5uZXQ= X-Local-Domain: yes Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Sat, Nov 21, 2020 at 12:00:30PM -0800, Joe Perches wrote: > On Sat, 2020-11-21 at 10:50 -0800, Guenter Roeck wrote: > > On Fri, Nov 20, 2020 at 12:36:04PM -0600, Gustavo A. R. Silva wrote: > > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > > > by explicitly adding a break statement instead of letting the code fall > > > through to the next case. > > > > > > Link: https://github.com/KSPP/linux/issues/115 > > > Signed-off-by: Gustavo A. R. Silva > > > > Acked-by: Guenter Roeck > [] > > > diff --git a/drivers/hwmon/corsair-cpro.c b/drivers/hwmon/corsair-cpro.c > [] > > > @@ -310,6 +310,7 @@ static int ccp_write(struct device *dev, enum hwmon_sensor_types type, > > >   default: > > >   break; > > >   } > > > + break; > > The > default: > break; > > bit above (but not below as it's a switch on an enum) could also be deleted no? > I prefer to keep it the way it is to indicate that the default case was not forgotten (unless that is against coding style). Guenter > > >   default: > > >   break; > > >   } > > --- > drivers/hwmon/corsair-cpro.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/hwmon/corsair-cpro.c b/drivers/hwmon/corsair-cpro.c > index 591929ec217a..580173fca0f6 100644 > --- a/drivers/hwmon/corsair-cpro.c > +++ b/drivers/hwmon/corsair-cpro.c > @@ -299,17 +299,14 @@ static int ccp_write(struct device *dev, enum hwmon_sensor_types type, > switch (attr) { > case hwmon_pwm_input: > return set_pwm(ccp, channel, val); > - default: > - break; > } > break; > case hwmon_fan: > switch (attr) { > case hwmon_fan_target: > return set_target(ccp, channel, val); > - default: > - break; > } > + break; > default: > break; > } > >