From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EB5AC5519F for ; Sun, 22 Nov 2020 10:59:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E8F2B20936 for ; Sun, 22 Nov 2020 10:59:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727789AbgKVK70 (ORCPT ); Sun, 22 Nov 2020 05:59:26 -0500 Received: from mail-ej1-f68.google.com ([209.85.218.68]:44887 "EHLO mail-ej1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727373AbgKVK7Z (ORCPT ); Sun, 22 Nov 2020 05:59:25 -0500 Received: by mail-ej1-f68.google.com with SMTP id k9so4419255ejc.11 for ; Sun, 22 Nov 2020 02:59:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kEmJgdOt9epBAyBXuoK443XqdXUwSvrAQGvWlpK7B60=; b=nSBD8Uj9OI51zGdzb1C6JFQT4PxrJ9ulHB7Q++Yf8KOq7IvNzP5ltQLdp4yV6AXK7g 2hC8YMPi9TUTMnZV2km/jRhoCwOXiidazFwUsVDSRU4UeGyXAYyyAdO8p4QJVwNOM99d 55+unO6hlINGmKEy6lEtTMnfVZp1KIYoG+pUrLCbRhwcGGc6Ep+4ugPaodIfOH1amDrc ZufQ8XTnSraTMnWEylT+gPutVo6AdbL0zDHKkxRdsQ5dXMbYIsHk6Z9qR7Yx+0yzPQG+ pX543B8+RUicommJqGX6U4X+hYbis9zPvU2UOfEegnB5Hfq2dGPloGPqyvGvz+OuxYf5 dS+g== X-Gm-Message-State: AOAM531tQOb8wa620RPyG9G1RcTdgaAiBphw62tJZtDIgQhkrZwZ3uYG MTMGL9iyq9SUahpMg36a9BA= X-Google-Smtp-Source: ABdhPJx9/at7TqslKqBC1FttD6Qn1HkD8A1lfWiRV3W7aMzo2tQ1gL48uK3RYrJDXbzJbIaGcfMtow== X-Received: by 2002:a17:906:b783:: with SMTP id dt3mr39218452ejb.534.1606042763050; Sun, 22 Nov 2020 02:59:23 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id p25sm994520eju.63.2020.11.22.02.59.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Nov 2020 02:59:21 -0800 (PST) Date: Sun, 22 Nov 2020 11:59:20 +0100 From: Krzysztof Kozlowski To: Mark Brown , Andy Shevchenko , "Rafael J. Wysocki" Cc: linux-kernel@vger.kernel.org, Liam Girdwood , alsa-devel@alsa-project.org, Jaroslav Kysela , Takashi Iwai , Shengjiu Wang Subject: Re: [PATCH 01/38] ASoC: ak5558: drop of_match_ptr from of_device_id table Message-ID: <20201122105813.GA3780@kozik-lap> References: <20201120161653.445521-1-krzk@kernel.org> <20201120165202.GG6751@sirena.org.uk> <20201120194245.GA2925@kozik-lap> <20201120200429.GJ6751@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201120200429.GJ6751@sirena.org.uk> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 20, 2020 at 08:04:29PM +0000, Mark Brown wrote: > On Fri, Nov 20, 2020 at 08:42:45PM +0100, Krzysztof Kozlowski wrote: > > On Fri, Nov 20, 2020 at 04:56:34PM +0000, Mark Brown wrote: > > > > It would be better to fix these by annotating the table as potentially > > > unused, if nothing else it means if someone wants to add ACPI support > > > (or it just works on their ACPI system with the plain old I2C ID) then > > > they don't need to revert this change. > > > The point is after this patch - removal of of_match_ptr() - they will > > already support the ACPI matching through the PRP0001. > > > Keeping of_match_ptr() and maybe_unused will prevent any ACPI re-usage > > unless explicit ACPI table is added > > Surely if that's the desired outcome the fix is to change the definition > of of_match_ptr() such that it leaves the reference with CONFIG_ACPI, > perhaps hidden behind a config option for PRP0001? That seems better > than going through the entire tree like this. That could be indeed an easier way to achieve this. +Cc Andy, Rafael, I saw you were doing similar way as I did here [1] for the 698fffc2705c ("rtc: ds1307: Drop of_match_ptr and CONFIG_OF protections") with the same reasoning as mine ("These prevent use of this driver with ACPI via PRP0001."). Do you have thoughts on Mark's proposal above (to change the of_match_ptr())? [1] https://lore.kernel.org/lkml/20201120161653.445521-1-krzk@kernel.org/ Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E9B5C5519F for ; Sun, 22 Nov 2020 11:00:26 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 631AF20789 for ; Sun, 22 Nov 2020 11:00:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="iJz0ldE0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 631AF20789 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E258D1683; Sun, 22 Nov 2020 11:59:31 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E258D1683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1606042822; bh=scwEBBkoZKneSQXM1pTGdUeijoiUX9cfVYZuVSl9rHY=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=iJz0ldE0t4whM8fwniffkSX1FJk5Sl4HVGKPi7YBEUbmazvjUHvjDGrw08BfebTjF hMyg5Xpt0nyLkhLrRANjtDhsKoDqpy+w3CkVE7bm/DlfSfyDkwa4cCNfiKNZ7vRA8b m7HIX4VgnT0lP0XAovmAOPolOd1jdipAu2t+lbLM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 71C31F80161; Sun, 22 Nov 2020 11:59:31 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 330B8F80165; Sun, 22 Nov 2020 11:59:28 +0100 (CET) Received: from mail-ej1-f66.google.com (mail-ej1-f66.google.com [209.85.218.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 83EF6F80113 for ; Sun, 22 Nov 2020 11:59:23 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 83EF6F80113 Received: by mail-ej1-f66.google.com with SMTP id 7so19237994ejm.0 for ; Sun, 22 Nov 2020 02:59:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kEmJgdOt9epBAyBXuoK443XqdXUwSvrAQGvWlpK7B60=; b=e6SX/xgP8KeGvlZnVY0/qbLcL/PV1Ud49E0yTOBVTd75KpwJaoXRaLx8oat+FJjW4U hOQGKck4eURlIk5zfjmQD0J8u1xXsrKIGs4XdUQi7iqg9O1DrBL/YmIP88GONgdXlb79 UW1bUsVkwVZcHIhL2dyM+c8zYmcTMdpZOHUIW175fU7jQsChAJp4dvcwvcYeuDf19K00 jm2knMSxv9QEi58OeTXI2coF0p8DvRjr0vD1sk+3D4sTrQVXx1BSnO5HUPrZwOAN8bpb 4dzh40a9vFDKJqcsPqR8OsaNMWr8/+jvsYzQOdV5GIRX/K24Ur2VWZ7oXfOA9xlj1xTJ JUkw== X-Gm-Message-State: AOAM530Oq20gUD+5gAN57JC69bRrmwDBUR21aftRYWxy5pJbN3qZ2Qrk YMAj9xJ3JMtGwAuIEjev/Uk= X-Google-Smtp-Source: ABdhPJx9/at7TqslKqBC1FttD6Qn1HkD8A1lfWiRV3W7aMzo2tQ1gL48uK3RYrJDXbzJbIaGcfMtow== X-Received: by 2002:a17:906:b783:: with SMTP id dt3mr39218452ejb.534.1606042763050; Sun, 22 Nov 2020 02:59:23 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id p25sm994520eju.63.2020.11.22.02.59.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Nov 2020 02:59:21 -0800 (PST) Date: Sun, 22 Nov 2020 11:59:20 +0100 From: Krzysztof Kozlowski To: Mark Brown , Andy Shevchenko , "Rafael J. Wysocki" Subject: Re: [PATCH 01/38] ASoC: ak5558: drop of_match_ptr from of_device_id table Message-ID: <20201122105813.GA3780@kozik-lap> References: <20201120161653.445521-1-krzk@kernel.org> <20201120165202.GG6751@sirena.org.uk> <20201120194245.GA2925@kozik-lap> <20201120200429.GJ6751@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201120200429.GJ6751@sirena.org.uk> Cc: alsa-devel@alsa-project.org, Liam Girdwood , linux-kernel@vger.kernel.org, Shengjiu Wang , Takashi Iwai X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Nov 20, 2020 at 08:04:29PM +0000, Mark Brown wrote: > On Fri, Nov 20, 2020 at 08:42:45PM +0100, Krzysztof Kozlowski wrote: > > On Fri, Nov 20, 2020 at 04:56:34PM +0000, Mark Brown wrote: > > > > It would be better to fix these by annotating the table as potentially > > > unused, if nothing else it means if someone wants to add ACPI support > > > (or it just works on their ACPI system with the plain old I2C ID) then > > > they don't need to revert this change. > > > The point is after this patch - removal of of_match_ptr() - they will > > already support the ACPI matching through the PRP0001. > > > Keeping of_match_ptr() and maybe_unused will prevent any ACPI re-usage > > unless explicit ACPI table is added > > Surely if that's the desired outcome the fix is to change the definition > of of_match_ptr() such that it leaves the reference with CONFIG_ACPI, > perhaps hidden behind a config option for PRP0001? That seems better > than going through the entire tree like this. That could be indeed an easier way to achieve this. +Cc Andy, Rafael, I saw you were doing similar way as I did here [1] for the 698fffc2705c ("rtc: ds1307: Drop of_match_ptr and CONFIG_OF protections") with the same reasoning as mine ("These prevent use of this driver with ACPI via PRP0001."). Do you have thoughts on Mark's proposal above (to change the of_match_ptr())? [1] https://lore.kernel.org/lkml/20201120161653.445521-1-krzk@kernel.org/ Best regards, Krzysztof