From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21998C5519F for ; Sun, 22 Nov 2020 22:01:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE31F20757 for ; Sun, 22 Nov 2020 22:01:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qBdPUPS6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726620AbgKVWBS (ORCPT ); Sun, 22 Nov 2020 17:01:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725831AbgKVWBR (ORCPT ); Sun, 22 Nov 2020 17:01:17 -0500 Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com [IPv6:2a00:1450:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3B23C0613CF; Sun, 22 Nov 2020 14:01:15 -0800 (PST) Received: by mail-ej1-x641.google.com with SMTP id 7so20651519ejm.0; Sun, 22 Nov 2020 14:01:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xds3EV1u8LFX/eLCQkAEEEQ5tbAtE69pORfGo1Yk0E4=; b=qBdPUPS6EKKPu17iN3L111KhOsLD6ml1IZMXCdRQj+shf+z/RfO2R0b38Z/5vKH1FA j+8UNlP8OTMPWrbAdBxpKJwp5of33Sve1g3argPzJSpZCXtXIY8NXdjYNG+0OorYpSNN YmVvuV5FpM8COMtY983KT58FG+7pBuBUEb+5i2U99D76qn/rmSu2Qtin8D1SS4pGZTPC 9wUSx+qJgaQChElucO/4DBxcZoYxQJAmnQHcyqpTO340VZab+wEsZTC8oEjJWQ6E62Cp HVSCHDkUdS8RfbqVffiLg5eKc2c3OfvrTa3I4Vnyqv++hgE8UwTJHktdlTd+2MptcbjQ fg/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xds3EV1u8LFX/eLCQkAEEEQ5tbAtE69pORfGo1Yk0E4=; b=iy1c5o0u86rLT8ffoYJtI26ihZOmiefg6moLYjrCgznrxk/IUbf1HB4iu/bx36Db0/ ZxjPgRwPIHMd1pmHXZvkE4WNQO3/EiWpxeKnPoTkQxqYLh1zNPlF5mpgzgkk01irMA7q sE94qzEd6cdMBZcAMXUX2Tb15myzYe6i4yQSXVK5KBel2oTY7+Cwdu0Yxs98qsR4iO+7 XepWDoQOr51+A05+4X2RLqwJy3KI1jhqpQ77TAkGS6pTgJs2niC3z8DpB6DsFpP0JHwC r/jA7qPRJifCOdX91CmxrOSjWeIvpHDGkuOQs77mLvakN2xJU3zv69Qkw8s2oMc98983 a7HQ== X-Gm-Message-State: AOAM531y1I1EuULIPIemm+fvZj+tjcGC/7Ikyed8N3ig2XIcf0SaziYL q1q1UN/0mweAHMm2fAszMfc= X-Google-Smtp-Source: ABdhPJw1b318SLMdEfEhxRpbnkq7+lW3TIKweZq98g+ZP8iZqn9j8ey5boOlz2blAsXlFG6uXLX7Cg== X-Received: by 2002:a17:906:1758:: with SMTP id d24mr3855704eje.287.1606082474566; Sun, 22 Nov 2020 14:01:14 -0800 (PST) Received: from skbuf ([188.25.2.177]) by smtp.gmail.com with ESMTPSA id t11sm3956022ejx.68.2020.11.22.14.01.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Nov 2020 14:01:13 -0800 (PST) Date: Mon, 23 Nov 2020 00:01:12 +0200 From: Vladimir Oltean To: Christian Eggers Cc: Ido Schimmel , Richard Cochran , Andrew Lunn , Heiner Kallweit , Jakub Kicinski , Russell King , "David S . Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Petr Machata , Jiri Pirko , Ido Schimmel Subject: Re: [PATCH net-next 2/3] mlxsw: spectrum_ptp: use PTP wide message type definitions Message-ID: <20201122220112.6ci624wfqp5hefou@skbuf> References: <20201122082636.12451-1-ceggers@arri.de> <20201122082636.12451-3-ceggers@arri.de> <20201122143555.GA515025@shredder.lan> <2074851.ybSLjXPktx@n95hx1g2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2074851.ybSLjXPktx@n95hx1g2> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 22, 2020 at 08:29:22PM +0100, Christian Eggers wrote: > this was also not by intention. Vladimir found some files I missed in the > first series. As the whole first series had already been reviewed at that time, > I wasn't sure whether I am allowed to add further patches to it. Additionally > I didn't concern that although my local build is successful, I should wait > until the first series is applied... When I said that, what I was thinking of (although it might have not been clear) was that if you send further patches, you send them _after_ the initial series is merged. Alternatively, it would have been just as valid to resend the entire series, as a 3+3 patchset with a new revision (v3 -> v4), with review tags collected from the first three, and the last 3 being completely new. Jakub could have superseded v3 and applied v4. The idea behind splicing N patches into a series is that they are logically connected to one another. For example, a patch doesn't build without another. You _could_ split logically-connected patches into separate series and post them independently for review, as long as they are build-time independent. If they aren't, well, what happens is exactly what happened: various test robots will report build failures, which from a maintainer's point of view inspires less confidence to apply a patch as-is. I would not be surprised if Jakub asked you to resend with no change at all, just to ensure that the patch series passes build tests before merging it.