From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1254AC6379D for ; Mon, 23 Nov 2020 10:22:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F8512074B for ; Mon, 23 Nov 2020 10:22:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="TDVt/xqw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728204AbgKWKVy (ORCPT ); Mon, 23 Nov 2020 05:21:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728177AbgKWKVx (ORCPT ); Mon, 23 Nov 2020 05:21:53 -0500 Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com [IPv6:2a00:1450:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80F7BC061A4E for ; Mon, 23 Nov 2020 02:21:53 -0800 (PST) Received: by mail-ej1-x641.google.com with SMTP id z5so2408691ejp.4 for ; Mon, 23 Nov 2020 02:21:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=KicNkypOIaNLZNofAMT0/dbRVfdiQb0EG7yDuWE5ulA=; b=TDVt/xqwo7FGjOiB50CURiRd4zX8Glpc/xzed4IR3D50NS0EqlijbKWHNsEmT9A92f opeYzaDlby6Pgpezpy0Z6eYOPQW6ipaIAyEAtip0SZR01YDtd+SICLsxoZ+9krn8s+et lULt1gHvEOthv2285g8UdKxZGn8PuitA3T+FAGLQ/qKxFihLT0OrTedRRYXRz8VblfZD a1sXohEAJiNhEPF+raDuSX6Ta4nQGnI6siEeVnxshXZXFTiwE+mIarl4EbBFaSYp4ZqT zvmMqJJexFfo+5+oFHJeofxyxcmA2hqWZAvCeahk9touSv1o0xYBPyhqFNpgNP0LgZcR CU2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KicNkypOIaNLZNofAMT0/dbRVfdiQb0EG7yDuWE5ulA=; b=QozWg9lCTzpRcKLD2jO8hJNKT5vb5N8r8tRf1ah1pjwAPdheHUaVvrPlMg6dNNa3Jx K0jlHL2NhqEOdIRNPHvwPqQZULt44z80m9TvHhWi4FAkCvInTKCYwGjAs30XiJLke7CE aLjjGtAMOah5zT5LpYxrx/TK2kAGW7hE+iIXOMG5aoy8ua9oDRtQ9PR6mfF0AdMDWkF6 lxrcl5RROsJz29fKpsocz0GiBqergwedzhcyD4PiUBzmhjaMrSVYbwsfxKU/i3e2nxxd kKTRxxj6pXsOmFgGw22cFQzwfQQxw+dxLFusDJd4mywUWIpezR/OoW8cEjJwRvU/uKYz QR6g== X-Gm-Message-State: AOAM531SRsaT5cL2oRk+DNveEv68tMtUcTaEb6k+KGTtpUpJZwUzRqt8 KRplzb90P3B39VfaLvT6RPYTiQ== X-Google-Smtp-Source: ABdhPJxFSYMYi0puK0drxRNruUpOKNZHKEgE3EPEQ608H69x9iUkj+1IRAw3SWeiVlPLVEVUtEhq+A== X-Received: by 2002:a17:906:8058:: with SMTP id x24mr44772875ejw.272.1606126911958; Mon, 23 Nov 2020 02:21:51 -0800 (PST) Received: from google.com ([2a01:4b00:8523:2d03:acac:b2ef:c7d:fd8a]) by smtp.gmail.com with ESMTPSA id k3sm4725861ejd.36.2020.11.23.02.21.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Nov 2020 02:21:51 -0800 (PST) Date: Mon, 23 Nov 2020 10:21:49 +0000 From: David Brazdil To: Sami Tolvanen Cc: Masahiro Yamada , Steven Rostedt , Will Deacon , Josh Poimboeuf , Peter Zijlstra , Greg Kroah-Hartman , "Paul E. McKenney" , Kees Cook , Nick Desaulniers , clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v7 15/17] KVM: arm64: disable LTO for the nVHE directory Message-ID: <20201123102149.ogl642tw234qod62@google.com> References: <20201118220731.925424-1-samitolvanen@google.com> <20201118220731.925424-16-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201118220731.925424-16-samitolvanen@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey Sami, On Wed, Nov 18, 2020 at 02:07:29PM -0800, Sami Tolvanen wrote: > We use objcopy to manipulate ELF binaries for the nVHE code, > which fails with LTO as the compiler produces LLVM bitcode > instead. Disable LTO for this code to allow objcopy to be used. We now partially link the nVHE code (generating machine code) before objcopy, so I think you should be able to drop this patch now. Tried building your branch without it, ran a couple of unit tests and all seems fine. David From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 927F5C2D0E4 for ; Mon, 23 Nov 2020 10:23:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1331720731 for ; Mon, 23 Nov 2020 10:23:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="opJ5Fx0n"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="TDVt/xqw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1331720731 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KxkhmMkstif3MTxJ1GiR7VqfmkbN1yBZCBTVwcy3swU=; b=opJ5Fx0nuGyhijxyC0M/lrDWo l1Ac1FlNowlYZgWpm5zD6aYQyKji8KTqPnNzPLGMIViVsM6M8YDyccgRg995Cvy6oGIakAX0pgMnA 6LtBi3UiL+Yx5u31cEncwNdN54GMsW7f/t/+5mRhXxW5pdH1jiyXzcnZdLj2FNlJduzT85mA7Go5o 7jl78licDe0rSvMeSygR/uYQIec/cgpVgOmc6YgF4QpdrvG3JUHGrWlJCz8Mm2b/NT3phWiZa6KOS rkulHttVx+aXABBrSoHbbuUGYL8ydNqqaN6UFbHRhUcrishVpjcydL/o35AjqV0Aw8XcudRbd0yDu dh30Of12w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kh8ys-0003zy-0q; Mon, 23 Nov 2020 10:21:58 +0000 Received: from mail-ej1-x643.google.com ([2a00:1450:4864:20::643]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kh8yp-0003zF-7V for linux-arm-kernel@lists.infradead.org; Mon, 23 Nov 2020 10:21:55 +0000 Received: by mail-ej1-x643.google.com with SMTP id f23so22534784ejk.2 for ; Mon, 23 Nov 2020 02:21:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=KicNkypOIaNLZNofAMT0/dbRVfdiQb0EG7yDuWE5ulA=; b=TDVt/xqwo7FGjOiB50CURiRd4zX8Glpc/xzed4IR3D50NS0EqlijbKWHNsEmT9A92f opeYzaDlby6Pgpezpy0Z6eYOPQW6ipaIAyEAtip0SZR01YDtd+SICLsxoZ+9krn8s+et lULt1gHvEOthv2285g8UdKxZGn8PuitA3T+FAGLQ/qKxFihLT0OrTedRRYXRz8VblfZD a1sXohEAJiNhEPF+raDuSX6Ta4nQGnI6siEeVnxshXZXFTiwE+mIarl4EbBFaSYp4ZqT zvmMqJJexFfo+5+oFHJeofxyxcmA2hqWZAvCeahk9touSv1o0xYBPyhqFNpgNP0LgZcR CU2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KicNkypOIaNLZNofAMT0/dbRVfdiQb0EG7yDuWE5ulA=; b=PyueXaRocQ5U3BRpfEWsYotpXPFwWuhzhgsZKrdFkrBX3vnqE7i3r6qgIX4VkYja0u 3hYMG3MqYWTSqeOzHcJIRmuOfH0Kk0rOMGwVE0gnJxhbkZZ+x6LbAet6iDVodZ1Ndj3N NPo1Q1iXav7ZUmAKqMroFdjDq1C4qtGmlPhdhxxiCcBz5RJOAmxhlKnOpZKnkuFZmVS8 Fg+/J4iTxobnwfoJ0wwOYmXaLP73NagQucqoplO/Z7rDwk/1C5CA45bEIbIrq//vvLrh BxeQgMNV9zJTACiuxxPdqIQUwyZVA8HtJudxkt3wa2iruZgdFb7acfGFa5ETzxzlsJxi b1TA== X-Gm-Message-State: AOAM5336o/6hH3oR91KMsW1CrEwH+u1LigD0CPB8iYwPZdgi96obPY0y 7gYvkxCWyaOEwZaQDobtnxTpqA== X-Google-Smtp-Source: ABdhPJxFSYMYi0puK0drxRNruUpOKNZHKEgE3EPEQ608H69x9iUkj+1IRAw3SWeiVlPLVEVUtEhq+A== X-Received: by 2002:a17:906:8058:: with SMTP id x24mr44772875ejw.272.1606126911958; Mon, 23 Nov 2020 02:21:51 -0800 (PST) Received: from google.com ([2a01:4b00:8523:2d03:acac:b2ef:c7d:fd8a]) by smtp.gmail.com with ESMTPSA id k3sm4725861ejd.36.2020.11.23.02.21.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Nov 2020 02:21:51 -0800 (PST) Date: Mon, 23 Nov 2020 10:21:49 +0000 From: David Brazdil To: Sami Tolvanen Subject: Re: [PATCH v7 15/17] KVM: arm64: disable LTO for the nVHE directory Message-ID: <20201123102149.ogl642tw234qod62@google.com> References: <20201118220731.925424-1-samitolvanen@google.com> <20201118220731.925424-16-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201118220731.925424-16-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201123_052155_306314_1DA02EA6 X-CRM114-Status: GOOD ( 13.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Kees Cook , "Paul E. McKenney" , kernel-hardening@lists.openwall.com, Peter Zijlstra , Greg Kroah-Hartman , Masahiro Yamada , linux-kbuild@vger.kernel.org, Nick Desaulniers , linux-kernel@vger.kernel.org, Steven Rostedt , clang-built-linux@googlegroups.com, linux-pci@vger.kernel.org, Josh Poimboeuf , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hey Sami, On Wed, Nov 18, 2020 at 02:07:29PM -0800, Sami Tolvanen wrote: > We use objcopy to manipulate ELF binaries for the nVHE code, > which fails with LTO as the compiler produces LLVM bitcode > instead. Disable LTO for this code to allow objcopy to be used. We now partially link the nVHE code (generating machine code) before objcopy, so I think you should be able to drop this patch now. Tried building your branch without it, ran a couple of unit tests and all seems fine. David _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel