From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDFFEC388F9 for ; Mon, 23 Nov 2020 11:43:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 738C120758 for ; Mon, 23 Nov 2020 11:43:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728852AbgKWLnv (ORCPT ); Mon, 23 Nov 2020 06:43:51 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:50009 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728696AbgKWLnu (ORCPT ); Mon, 23 Nov 2020 06:43:50 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 6E5965C00D7; Mon, 23 Nov 2020 06:43:49 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 23 Nov 2020 06:43:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=6CLGdeqjnHV36lsaSjeQCo3gngo +lV3FUJ/1d+tqsmk=; b=iaH5gmB5KwY5lOeaGoPNwd5dLSCr165R01SggCKKONc 9RMOHt9EiGXGSOOtVZg15MT6rsmdWs/HykPQw+s/HUySuffWvWfVxtTnz/pB2RgP SaRRAVgrdp5rpALBnClY0jczvSNqQ1XPwLSXUS18znFmM2vlx2BZGBplVwYv+zrB NzQNTT1x2wTo/foBs8hiM2RD1Cj4zJJSoTlGSpybxnBv4IZoNXhr0hA2QIMO0fIy R24QRJG73ckcvlyRHWiHLul3u9Au5iJy+kifvLZpRaB7PLuIMsooTjuXe7JtufuT amGJfVAniBlTJ54w11D/cj7qDnL5e2Vh4T6snQb6xaA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=6CLGde qjnHV36lsaSjeQCo3gngo+lV3FUJ/1d+tqsmk=; b=oATBxzTsNeD5dkJRA0EAr0 4WwP7CYwmKTFEtD32vZVg7X5FHjgVPv2pJQWoe8T9gL36L7UG3kvo7FDhqnH3k/s XNdI4+GtwUB1OZWuOW6zJIV0Va9qi1kXuhQ/605RMqvPmWAkh6VyDWmrqPKQE9hi FgfhqVsilt5cHDSFZ9TrhbICOkR9oBcrtWq5F6sc5Y8KuxGozfWEp5dTjanjsxzi +efTs2b4hOrlkIuFnrydwTrGbYBdSaTMHm8c6ux70Z6bv/Bnz2yigeVNRNummhDS l1ViuOnETaVpynt/Ve9x4WVI38OFjkpg++gh2n+exSTcMaHmU6zw9z0LBJOgIMTw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudegiedgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 6C7CC3280059; Mon, 23 Nov 2020 06:43:48 -0500 (EST) Date: Mon, 23 Nov 2020 12:43:47 +0100 From: Maxime Ripard To: Icenowy Zheng Cc: Chen-Yu Tsai , Jernej Skrabec , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, inux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 3/3] ARM: dts: sun8i: s3: switch PineCube to use OHCI/EHCI only Message-ID: <20201123114347.attmmi3sipgxnnhc@gilmour> References: <20201122003841.1957034-1-icenowy@aosc.io> <20201122004011.1957325-2-icenowy@aosc.io> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4u5dpl4he57zcb5w" Content-Disposition: inline In-Reply-To: <20201122004011.1957325-2-icenowy@aosc.io> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --4u5dpl4he57zcb5w Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sun, Nov 22, 2020 at 08:40:11AM +0800, Icenowy Zheng wrote: > The PineCube board features a USB Type-A connector connected to the > SoC's USB pins. >=20 > As this is not designed for being used as a USB device, disable OTG > controller and route USB to OHCI/EHCI fixedly. It's not designed to be used as one, but does it work? We've had a number of boards where this happened in the past, and it was usable for FEL, or any peripheral really. If it did work, then this is a regression. Also, you should explain why this is a good idea: if both can act as a host, then why should we switch to the HCI controllers? > Signed-off-by: Icenowy Zheng > --- > arch/arm/boot/dts/sun8i-s3-pinecube.dts | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) >=20 > diff --git a/arch/arm/boot/dts/sun8i-s3-pinecube.dts b/arch/arm/boot/dts/= sun8i-s3-pinecube.dts > index 4aa0ee897a0a..c4177c54ef29 100644 > --- a/arch/arm/boot/dts/sun8i-s3-pinecube.dts > +++ b/arch/arm/boot/dts/sun8i-s3-pinecube.dts > @@ -78,6 +78,12 @@ csi1_ep: endpoint { > }; > }; > =20 > +&ehci0 { > + phys =3D <&usbphy 0>; > + phy-names =3D "usb"; This is weird to me to have the PHY set in the DTSI for musb, but not for the USB controllers. Maxime --4u5dpl4he57zcb5w Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX7ugcgAKCRDj7w1vZxhR xUHVAQCd/QWHNNMhWUg/VyvE0Iql6ijEeov8DgTMJmqPcUj0LQD9EseqPI6QWtcb bnTd7LL8h1YV319A2+fgZqM9IZvz4AY= =0BZB -----END PGP SIGNATURE----- --4u5dpl4he57zcb5w-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CF31C2D0E4 for ; Mon, 23 Nov 2020 11:44:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED5F52074B for ; Mon, 23 Nov 2020 11:44:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gHGfL0dw"; dkim=temperror (0-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="iaH5gmB5"; dkim=temperror (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="oATBxzTs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED5F52074B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pM4r2jdyeHhwoxMHF5SLSYJ3eoLAVS/crowfGJL6EO4=; b=gHGfL0dwPeVb7GaR6JsXYQCbx i9rXnRjrz6Ep2fAS0g3Qt3wqKV+G1e8wejHiXwuBHYZ2N8IcA9szvDFk+pfqML+NLwYQe7Eg9pxWS CxphwXKlAc7aldUvV3V+dezc7XFEv0cC93kzFS4tjejXrGaKqfdH4saZynTBFy82oiz0qWWM/rZ9I IsegDt0pwVOCH/4yWhinYlbNdZV7PvA/6AP/eG79ODsUbzYck2qovGQjOypQRbguwWv0JcXgnxQHs X3do369CiFin+IjfZx/Z+6Dk2+qH3g6DSbwqlvg4gO/gYYNT2O/6yEObTzJDkxhBInmdigOPnpnZI KG1jw4h0Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khAGC-0003jE-1s; Mon, 23 Nov 2020 11:43:56 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khAG9-0003ij-LC for linux-arm-kernel@lists.infradead.org; Mon, 23 Nov 2020 11:43:54 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 6E5965C00D7; Mon, 23 Nov 2020 06:43:49 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 23 Nov 2020 06:43:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=6CLGdeqjnHV36lsaSjeQCo3gngo +lV3FUJ/1d+tqsmk=; b=iaH5gmB5KwY5lOeaGoPNwd5dLSCr165R01SggCKKONc 9RMOHt9EiGXGSOOtVZg15MT6rsmdWs/HykPQw+s/HUySuffWvWfVxtTnz/pB2RgP SaRRAVgrdp5rpALBnClY0jczvSNqQ1XPwLSXUS18znFmM2vlx2BZGBplVwYv+zrB NzQNTT1x2wTo/foBs8hiM2RD1Cj4zJJSoTlGSpybxnBv4IZoNXhr0hA2QIMO0fIy R24QRJG73ckcvlyRHWiHLul3u9Au5iJy+kifvLZpRaB7PLuIMsooTjuXe7JtufuT amGJfVAniBlTJ54w11D/cj7qDnL5e2Vh4T6snQb6xaA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=6CLGde qjnHV36lsaSjeQCo3gngo+lV3FUJ/1d+tqsmk=; b=oATBxzTsNeD5dkJRA0EAr0 4WwP7CYwmKTFEtD32vZVg7X5FHjgVPv2pJQWoe8T9gL36L7UG3kvo7FDhqnH3k/s XNdI4+GtwUB1OZWuOW6zJIV0Va9qi1kXuhQ/605RMqvPmWAkh6VyDWmrqPKQE9hi FgfhqVsilt5cHDSFZ9TrhbICOkR9oBcrtWq5F6sc5Y8KuxGozfWEp5dTjanjsxzi +efTs2b4hOrlkIuFnrydwTrGbYBdSaTMHm8c6ux70Z6bv/Bnz2yigeVNRNummhDS l1ViuOnETaVpynt/Ve9x4WVI38OFjkpg++gh2n+exSTcMaHmU6zw9z0LBJOgIMTw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudegiedgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 6C7CC3280059; Mon, 23 Nov 2020 06:43:48 -0500 (EST) Date: Mon, 23 Nov 2020 12:43:47 +0100 From: Maxime Ripard To: Icenowy Zheng Subject: Re: [PATCH 3/3] ARM: dts: sun8i: s3: switch PineCube to use OHCI/EHCI only Message-ID: <20201123114347.attmmi3sipgxnnhc@gilmour> References: <20201122003841.1957034-1-icenowy@aosc.io> <20201122004011.1957325-2-icenowy@aosc.io> MIME-Version: 1.0 In-Reply-To: <20201122004011.1957325-2-icenowy@aosc.io> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201123_064353_747931_989475E7 X-CRM114-Status: GOOD ( 19.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jernej Skrabec , inux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============0327651552233979608==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0327651552233979608== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4u5dpl4he57zcb5w" Content-Disposition: inline --4u5dpl4he57zcb5w Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sun, Nov 22, 2020 at 08:40:11AM +0800, Icenowy Zheng wrote: > The PineCube board features a USB Type-A connector connected to the > SoC's USB pins. >=20 > As this is not designed for being used as a USB device, disable OTG > controller and route USB to OHCI/EHCI fixedly. It's not designed to be used as one, but does it work? We've had a number of boards where this happened in the past, and it was usable for FEL, or any peripheral really. If it did work, then this is a regression. Also, you should explain why this is a good idea: if both can act as a host, then why should we switch to the HCI controllers? > Signed-off-by: Icenowy Zheng > --- > arch/arm/boot/dts/sun8i-s3-pinecube.dts | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) >=20 > diff --git a/arch/arm/boot/dts/sun8i-s3-pinecube.dts b/arch/arm/boot/dts/= sun8i-s3-pinecube.dts > index 4aa0ee897a0a..c4177c54ef29 100644 > --- a/arch/arm/boot/dts/sun8i-s3-pinecube.dts > +++ b/arch/arm/boot/dts/sun8i-s3-pinecube.dts > @@ -78,6 +78,12 @@ csi1_ep: endpoint { > }; > }; > =20 > +&ehci0 { > + phys =3D <&usbphy 0>; > + phy-names =3D "usb"; This is weird to me to have the PHY set in the DTSI for musb, but not for the USB controllers. Maxime --4u5dpl4he57zcb5w Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX7ugcgAKCRDj7w1vZxhR xUHVAQCd/QWHNNMhWUg/VyvE0Iql6ijEeov8DgTMJmqPcUj0LQD9EseqPI6QWtcb bnTd7LL8h1YV319A2+fgZqM9IZvz4AY= =0BZB -----END PGP SIGNATURE----- --4u5dpl4he57zcb5w-- --===============0327651552233979608== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0327651552233979608==--