All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ioana Ciornei <ioana.ciornei@nxp.com>
To: Ezequiel Garcia <ezequiel@collabora.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Jakub Kicinski <kuba@kernel.org>,
	"David S . Miller" <davem@davemloft.net>,
	Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>,
	"kernel@collabora.com" <kernel@collabora.com>
Subject: Re: [PATCH] dpaa2-eth: Fix compile error due to missing devlink support
Date: Mon, 23 Nov 2020 15:15:52 +0000	[thread overview]
Message-ID: <20201123151551.7h3ivyj4hujx72uv@skbuf> (raw)
In-Reply-To: <c0e98111cafbdbb5d4d29e5e87ae779144370cf6.camel@collabora.com>

On Mon, Nov 23, 2020 at 12:06:14PM -0300, Ezequiel Garcia wrote:
> Hi Ioana,
> 
> On Mon, 2020-11-23 at 09:39 +0000, Ioana Ciornei wrote:
> > Hi Ezequiel,
> > 
> > Thanks a lot for the fix, I overlooked this when adding devlink support.
> > 
> 
> No worries :)
> 
> > On Sat, Nov 21, 2020 at 09:23:36PM -0300, Ezequiel Garcia wrote:
> > > The dpaa2 driver depends on devlink, so it should select
> > > NET_DEVLINK in order to fix compile errors, such as:
> > > 
> > > drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.o: in function `dpaa2_eth_rx_err':
> > > dpaa2-eth.c:(.text+0x3cec): undefined reference to `devlink_trap_report'
> > > drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.o: in function `dpaa2_eth_dl_info_get':
> > > dpaa2-eth-devlink.c:(.text+0x160): undefined reference to `devlink_info_driver_name_put'
> > > 
> > 
> > What tree is this intended for?
> > 
> 
> Oops, I forgot about netdev rules. I guess I haven't sent
> a net patch in a long time.
> 
> This patch is a fix, so I guess it's for the 'net' tree.
>  
> > Maybe add a fixes tag and send this towards the net tree?
> > 
> 
> Would you mind too much taking care of this, putting the
> Fixes you think matches best?
> 
> That would be really appreciated!
> 

Sure, I'll respin this.

Ioana

      reply	other threads:[~2020-11-23 15:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-22  0:23 [PATCH] dpaa2-eth: Fix compile error due to missing devlink support Ezequiel Garcia
2020-11-23  9:39 ` Ioana Ciornei
2020-11-23 15:06   ` Ezequiel Garcia
2020-11-23 15:15     ` Ioana Ciornei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201123151551.7h3ivyj4hujx72uv@skbuf \
    --to=ioana.ciornei@nxp.com \
    --cc=davem@davemloft.net \
    --cc=ezequiel@collabora.com \
    --cc=kernel@collabora.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ruxandra.radulescu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.