From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0951BC63777 for ; Mon, 23 Nov 2020 19:33:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B82020706 for ; Mon, 23 Nov 2020 19:33:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730518AbgKWTcw (ORCPT ); Mon, 23 Nov 2020 14:32:52 -0500 Received: from foss.arm.com ([217.140.110.172]:38780 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729595AbgKWTcv (ORCPT ); Mon, 23 Nov 2020 14:32:51 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 97DE4101E; Mon, 23 Nov 2020 11:32:50 -0800 (PST) Received: from C02TD0UTHF1T.local (unknown [10.57.27.26]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DDCC93F71F; Mon, 23 Nov 2020 11:32:46 -0800 (PST) Date: Mon, 23 Nov 2020 19:32:41 +0000 From: Mark Rutland To: Marco Elver Cc: Will Deacon , "Paul E. McKenney" , Steven Rostedt , Anders Roxell , Andrew Morton , Alexander Potapenko , Dmitry Vyukov , Jann Horn , Linux Kernel Mailing List , Linux-MM , kasan-dev , rcu@vger.kernel.org, Peter Zijlstra , Tejun Heo , Lai Jiangshan , linux-arm-kernel@lists.infradead.org Subject: Re: linux-next: stall warnings and deadlock on Arm64 (was: [PATCH] kfence: Avoid stalling...) Message-ID: <20201123193241.GA45639@C02TD0UTHF1T.local> References: <20201118233841.GS1437@paulmck-ThinkPad-P72> <20201119125357.GA2084963@elver.google.com> <20201119151409.GU1437@paulmck-ThinkPad-P72> <20201119170259.GA2134472@elver.google.com> <20201119184854.GY1437@paulmck-ThinkPad-P72> <20201119193819.GA2601289@elver.google.com> <20201119213512.GB1437@paulmck-ThinkPad-P72> <20201119225352.GA5251@willie-the-truck> <20201120103031.GB2328@C02TD0UTHF1T.local> <20201120140332.GA3120165@elver.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201120140332.GA3120165@elver.google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 20, 2020 at 03:03:32PM +0100, Marco Elver wrote: > On Fri, Nov 20, 2020 at 10:30AM +0000, Mark Rutland wrote: > > On Thu, Nov 19, 2020 at 10:53:53PM +0000, Will Deacon wrote: > > > FWIW, arm64 is known broken wrt lockdep and irq tracing atm. Mark has been > > > looking at that and I think he is close to having something workable. > > > > > > Mark -- is there anything Marco and Paul can try out? > > > > I initially traced some issues back to commit: > > > > 044d0d6de9f50192 ("lockdep: Only trace IRQ edges") > > > > ... and that change of semantic could cause us to miss edges in some > > cases, but IIUC mostly where we haven't done the right thing in > > exception entry/return. > > > > I don't think my patches address this case yet, but my WIP (currently > > just fixing user<->kernel transitions) is at: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/log/?h=arm64/irq-fixes > > > > I'm looking into the kernel<->kernel transitions now, and I know that we > > mess up RCU management for a small window around arch_cpu_idle, but it's > > not immediately clear to me if either of those cases could cause this > > report. > > Thank you -- I tried your irq-fixes, however that didn't seem to fix the > problem (still get warnings and then a panic). :-/ I've just updated that branch with a new version which I hope covers kernel<->kernel transitions too. If you get a chance, would you mind giving that a spin? The HEAD commit should be: a51334f033f8ee88 ("HACK: check IRQ tracing has RCU watching") Otherwise, I intend to clean that up and post it tomorrow (without the additional debug hacks). I've thrown my local Syzkaller instance at it in the mean time (and if I get the chance tomrrow I'll try to get rcutorture setup), and the only report I'm seeing so far looks genuine: | BUG: sleeping function called from invalid context in sta_info_move_state ... as that was reported on x86 too, per: https://syzkaller.appspot.com/bug?id=6c7899acf008be2ddcddb46a2567c2153193632a Thanks, Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CD18C2D0E4 for ; Mon, 23 Nov 2020 19:33:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C3F88206B6 for ; Mon, 23 Nov 2020 19:33:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ggPsUdsb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3F88206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6spq3c5ufF6Lf82936xHa5Fcz00mPg2SYZuJ+rIWwl4=; b=ggPsUdsb/rwktjotsf0bjirz4 h93MDFqSof8n0kUwzhfRlqUHIiHQnixTHE7THj+HpZmKWQfIoEpUttEDZe9o7qNo9/0f+IuUmuj1E TNIFRIBxWVZB8rGek/k9lUyyZ+thf62c01IKpZ3XMz7/pTT/P9yaqFKScu2+j+1i5pqbPTCoqouda cT36IicFwZfUyx1a/hBn5MF3ZXGT5mxyS6MnNg5tjh2ZOIUYzctzd2fjrvhE3O0E2eJHSlB5q12iV MzhOrtGR8Qpi32xufGLpA7iKfD26j3r82zFswpuOn+DcWD5kfZD+LFYS42U9JalGRql2e7cjn1vf1 Q0LDtmF6g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khHa5-0005CV-0m; Mon, 23 Nov 2020 19:32:57 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khHa2-0005BL-0B for linux-arm-kernel@lists.infradead.org; Mon, 23 Nov 2020 19:32:54 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 97DE4101E; Mon, 23 Nov 2020 11:32:50 -0800 (PST) Received: from C02TD0UTHF1T.local (unknown [10.57.27.26]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DDCC93F71F; Mon, 23 Nov 2020 11:32:46 -0800 (PST) Date: Mon, 23 Nov 2020 19:32:41 +0000 From: Mark Rutland To: Marco Elver Subject: Re: linux-next: stall warnings and deadlock on Arm64 (was: [PATCH] kfence: Avoid stalling...) Message-ID: <20201123193241.GA45639@C02TD0UTHF1T.local> References: <20201118233841.GS1437@paulmck-ThinkPad-P72> <20201119125357.GA2084963@elver.google.com> <20201119151409.GU1437@paulmck-ThinkPad-P72> <20201119170259.GA2134472@elver.google.com> <20201119184854.GY1437@paulmck-ThinkPad-P72> <20201119193819.GA2601289@elver.google.com> <20201119213512.GB1437@paulmck-ThinkPad-P72> <20201119225352.GA5251@willie-the-truck> <20201120103031.GB2328@C02TD0UTHF1T.local> <20201120140332.GA3120165@elver.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201120140332.GA3120165@elver.google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201123_143254_096503_AE6A6BF2 X-CRM114-Status: GOOD ( 24.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Anders Roxell , "Paul E. McKenney" , Jann Horn , Peter Zijlstra , Lai Jiangshan , Linux Kernel Mailing List , Steven Rostedt , rcu@vger.kernel.org, Linux-MM , Alexander Potapenko , kasan-dev , Tejun Heo , Andrew Morton , Will Deacon , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 20, 2020 at 03:03:32PM +0100, Marco Elver wrote: > On Fri, Nov 20, 2020 at 10:30AM +0000, Mark Rutland wrote: > > On Thu, Nov 19, 2020 at 10:53:53PM +0000, Will Deacon wrote: > > > FWIW, arm64 is known broken wrt lockdep and irq tracing atm. Mark has been > > > looking at that and I think he is close to having something workable. > > > > > > Mark -- is there anything Marco and Paul can try out? > > > > I initially traced some issues back to commit: > > > > 044d0d6de9f50192 ("lockdep: Only trace IRQ edges") > > > > ... and that change of semantic could cause us to miss edges in some > > cases, but IIUC mostly where we haven't done the right thing in > > exception entry/return. > > > > I don't think my patches address this case yet, but my WIP (currently > > just fixing user<->kernel transitions) is at: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/log/?h=arm64/irq-fixes > > > > I'm looking into the kernel<->kernel transitions now, and I know that we > > mess up RCU management for a small window around arch_cpu_idle, but it's > > not immediately clear to me if either of those cases could cause this > > report. > > Thank you -- I tried your irq-fixes, however that didn't seem to fix the > problem (still get warnings and then a panic). :-/ I've just updated that branch with a new version which I hope covers kernel<->kernel transitions too. If you get a chance, would you mind giving that a spin? The HEAD commit should be: a51334f033f8ee88 ("HACK: check IRQ tracing has RCU watching") Otherwise, I intend to clean that up and post it tomorrow (without the additional debug hacks). I've thrown my local Syzkaller instance at it in the mean time (and if I get the chance tomrrow I'll try to get rcutorture setup), and the only report I'm seeing so far looks genuine: | BUG: sleeping function called from invalid context in sta_info_move_state ... as that was reported on x86 too, per: https://syzkaller.appspot.com/bug?id=6c7899acf008be2ddcddb46a2567c2153193632a Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel