All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: "George, Martin" <Martin.George@netapp.com>
Cc: "anton@lightbitslabs.com" <anton@lightbitslabs.com>,
	"hch@lst.de" <hch@lst.de>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"sagi@grimberg.me" <sagi@grimberg.me>
Subject: Re: [PATCH] nvme-core: update NS Attr Changed AEN handling for ANA group
Date: Mon, 23 Nov 2020 11:43:37 -0800	[thread overview]
Message-ID: <20201123194337.GC2865091@dhcp-10-100-145-180.wdc.com> (raw)
In-Reply-To: <d50766c203d849fa97003ef9585af47f059dc42c.camel@netapp.com>

On Mon, Nov 23, 2020 at 07:29:05PM +0000, George, Martin wrote:
> On Mon, 2020-11-23 at 11:16 -0800, Sagi Grimberg wrote:
> > 
> > This looks like a good simple solution to me...
> > 
> > > ---
> > > diff --git a/drivers/nvme/host/multipath.c
> > > b/drivers/nvme/host/multipath.c
> > > index 74896be40c17..300cff8c616d 100644
> > > --- a/drivers/nvme/host/multipath.c
> > > +++ b/drivers/nvme/host/multipath.c
> > > @@ -667,6 +667,8 @@ void nvme_mpath_add_disk(struct nvme_ns *ns,
> > > struct nvme_id_ns *id)
> > >               if (desc.state) {
> > >                       /* found the group desc: update */
> > >                       nvme_update_ns_ana_state(&desc, ns);
> > > +             } else {
> > > +                     nvme_read_ana_log(ctrl);
> 
> Shouldn't this be nvme_read_ana_log(ns->ctrl)?

Oops, I just did a quick copy-paste. You are correct.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2020-11-23 19:43 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20201118114859.7985-1-marting@netapp.com>
2020-11-18 16:24 ` [PATCH] nvme-core: update NS Attr Changed AEN handling for ANA group Christoph Hellwig
2020-11-18 20:09   ` George, Martin
2020-11-20  9:44     ` hch
2020-11-23 14:35       ` Meneghini, John
2020-11-23 15:27         ` Knight, Frederick
2020-11-23 15:54           ` Meneghini, John
2020-12-07 15:25           ` hch
2020-12-08 15:21             ` Knight, Frederick
2020-12-08 17:40               ` Keith Busch
2020-12-08 18:15                 ` Knight, Frederick
2020-12-08 18:34                   ` Keith Busch
2020-12-08 19:13                     ` Knight, Frederick
2020-12-08 21:46                       ` Keith Busch
2020-12-09  0:07                         ` Knight, Frederick
2020-12-09  0:20                           ` Keith Busch
2020-12-09  7:26                             ` Hannes Reinecke
2020-12-09  0:13                         ` Knight, Frederick
2020-12-09  7:28                           ` hch
2020-12-09 15:20                             ` Knight, Frederick
2020-12-09 15:53                               ` Keith Busch
2020-12-09 16:02                                 ` Hannes Reinecke
2020-12-09 16:19                                   ` Keith Busch
2020-12-09 17:04                                     ` Hannes Reinecke
2020-12-09 17:39                                       ` Keith Busch
2020-12-09 17:47                                         ` hch
2020-12-09 20:58                                           ` Knight, Frederick
2020-12-09 21:34                                             ` Keith Busch
2020-12-10  8:51                                               ` hch
2020-12-10  9:13                                                 ` Hannes Reinecke
2020-12-10 13:34                                                   ` Keith Busch
2021-01-14  3:09                                                     ` Sagi Grimberg
2021-01-14 22:59                                                       ` Knight, Frederick
2021-01-14 23:16                                                         ` Keith Busch
2021-01-15  7:15                                                         ` Hannes Reinecke
2020-11-23 17:36       ` Keith Busch
2020-11-23 19:16         ` Sagi Grimberg
2020-11-23 19:29           ` George, Martin
2020-11-23 19:43             ` Keith Busch [this message]
2020-11-26 16:16               ` George, Martin
2020-12-04 14:40                 ` Hannes Reinecke
2020-11-18 16:51 ` Sagi Grimberg
2020-11-18 20:16   ` George, Martin
2020-11-20  9:46   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201123194337.GC2865091@dhcp-10-100-145-180.wdc.com \
    --to=kbusch@kernel.org \
    --cc=Martin.George@netapp.com \
    --cc=anton@lightbitslabs.com \
    --cc=hch@lst.de \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.