From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A9B4C63798 for ; Mon, 23 Nov 2020 22:46:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1005D206D8 for ; Mon, 23 Nov 2020 22:46:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="v11MAbFC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733241AbgKWWpx (ORCPT ); Mon, 23 Nov 2020 17:45:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:49544 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731732AbgKWWpw (ORCPT ); Mon, 23 Nov 2020 17:45:52 -0500 Received: from embeddedor (187-162-31-110.static.axtel.net [187.162.31.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5B42C206D8; Mon, 23 Nov 2020 22:45:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606171551; bh=YeXORuYvulv58OJVqFhqjrxZD3NOKTu9giy9B55KELE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=v11MAbFCOMmcb16mWdAMQrYjbaNbGjQ0wm1IPEho8zk2IMcJB5E6kfSiGmKEEmqJg ThQHAgMIcK9qhIGPpLDRYlwcl96szEHMt6M5C3I369lDQ+O40XM1WP0u8tXfknh4Ad nN2xRbHTymFzMcxtbYjNod4z02uZoFi6pWoCZ9SI= Date: Mon, 23 Nov 2020 16:46:05 -0600 From: "Gustavo A. R. Silva" To: Chuck Lever Cc: Bruce Fields , Linux NFS Mailing List , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 016/141] nfsd: Fix fall-through warnings for Clang Message-ID: <20201123224605.GF21644@embeddedor> References: <0669408377bdc6ee87b214b2756465a6edc354fc.1605896059.git.gustavoars@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 20, 2020 at 01:27:51PM -0500, Chuck Lever wrote: > > > > On Nov 20, 2020, at 1:26 PM, Gustavo A. R. Silva wrote: > > > > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > > warnings by explicitly adding a couple of break statements instead of > > just letting the code fall through to the next case. > > > > Link: https://github.com/KSPP/linux/issues/115 > > Signed-off-by: Gustavo A. R. Silva > > --- > > fs/nfsd/nfs4state.c | 1 + > > fs/nfsd/nfsctl.c | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c > > index d7f27ed6b794..cdab0d5be186 100644 > > --- a/fs/nfsd/nfs4state.c > > +++ b/fs/nfsd/nfs4state.c > > @@ -3113,6 +3113,7 @@ nfsd4_exchange_id(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, > > goto out_nolock; > > } > > new->cl_mach_cred = true; > > + break; > > case SP4_NONE: > > break; > > default: /* checked by xdr code */ > > diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c > > index f6d5d783f4a4..9a3bb1e217f9 100644 > > --- a/fs/nfsd/nfsctl.c > > +++ b/fs/nfsd/nfsctl.c > > @@ -1165,6 +1165,7 @@ static struct inode *nfsd_get_inode(struct super_block *sb, umode_t mode) > > inode->i_fop = &simple_dir_operations; > > inode->i_op = &simple_dir_inode_operations; > > inc_nlink(inode); > > + break; > > default: > > break; > > } > > -- > > 2.27.0 > > > > Acked-by: Chuck Lever Thanks, Chuck. -- Gustavo