From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE3B7C63697 for ; Mon, 23 Nov 2020 22:50:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 737F220717 for ; Mon, 23 Nov 2020 22:50:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="BQmknOSH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387501AbgKWWuc (ORCPT ); Mon, 23 Nov 2020 17:50:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:50608 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733091AbgKWWu2 (ORCPT ); Mon, 23 Nov 2020 17:50:28 -0500 Received: from embeddedor (187-162-31-110.static.axtel.net [187.162.31.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ADCB5206D8; Mon, 23 Nov 2020 22:50:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606171828; bh=prSunxx9UrmHQV1SVpB7IiA7MCaL2aW33t5lBC+FXKA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BQmknOSHEmt7Rd0eMahtV4W/mur0u5SqAY0dhDc4wY9bPXlbOhaybje85M8jyi19U gVbwMCmo1tzhA00+7O8fmx8Tjbj+s9maBHwdKgeO7wsRp0yFwAzUyuQKp+SlR+wlvD sfgh/KB+sWv6XqgFI9nmfUab9/Cu4VU96a02xDSU= Date: Mon, 23 Nov 2020 16:50:42 -0600 From: "Gustavo A. R. Silva" To: Guenter Roeck Cc: Wim Van Sebroeck , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 057/141] watchdog: Fix fall-through warnings for Clang Message-ID: <20201123225042.GO21644@embeddedor> References: <713aa26be06d50dd3bb582a3cb71f04787ad5d5b.1605896059.git.gustavoars@kernel.org> <20201121184951.GA114144@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201121184951.GA114144@roeck-us.net> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 21, 2020 at 10:49:51AM -0800, Guenter Roeck wrote: > On Fri, Nov 20, 2020 at 12:32:51PM -0600, Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > > by explicitly adding a fallthrough pseudo-keyword instead of letting the > > code fall through to the next case. > > > > Link: https://github.com/KSPP/linux/issues/115 > > Signed-off-by: Gustavo A. R. Silva > > --- > > drivers/watchdog/machzwd.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/watchdog/machzwd.c b/drivers/watchdog/machzwd.c > > index 743377c5b173..73f2221f6222 100644 > > --- a/drivers/watchdog/machzwd.c > > +++ b/drivers/watchdog/machzwd.c > > @@ -174,6 +174,7 @@ static inline void zf_set_timer(unsigned short new, unsigned char n) > > fallthrough; > > case WD2: > > zf_writeb(COUNTER_2, new > 0xff ? 0xff : new); > > + fallthrough; > > fallthrough to return ? Oh well, this is an old style driver anyway, > so I guess who cares. :) > Acked-by: Guenter Roeck Thanks, Guenter. -- Gustavo