From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5DDDC63777 for ; Tue, 24 Nov 2020 07:01:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 814CE2086A for ; Tue, 24 Nov 2020 07:01:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729540AbgKXHBD (ORCPT ); Tue, 24 Nov 2020 02:01:03 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:7972 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725786AbgKXHBD (ORCPT ); Tue, 24 Nov 2020 02:01:03 -0500 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4CgFKT5rJMzhf2r; Tue, 24 Nov 2020 15:00:45 +0800 (CST) Received: from euler.huawei.com (10.175.124.27) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.487.0; Tue, 24 Nov 2020 15:00:52 +0800 From: Wei Li To: Dominik Brodowski , Andrew Morton , "Peter Zijlstra (Intel)" , Olof Johansson CC: , Subject: [PATCH] drivers/pcmcia: Fix error return code in electra_cf_probe() Date: Tue, 24 Nov 2020 15:00:40 +0800 Message-ID: <20201124070040.3583-1-liwei391@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.124.27] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When it fails to call of_get_property(), it just jumps to 'fail1', while the 'status' which will be returned is not updated. Fixes: 2b571a066a2f ("pcmcia: CompactFlash driver for PA Semi Electra boards") Signed-off-by: Wei Li --- drivers/pcmcia/electra_cf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pcmcia/electra_cf.c b/drivers/pcmcia/electra_cf.c index 35158cfd9c1a..0570758e3fa8 100644 --- a/drivers/pcmcia/electra_cf.c +++ b/drivers/pcmcia/electra_cf.c @@ -228,6 +228,7 @@ static int electra_cf_probe(struct platform_device *ofdev) } cf->socket.pci_irq = cf->irq; + status = -ENODEV; prop = of_get_property(np, "card-detect-gpio", NULL); if (!prop) -- 2.17.1