All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Jianxin Xiong <jianxin.xiong@intel.com>
Cc: linux-rdma@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Doug Ledford <dledford@redhat.com>,
	Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
	Sumit Semwal <sumit.semwal@linaro.org>,
	Christian Koenig <christian.koenig@amd.com>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH v11 4/4] RDMA/mlx5: Support dma-buf based userspace memory region
Date: Tue, 24 Nov 2020 09:35:06 +0000	[thread overview]
Message-ID: <20201124093506.GC29715@infradead.org> (raw)
In-Reply-To: <1606153919-104513-5-git-send-email-jianxin.xiong@intel.com>

> +	if (umem->is_dmabuf)
> +		page_size = mlx5_umem_dmabuf_default_pgsz(umem, iova);
> +	else
> +		page_size = mlx5_umem_find_best_pgsz(umem, mkc, log_page_size, 0, iova);

Please avoid these overly long lines.

      reply	other threads:[~2020-11-24  9:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-23 17:51 [PATCH v11 0/4] RDMA: Add dma-buf support Jianxin Xiong
2020-11-23 17:51 ` Jianxin Xiong
2020-11-23 17:51 ` [PATCH v11 1/4] RDMA/umem: Support importing dma-buf as user memory region Jianxin Xiong
2020-11-23 17:51   ` Jianxin Xiong
2020-11-24  9:33   ` Christoph Hellwig
2020-11-24 18:24     ` Xiong, Jianxin
2020-11-24 18:24       ` Xiong, Jianxin
2020-11-24 18:33       ` Jason Gunthorpe
2020-11-24 18:33         ` Jason Gunthorpe
2020-11-23 17:51 ` [PATCH v11 2/4] RDMA/core: Add device method for registering dma-buf based " Jianxin Xiong
2020-11-23 17:51   ` Jianxin Xiong
2020-11-23 17:51 ` [PATCH v11 3/4] RDMA/uverbs: Add uverbs command for dma-buf based MR registration Jianxin Xiong
2020-11-23 17:51   ` Jianxin Xiong
2020-11-23 17:51 ` [PATCH v11 4/4] RDMA/mlx5: Support dma-buf based userspace memory region Jianxin Xiong
2020-11-23 17:51   ` Jianxin Xiong
2020-11-24  9:35   ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201124093506.GC29715@infradead.org \
    --to=hch@infradead.org \
    --cc=christian.koenig@amd.com \
    --cc=daniel.vetter@intel.com \
    --cc=dledford@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jgg@ziepe.ca \
    --cc=jianxin.xiong@intel.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sumit.semwal@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.