From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D29ECC64E7A for ; Tue, 24 Nov 2020 15:08:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F6F320738 for ; Tue, 24 Nov 2020 15:08:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="rDEZl2Wz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389579AbgKXPIz (ORCPT ); Tue, 24 Nov 2020 10:08:55 -0500 Received: from z5.mailgun.us ([104.130.96.5]:15926 "EHLO z5.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389459AbgKXPIy (ORCPT ); Tue, 24 Nov 2020 10:08:54 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1606230534; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=+JQsvyb2icbWmCQhERdftrZs+Pl9Bj+IJAJ1JKr1yN8=; b=rDEZl2Wz3uvwb1teno65cjh58RwaRsACTiz8hMtoVMHpOdd5bBX3b/bcxSxWBh93Lx1s6Igq ZtsUoYL0y0ino4hrjtIqnuhNIPW8A0SW93W+mSYfpuH3wfABrz0cxvt4mn/DL/DIw21PPbad BiKzRoDxWD1ijIY6QCRAeqZ9SJk= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-east-1.postgun.com with SMTP id 5fbd21fffa67d9becf801677 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 24 Nov 2020 15:08:47 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 08B8EC43460; Tue, 24 Nov 2020 15:08:47 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3AF7EC433ED; Tue, 24 Nov 2020 15:08:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3AF7EC433ED Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: cw1200: fix missing destroy_workqueue() on error in cw1200_init_common From: Kalle Valo In-Reply-To: <20201119070842.1011-1-miaoqinglang@huawei.com> References: <20201119070842.1011-1-miaoqinglang@huawei.com> To: Qinglang Miao Cc: Solomon Peachy , "David S. Miller" , Jakub Kicinski , , , , Qinglang Miao User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20201124150847.08B8EC43460@smtp.codeaurora.org> Date: Tue, 24 Nov 2020 15:08:47 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Qinglang Miao wrote: > Add the missing destroy_workqueue() before return from > cw1200_init_common in the error handling case. > > Fixes: a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets") > Reported-by: Hulk Robot > Signed-off-by: Qinglang Miao Patch applied to wireless-drivers-next.git, thanks. 7ec8a926188e cw1200: fix missing destroy_workqueue() on error in cw1200_init_common -- https://patchwork.kernel.org/project/linux-wireless/patch/20201119070842.1011-1-miaoqinglang@huawei.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches