Hi Suganath, I love your patch! Perhaps something to improve: [auto build test WARNING on scsi/for-next] [also build test WARNING on mkp-scsi/for-next v5.10-rc5 next-20201123] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Suganath-Prabu-S/mpt3sas-Features-to-enhance-driver-debugging/20201124-115842 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next config: x86_64-rhel (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/d13faa942966ed911558ffa9c1fb021847f72632 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Suganath-Prabu-S/mpt3sas-Features-to-enhance-driver-debugging/20201124-115842 git checkout d13faa942966ed911558ffa9c1fb021847f72632 # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/scsi/mpt3sas/mpt3sas_config.c:1793:1: warning: no previous prototype for '_config_set_driver_trigger_pg0' [-Wmissing-prototypes] 1793 | _config_set_driver_trigger_pg0(struct MPT3SAS_ADAPTER *ioc, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/mpt3sas/mpt3sas_config.c:1835:1: warning: no previous prototype for 'mpt3sas_config_update_driver_trigger_pg0' [-Wmissing-prototypes] 1835 | mpt3sas_config_update_driver_trigger_pg0(struct MPT3SAS_ADAPTER *ioc, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/mpt3sas/mpt3sas_config.c:1927:1: warning: no previous prototype for '_config_set_driver_trigger_pg1' [-Wmissing-prototypes] 1927 | _config_set_driver_trigger_pg1(struct MPT3SAS_ADAPTER *ioc, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/mpt3sas/mpt3sas_config.c:1969:1: warning: no previous prototype for 'mpt3sas_config_update_driver_trigger_pg1' [-Wmissing-prototypes] 1969 | mpt3sas_config_update_driver_trigger_pg1(struct MPT3SAS_ADAPTER *ioc, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/mpt3sas/mpt3sas_config.c:2078:1: warning: no previous prototype for '_config_set_driver_trigger_pg2' [-Wmissing-prototypes] 2078 | _config_set_driver_trigger_pg2(struct MPT3SAS_ADAPTER *ioc, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/mpt3sas/mpt3sas_config.c:2120:1: warning: no previous prototype for 'mpt3sas_config_update_driver_trigger_pg2' [-Wmissing-prototypes] 2120 | mpt3sas_config_update_driver_trigger_pg2(struct MPT3SAS_ADAPTER *ioc, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/mpt3sas/mpt3sas_config.c:2238:1: warning: no previous prototype for '_config_set_driver_trigger_pg3' [-Wmissing-prototypes] 2238 | _config_set_driver_trigger_pg3(struct MPT3SAS_ADAPTER *ioc, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/mpt3sas/mpt3sas_config.c:2280:1: warning: no previous prototype for 'mpt3sas_config_update_driver_trigger_pg3' [-Wmissing-prototypes] 2280 | mpt3sas_config_update_driver_trigger_pg3(struct MPT3SAS_ADAPTER *ioc, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/scsi/mpt3sas/mpt3sas_config.c:2395:1: warning: no previous prototype for '_config_set_driver_trigger_pg4' [-Wmissing-prototypes] 2395 | _config_set_driver_trigger_pg4(struct MPT3SAS_ADAPTER *ioc, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/mpt3sas/mpt3sas_config.c:2437:1: warning: no previous prototype for 'mpt3sas_config_update_driver_trigger_pg4' [-Wmissing-prototypes] 2437 | mpt3sas_config_update_driver_trigger_pg4(struct MPT3SAS_ADAPTER *ioc, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +/_config_set_driver_trigger_pg4 +2395 drivers/scsi/mpt3sas/mpt3sas_config.c 2384 2385 /** 2386 * mpt3sas_config_set_driver_trigger_pg4 - write driver trigger page 4 2387 * @ioc: per adapter object 2388 * @mpi_reply: reply mf payload returned from firmware 2389 * @config_page: contents of the config page 2390 * Context: sleep. 2391 * 2392 * Returns 0 for success, non-zero for failure. 2393 */ 2394 int > 2395 _config_set_driver_trigger_pg4(struct MPT3SAS_ADAPTER *ioc, 2396 Mpi2ConfigReply_t *mpi_reply, Mpi26DriverTriggerPage4_t *config_page) 2397 { 2398 Mpi2ConfigRequest_t mpi_request; 2399 int r; 2400 2401 memset(&mpi_request, 0, sizeof(Mpi2ConfigRequest_t)); 2402 mpi_request.Function = MPI2_FUNCTION_CONFIG; 2403 mpi_request.Action = MPI2_CONFIG_ACTION_PAGE_HEADER; 2404 mpi_request.Header.PageType = MPI2_CONFIG_PAGETYPE_EXTENDED; 2405 mpi_request.ExtPageType = 2406 MPI2_CONFIG_EXTPAGETYPE_DRIVER_PERSISTENT_TRIGGER; 2407 mpi_request.Header.PageNumber = 4; 2408 mpi_request.Header.PageVersion = MPI26_DRIVER_TRIGGER_PAGE4_PAGEVERSION; 2409 ioc->build_zero_len_sge_mpi(ioc, &mpi_request.PageBufferSGE); 2410 r = _config_request(ioc, &mpi_request, mpi_reply, 2411 MPT3_CONFIG_PAGE_DEFAULT_TIMEOUT, NULL, 0); 2412 if (r) 2413 goto out; 2414 2415 mpi_request.Action = MPI2_CONFIG_ACTION_PAGE_WRITE_CURRENT; 2416 _config_request(ioc, &mpi_request, mpi_reply, 2417 MPT3_CONFIG_PAGE_DEFAULT_TIMEOUT, config_page, 2418 sizeof(*config_page)); 2419 mpi_request.Action = MPI2_CONFIG_ACTION_PAGE_WRITE_NVRAM; 2420 r = _config_request(ioc, &mpi_request, mpi_reply, 2421 MPT3_CONFIG_PAGE_DEFAULT_TIMEOUT, config_page, 2422 sizeof(*config_page)); 2423 out: 2424 return r; 2425 } 2426 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org