From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F315C63798 for ; Wed, 25 Nov 2020 04:43:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0171E208B8 for ; Wed, 25 Nov 2020 04:43:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="u+gTAkG7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727905AbgKYEnR (ORCPT ); Tue, 24 Nov 2020 23:43:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725817AbgKYEnQ (ORCPT ); Tue, 24 Nov 2020 23:43:16 -0500 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E737BC0613D4; Tue, 24 Nov 2020 20:43:03 -0800 (PST) Received: by mail-pg1-x544.google.com with SMTP id l17so1288723pgk.1; Tue, 24 Nov 2020 20:43:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WgwvIE+SYJNhqADKQZurakSjkdWc52Z6zNoc9HGWK/E=; b=u+gTAkG7TRnXQQyxFbV4O/o++vcK3Je5QsfaGcBDaaDf1H+hl1GwQhy8MMHAb3SPzq H06w+2QpAjMOQR+6E+yK189WGcRtUQj7fUDFSm+SIqqENspIReOTxNAy0mflASfMfsK1 IH0Lqjo3GsJweS/gfEMGJn177FF6XlIhrI73BLExxDkvQjcs1ebYtklrKk9ueB5GSBZZ soBOKjVvCp+iM32y0xjIM8OfwHLpwuEwxnJRfTBxs4h/S2KdLfM5NxavMldYPzHt/z/5 2NRtuONGmq3A1SgSE+F4Q8en3KPvpH7otic+cKDltC/gylbtEMTO4uFU//G+sedbHSPw uvqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WgwvIE+SYJNhqADKQZurakSjkdWc52Z6zNoc9HGWK/E=; b=cBUBiVJYw/z5y8A/9Q78DP6n5uRb1wq5UbcZ+Yu7zew/SDlKuzGcl4Cox9Spp72cri JMGL3tqvKqYq+wveGHrKS7K8Rffglxoy6ywYiyjzFYi5AWviJ1RXYQZI+QEGS7tQWSgm 93eIWWe46zwq8DgMXOajIBmRUWAA8L7e/xTey7HzS6zQlQUGuKKVjYMpOLls+7x0J+G+ +beXspUjvpZW9YwQic8fZQkCo2oHu3Nv6USgZlbSC29p8kqsVBtyldjsTiCwA4a3mVL7 eoH3MFZE3vBR8GrtKG7Buif+NfaH9K6GCbM9rf7Br2TT3TkAK4sQ2vURcqKnUl9lNP0Y lxIA== X-Gm-Message-State: AOAM532IqBUdkndrp4iQ3ptgJdZDW5GxeOzF8GXvyfaIRJT0n85EFd1J Y9XfVotB3fTgyTb6M8170GM= X-Google-Smtp-Source: ABdhPJwpT35k8tzGkp7unYNbt9QDIr3R8n8s1F35Y7VWvmB6cP19Xflh8P7ICspTdg9F8JP2GuZ2uw== X-Received: by 2002:a62:864a:0:b029:197:ad58:4184 with SMTP id x71-20020a62864a0000b0290197ad584184mr932183pfd.55.1606279383324; Tue, 24 Nov 2020 20:43:03 -0800 (PST) Received: from f3 (ag097173.dynamic.ppp.asahi-net.or.jp. [157.107.97.173]) by smtp.gmail.com with ESMTPSA id j10sm830146pji.29.2020.11.24.20.43.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 20:43:02 -0800 (PST) Date: Wed, 25 Nov 2020 13:42:57 +0900 From: Benjamin Poirier To: "Gustavo A. R. Silva" Cc: Manish Chopra , Greg Kroah-Hartman , GR-Linux-NIC-Dev@marvell.com, netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 127/141] staging: qlge: Fix fall-through warnings for Clang Message-ID: <20201125044257.GA142382@f3> References: <673bd9f27bcc2df8c9d12be94f54001d8066d4ab.1605896060.git.gustavoars@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <673bd9f27bcc2df8c9d12be94f54001d8066d4ab.1605896060.git.gustavoars@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-11-20 12:39 -0600, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva > --- > drivers/staging/qlge/qlge_main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c > index 27da386f9d87..c41b1373dcf8 100644 > --- a/drivers/staging/qlge/qlge_main.c > +++ b/drivers/staging/qlge/qlge_main.c > @@ -1385,6 +1385,7 @@ static void ql_categorize_rx_err(struct ql_adapter *qdev, u8 rx_err, > break; > case IB_MAC_IOCB_RSP_ERR_CRC: > stats->rx_crc_err++; > + break; > default: > break; > } In this instance, it think it would be more appropriate to remove the "default" case. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C55EEC63777 for ; Wed, 25 Nov 2020 04:43:11 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 21791208B8 for ; Wed, 25 Nov 2020 04:43:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="u+gTAkG7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21791208B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 3CB6D27400; Wed, 25 Nov 2020 04:43:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dXQln9K1-lRx; Wed, 25 Nov 2020 04:43:06 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 17F9C273A9; Wed, 25 Nov 2020 04:43:06 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 701B91BF5AC for ; Wed, 25 Nov 2020 04:43:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 63B88873CE for ; Wed, 25 Nov 2020 04:43:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w71IMkOYOCvM for ; Wed, 25 Nov 2020 04:43:03 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by hemlock.osuosl.org (Postfix) with ESMTPS id C3E90873CA for ; Wed, 25 Nov 2020 04:43:03 +0000 (UTC) Received: by mail-pg1-f194.google.com with SMTP id 81so1292819pgf.0 for ; Tue, 24 Nov 2020 20:43:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WgwvIE+SYJNhqADKQZurakSjkdWc52Z6zNoc9HGWK/E=; b=u+gTAkG7TRnXQQyxFbV4O/o++vcK3Je5QsfaGcBDaaDf1H+hl1GwQhy8MMHAb3SPzq H06w+2QpAjMOQR+6E+yK189WGcRtUQj7fUDFSm+SIqqENspIReOTxNAy0mflASfMfsK1 IH0Lqjo3GsJweS/gfEMGJn177FF6XlIhrI73BLExxDkvQjcs1ebYtklrKk9ueB5GSBZZ soBOKjVvCp+iM32y0xjIM8OfwHLpwuEwxnJRfTBxs4h/S2KdLfM5NxavMldYPzHt/z/5 2NRtuONGmq3A1SgSE+F4Q8en3KPvpH7otic+cKDltC/gylbtEMTO4uFU//G+sedbHSPw uvqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WgwvIE+SYJNhqADKQZurakSjkdWc52Z6zNoc9HGWK/E=; b=rZG+QOgBaaUOyIax3IYLAllNReecYCNBzhzksjl2vnSdjAAU6k3rWhFm1sVB7BRk+T SxDkHix4xSI7xXJ82LVKCSK98ItxkXnvZ6h/OBaOCb+Hs6imUOByP4jlxGFdKOe8EQ2V KMgD8uvq6D4LHYsGh+BeI6ZC+BIbYP0j8tipl9Isj23sEcDX34QEmSzDm1WAiig4sz3e 4Rmv7WpzFoQGZJMkEsstjDrqVojwvkz3pdRT5vJ3goMi74EJjKnOFIayP9PmtVLiVKXl uUziX+fMQrrIysFNa6/gNjKJqxSm4O7QQb8w3IenvV7oGW8lbqLT71aTyyzbTVIMnQjj DRvQ== X-Gm-Message-State: AOAM531RH7MslgxqnlcLNbfztZakeLSGOMJBPY1q80LMaFvsi+07xRXx 9uRqnngK3Z9BaTe1EQ28J8M= X-Google-Smtp-Source: ABdhPJwpT35k8tzGkp7unYNbt9QDIr3R8n8s1F35Y7VWvmB6cP19Xflh8P7ICspTdg9F8JP2GuZ2uw== X-Received: by 2002:a62:864a:0:b029:197:ad58:4184 with SMTP id x71-20020a62864a0000b0290197ad584184mr932183pfd.55.1606279383324; Tue, 24 Nov 2020 20:43:03 -0800 (PST) Received: from f3 (ag097173.dynamic.ppp.asahi-net.or.jp. [157.107.97.173]) by smtp.gmail.com with ESMTPSA id j10sm830146pji.29.2020.11.24.20.43.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 20:43:02 -0800 (PST) Date: Wed, 25 Nov 2020 13:42:57 +0900 From: Benjamin Poirier To: "Gustavo A. R. Silva" Subject: Re: [PATCH 127/141] staging: qlge: Fix fall-through warnings for Clang Message-ID: <20201125044257.GA142382@f3> References: <673bd9f27bcc2df8c9d12be94f54001d8066d4ab.1605896060.git.gustavoars@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <673bd9f27bcc2df8c9d12be94f54001d8066d4ab.1605896060.git.gustavoars@kernel.org> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, GR-Linux-NIC-Dev@marvell.com, Manish Chopra , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, netdev@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On 2020-11-20 12:39 -0600, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva > --- > drivers/staging/qlge/qlge_main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c > index 27da386f9d87..c41b1373dcf8 100644 > --- a/drivers/staging/qlge/qlge_main.c > +++ b/drivers/staging/qlge/qlge_main.c > @@ -1385,6 +1385,7 @@ static void ql_categorize_rx_err(struct ql_adapter *qdev, u8 rx_err, > break; > case IB_MAC_IOCB_RSP_ERR_CRC: > stats->rx_crc_err++; > + break; > default: > break; > } In this instance, it think it would be more appropriate to remove the "default" case. _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel