From: Vincent Whitchurch <vincent.whitchurch@axis.com>
To: Adam Ward <adam.ward@diasemi.com>
Cc: Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/9] regulator: Update DA9121 dt-bindings
Date: Wed, 25 Nov 2020 10:21:37 +0100 [thread overview]
Message-ID: <20201125092137.ehwfytsrr3x5vkiy@axis.com> (raw)
In-Reply-To: <20201120134742.y7bocaok3gcahbxt@axis.com>
On Fri, Nov 20, 2020 at 02:47:42PM +0100, Vincent Whitchurch wrote:
> On Fri, Nov 20, 2020 at 01:14:50PM +0100, Adam Ward wrote:
> > - buck1:
> > - description:
> > - Initial data for the Buck1 regulator.
> > - $ref: "regulator.yaml#"
> > + interrupt-parent:
> > + maxItems: 1
> > + description: Specifies the reference to the interrupt controller.
> > +
> > + interrupts:
> > + maxItems: 1
> > + description: IRQ line information.
> > +
> > + dlg,irq-polling-delay-passive:
> > + maxItems: 1
> > + description: |
> > + Specify the polling period, measured in milliseconds, between interrupt status
> > + update checks. Range 1000-10000 ms.
> > +
> > + regulators:
> > type: object
> > + $ref: regulator.yaml#
> > + description: |
> > + This node defines the settings for the BUCK. The content of the
> > + sub-node is defined by the standard binding for regulators; see regulator.yaml.
> > + The DA9121 regulator is bound using their names listed below
> > + buck1 - BUCK1
> > + buck2 - BUCK2 //DA9122, DA9220, DA9131, DA9132 only
>
> This move to a sub-node means that older devicetrees won't work. I
> assume that's fine since the driver is only in linux-next at the moment,
> but perhaps it's worth mentioning this in the commit message?
Actually, perhaps I'm missing something, but I don't quite see why this
move to a sub-node is needed. There is some flexibility in the
regulator framework for this as I noted earlier
(https://lore.kernel.org/lkml/20201102154848.tm5nsydaukyd7rrw@axis.com/).
For the case of an MFD it certainly makes sense to have a "regulators"
sub-node but for these chips it seems rather redundant.
Also, perhaps you could split this patch into logical pieces too as Mark
has suggested for some of the other patches in this series?
next prev parent reply other threads:[~2020-11-25 9:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 12:14 [PATCH 0/9] regulator: da9121: extend support to variants, add features Adam Ward
2020-11-20 12:14 ` [PATCH 1/9] regulator: Update DA9121 dt-bindings Adam Ward
2020-11-20 13:47 ` Vincent Whitchurch
2020-11-25 9:21 ` Vincent Whitchurch [this message]
2020-11-27 13:01 ` Adam Ward
2020-11-27 14:59 ` Mark Brown
2020-11-20 12:14 ` [PATCH 2/9] regulator: da9121: Add header file Adam Ward
2020-11-20 12:14 ` [PATCH 3/9] regulator: da9121: Add device variants Adam Ward
2020-11-20 12:14 ` [PATCH 4/9] regulator: da9121: Add device variant details and respective regmaps Adam Ward
2020-11-20 12:45 ` Mark Brown
2020-11-20 12:14 ` [PATCH 5/9] regulator: da9121: Add support for device variants via devicetree Adam Ward
2020-11-20 12:51 ` Mark Brown
2020-11-20 12:14 ` [PATCH 6/9] regulator: da9121: Update registration to support multiple buck variants Adam Ward
2020-11-20 13:06 ` Mark Brown
2020-11-20 12:14 ` [PATCH 7/9] regulator: da9121: add current support Adam Ward
2020-11-20 13:17 ` Mark Brown
2020-11-20 12:14 ` [PATCH 8/9] regulator: da9121: add mode support Adam Ward
2020-11-20 12:14 ` [PATCH 9/9] regulator: da9121: add interrupt support Adam Ward
2020-11-20 13:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201125092137.ehwfytsrr3x5vkiy@axis.com \
--to=vincent.whitchurch@axis.com \
--cc=adam.ward@diasemi.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.