From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6303BC5519F for ; Wed, 25 Nov 2020 13:34:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD159206E5 for ; Wed, 25 Nov 2020 13:34:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CGAUoJEm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD159206E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42298 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khuwF-0003CA-E3 for qemu-devel@archiver.kernel.org; Wed, 25 Nov 2020 08:34:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43612) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khuus-0001zV-Uh for qemu-devel@nongnu.org; Wed, 25 Nov 2020 08:33:03 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:59457) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1khuuq-0002yG-3I for qemu-devel@nongnu.org; Wed, 25 Nov 2020 08:33:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606311177; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BMonAe3cabz8+rLp09CIpfOlD+YpM14UG/ZLjHJTNSE=; b=CGAUoJEmjy9lZ5hnTF2OjdOK0fHk9PqYZv7sh6KmdHfMzQ/ocItD8ukqlQWfsx64l5LH2W A9GhajsGfYVciHUnfbuL9MEC5Y93KLvCl0WCT/igWMhTCQeF9Ewjd8ncA990EANYY613g8 NUVhToejFMG/jM/qoen+Tfqtl3w3J64= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-83-WfQ9J5EiMcecuWEG6wceEQ-1; Wed, 25 Nov 2020 08:32:53 -0500 X-MC-Unique: WfQ9J5EiMcecuWEG6wceEQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 98335107ACE3; Wed, 25 Nov 2020 13:32:52 +0000 (UTC) Received: from localhost (ovpn-114-98.ams2.redhat.com [10.36.114.98]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2E5A360854; Wed, 25 Nov 2020 13:32:52 +0000 (UTC) Date: Wed, 25 Nov 2020 13:32:51 +0000 From: "Richard W.M. Jones" To: Antoine Damhet Subject: Re: [DISCUSSION] Allow ACPI default OEM ID and OEM table ID fields to be set. Message-ID: <20201125133251.GI30079@redhat.com> References: <20201125132711.jqb7znxu5jpoanwi@tartarus> MIME-Version: 1.0 In-Reply-To: <20201125132711.jqb7znxu5jpoanwi@tartarus> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=rjones@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=rjones@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Igor Mammedov , qemu-devel@nongnu.org, "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Nov 25, 2020 at 02:27:11PM +0100, Antoine Damhet wrote: > Hello, > > We recently found out that some softwares are effectively crashing > when they detect qemu's `OEM ID` or `OEM table ID` in the ACPI tables. > > I see no reason not to expose the setting to the user/command-line. A > previous patch has been submitted in 2015[1] but did not get through > because (if I understand correctly) using the IDs on the `SLIC`, `BXPC` > and `RSDT` tables were enough at the time. > > If you agree, I am willing to forward port the patches of M. Jones but I > need to ask how it would work `Signed-Off`-wise ? On this point, the patch I sent was actually written by Michael Tokarev, I was only trying to get them upstream. Rich. > Thanks in advance for your time, > > PS: the softwares will crash if the signature is found in any of the > exposed tables. > > [1]: https://lore.kernel.org/qemu-devel/1441220618-4750-1-git-send-email-rjones@redhat.com/ > > -- > Antoine 'xdbob' Damhet -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v