From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 502C6C6379D for ; Wed, 25 Nov 2020 21:35:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E8495206E0 for ; Wed, 25 Nov 2020 21:35:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="itRkywL7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732509AbgKYVeq (ORCPT ); Wed, 25 Nov 2020 16:34:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:59380 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731950AbgKYVeq (ORCPT ); Wed, 25 Nov 2020 16:34:46 -0500 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8FA06206E0; Wed, 25 Nov 2020 21:34:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606340086; bh=3lVrLTTsCdkal7E8HZY0NZKVZlVawWDZoX8smDNr+OU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=itRkywL78OBNGH52rhDRkPoFkhM3SRjKqcUj37jk1l+Ecdj83u88Pt4/wAxr0+wq6 hu4Ps/mY1fYVxNvdzw8GiZgYjq4BngFEhtGk9scnsLM7qmAfjQ6Je3pNpYd8RrAaVz es3lIG3e/2qvKxpWP7vEm848nIIQvEGFFMCZM5LM= Date: Wed, 25 Nov 2020 13:34:44 -0800 From: Jakub Kicinski To: Horatiu Vultur Cc: , , , , , Subject: Re: [PATCH net-next v2] bridge: mrp: Implement LC mode for MRP Message-ID: <20201125133444.22f09660@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201124082525.273820-1-horatiu.vultur@microchip.com> References: <20201124082525.273820-1-horatiu.vultur@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Nov 2020 09:25:25 +0100 Horatiu Vultur wrote: > Extend MRP to support LC mode(link check) for the interconnect port. > This applies only to the interconnect ring. > > Opposite to RC mode(ring check) the LC mode is using CFM frames to > detect when the link goes up or down and based on that the userspace > will need to react. > One advantage of the LC mode over RC mode is that there will be fewer > frames in the normal rings. Because RC mode generates InTest on all > ports while LC mode sends CFM frame only on the interconnect port. > > All 4 nodes part of the interconnect ring needs to have the same mode. > And it is not possible to have running LC and RC mode at the same time > on a node. > > Whenever the MIM starts it needs to detect the status of the other 3 > nodes in the interconnect ring so it would send a frame called > InLinkStatus, on which the clients needs to reply with their link > status. > > This patch adds InLinkStatus frame type and extends existing rules on > how to forward this frame. > > Acked-by: Nikolay Aleksandrov > Signed-off-by: Horatiu Vultur Applied, thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606340086; bh=3lVrLTTsCdkal7E8HZY0NZKVZlVawWDZoX8smDNr+OU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=itRkywL78OBNGH52rhDRkPoFkhM3SRjKqcUj37jk1l+Ecdj83u88Pt4/wAxr0+wq6 hu4Ps/mY1fYVxNvdzw8GiZgYjq4BngFEhtGk9scnsLM7qmAfjQ6Je3pNpYd8RrAaVz es3lIG3e/2qvKxpWP7vEm848nIIQvEGFFMCZM5LM= Date: Wed, 25 Nov 2020 13:34:44 -0800 From: Jakub Kicinski Message-ID: <20201125133444.22f09660@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201124082525.273820-1-horatiu.vultur@microchip.com> References: <20201124082525.273820-1-horatiu.vultur@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH net-next v2] bridge: mrp: Implement LC mode for MRP List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Horatiu Vultur Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, nikolay@nvidia.com, roopa@nvidia.com, davem@davemloft.net On Tue, 24 Nov 2020 09:25:25 +0100 Horatiu Vultur wrote: > Extend MRP to support LC mode(link check) for the interconnect port. > This applies only to the interconnect ring. > > Opposite to RC mode(ring check) the LC mode is using CFM frames to > detect when the link goes up or down and based on that the userspace > will need to react. > One advantage of the LC mode over RC mode is that there will be fewer > frames in the normal rings. Because RC mode generates InTest on all > ports while LC mode sends CFM frame only on the interconnect port. > > All 4 nodes part of the interconnect ring needs to have the same mode. > And it is not possible to have running LC and RC mode at the same time > on a node. > > Whenever the MIM starts it needs to detect the status of the other 3 > nodes in the interconnect ring so it would send a frame called > InLinkStatus, on which the clients needs to reply with their link > status. > > This patch adds InLinkStatus frame type and extends existing rules on > how to forward this frame. > > Acked-by: Nikolay Aleksandrov > Signed-off-by: Horatiu Vultur Applied, thanks!