From: Doug Evans via <qemu-devel@nongnu.org>
To: qemu-devel@nongnu.org
Cc: stefanha@redhat.com, Doug Evans <dje@google.com>
Subject: [PATCH 1/1] trace: Send "-d trace:help" output to stdout
Date: Wed, 25 Nov 2020 13:52:45 -0800 [thread overview]
Message-ID: <20201125215245.3514695-1-dje@google.com> (raw)
... for consistency with "-d help".
Signed-off-by: Doug Evans <dje@google.com>
---
trace/control.c | 12 ++++++------
trace/control.h | 3 ++-
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/trace/control.c b/trace/control.c
index b82fb87316..cd04dd4e0c 100644
--- a/trace/control.c
+++ b/trace/control.c
@@ -125,18 +125,18 @@ TraceEvent *trace_event_iter_next(TraceEventIter *iter)
return NULL;
}
-void trace_list_events(void)
+void trace_list_events(FILE *f)
{
TraceEventIter iter;
TraceEvent *ev;
trace_event_iter_init(&iter, NULL);
while ((ev = trace_event_iter_next(&iter)) != NULL) {
- fprintf(stderr, "%s\n", trace_event_get_name(ev));
+ fprintf(f, "%s\n", trace_event_get_name(ev));
}
#ifdef CONFIG_TRACE_DTRACE
- fprintf(stderr, "This list of names of trace points may be incomplete "
- "when using the DTrace/SystemTap backends.\n"
- "Run 'qemu-trace-stap list %s' to print the full list.\n",
+ fprintf(f, "This list of names of trace points may be incomplete "
+ "when using the DTrace/SystemTap backends.\n"
+ "Run 'qemu-trace-stap list %s' to print the full list.\n",
error_get_progname());
#endif
}
@@ -176,7 +176,7 @@ static void do_trace_enable_events(const char *line_buf)
void trace_enable_events(const char *line_buf)
{
if (is_help_option(line_buf)) {
- trace_list_events();
+ trace_list_events(stdout);
if (monitor_cur() == NULL) {
exit(0);
}
diff --git a/trace/control.h b/trace/control.h
index 05b95ea453..9522a7b318 100644
--- a/trace/control.h
+++ b/trace/control.h
@@ -201,10 +201,11 @@ void trace_fini_vcpu(CPUState *vcpu);
/**
* trace_list_events:
+ * @f: Where to send output.
*
* List all available events.
*/
-void trace_list_events(void);
+void trace_list_events(FILE *f);
/**
* trace_enable_events:
--
2.29.2.454.gaff20da3a2-goog
next reply other threads:[~2020-11-25 21:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 21:52 Doug Evans via [this message]
2020-12-10 11:25 ` [PATCH 1/1] trace: Send "-d trace:help" output to stdout Stefan Hajnoczi
2020-12-10 11:30 ` Philippe Mathieu-Daudé
2020-12-11 21:55 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201125215245.3514695-1-dje@google.com \
--to=qemu-devel@nongnu.org \
--cc=dje@google.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.