From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95CE8C63777 for ; Thu, 26 Nov 2020 08:08:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C34A21D91 for ; Thu, 26 Nov 2020 08:08:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388656AbgKZIHx convert rfc822-to-8bit (ORCPT ); Thu, 26 Nov 2020 03:07:53 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:37720 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731457AbgKZIHx (ORCPT ); Thu, 26 Nov 2020 03:07:53 -0500 Received: by mail-wm1-f68.google.com with SMTP id h21so1403260wmb.2; Thu, 26 Nov 2020 00:07:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=touMMcxtN/klkfBzKGmR1GBeAIVZ5Q/OLb3bh+krvqw=; b=NHyfvK522HWNvxhnu8Aarb9k8q6E2+cvlxOlnssQJCf9zByQoDDjk8Kow9yB52g+tY 67Vz98N/Fr6WlrKgEMGhvd8ycppwakmbAziMNnCpLJKYztehM1Ckt40jcVVg69zh6gG/ v13lYTN59tCKCWL8qlZPl8skLijJ4HJe7rYZJaL1VMoUnA/e4sbtUckIkkc5xGdyeTax v+n/6QMd0agzdlpGRMrVF2P5bfoWEQmIEuiPUwTs5lSmJoAElDWZQEu+lSLdyY7mhMJn 4DusXsnrTtnRAgYNds1uffJFlc+8QuUTn1lct0dfo/3dsCZJIXZHJsgwaX3m3gkpwkcb iWhA== X-Gm-Message-State: AOAM531D7SCvCXfLyVsRnSwivQ30CJU6NMEOG8aAi2vSWS1PKD4IwrUv fxEyB2dlXKH8BzjnAp3kGKM= X-Google-Smtp-Source: ABdhPJzBZ1+fYZhFRhcMpM8OBTLLHSNQoiR0ERzA+nGZZF28v4RH7uHopmtNRsmR6Xp2Medar4MN8Q== X-Received: by 2002:a1c:4e0f:: with SMTP id g15mr1927617wmh.160.1606378071210; Thu, 26 Nov 2020 00:07:51 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id v20sm6904441wmh.44.2020.11.26.00.07.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 00:07:50 -0800 (PST) Date: Thu, 26 Nov 2020 09:07:48 +0100 From: Krzysztof Kozlowski To: Alice Guo Cc: Adam Ford , "shawnguo@kernel.org" , devicetree , Peng Fan , Sascha Hauer , Linux Kernel Mailing List , Rob Herring , dl-linux-imx , arm-soc Subject: Re: [PATCH v6 4/4] soc: imx8m: change to use platform driver Message-ID: <20201126080748.GC4347@kozik-lap> References: <20201124015949.29262-1-alice.guo@nxp.com> <20201124015949.29262-4-alice.guo@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 26, 2020 at 02:15:35AM +0000, Alice Guo wrote: > > > > -----Original Message----- > > From: linux-arm-kernel On > > Behalf Of Adam Ford > > Sent: 2020年11月25日 8:45 > > To: Alice Guo > > Cc: devicetree ; Peng Fan ; > > Sascha Hauer ; Linux Kernel Mailing List > > ; Krzysztof Kozlowski ; Rob > > Herring ; dl-linux-imx ; Shawn Guo > > ; arm-soc > > Subject: Re: [PATCH v6 4/4] soc: imx8m: change to use platform driver > > > > On Mon, Nov 23, 2020 at 8:04 PM Alice Guo wrote: > > > > > > Directly reading ocotp register depends on that bootloader enables > > > ocotp clk, which is not always effective, so change to use nvmem API. > > > Using nvmem API requires to support driver defer probe and thus change > > > soc-imx8m.c to use platform driver. > > > > > > The other reason is that directly reading ocotp register causes kexec > > > kernel hang because the 1st kernel running will disable unused clks > > > after kernel boots up, and then ocotp clk will be disabled even if > > > bootloader enables it. When kexec kernel, ocotp clk needs to be > > > enabled before reading ocotp registers, and nvmem API with platform > > > driver supported can accomplish this. > > > > > > Signed-off-by: Alice Guo > > > --- > > > > > The patch reads V6, but the change log only shows V2. Can you elaborate on > > what has changed between V2 and V6? > > > > adam > > Hi, > > Sorry. The order of changlog is reversed. Thank Adam for pointing out the problem, and thank Krzysztof for reviewing my patch. > Do I need to resend the patchset with the correct changelog order? No, no need. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AF73C56202 for ; Thu, 26 Nov 2020 08:09:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A637A20857 for ; Thu, 26 Nov 2020 08:09:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YJgFh8Mr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A637A20857 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kKmsvaqSOzGw99f5+ZVs3FFzV+3sBwnjS3UTsg+ah5s=; b=YJgFh8MrpF8cZfp6nbS57ryfj IXoM9vts0+IDOEusbLbFqFYTOGm89FXFho+RN7jFBowyyGHjDZ2wlhM7M7ZDn1lrJ7rbuGPFDkbqp Orf/0ME5OALp2JMkPboj8vZvueK9Z9+WKsC3yol9fEFqBQypubGqh+IOaMwJFVrXL3Hb+T6XCt0qj K/1zPDGxHYL4xHDHEFZ6nuVrLiQMv9g6kW7OyAc0Fzr33heOEvdOM23ZyctsNuOmsxMf2WdOY+K3H 8zUfoxrlfUV4p7vCFhus8WH7jNB/8avkE41NWPX8ylW1b8pkLhWwImOnK+B/3O7O00zsibwmeF7Ij sJgw4dyTg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiCJn-0006Wk-Nj; Thu, 26 Nov 2020 08:07:55 +0000 Received: from mail-wm1-f65.google.com ([209.85.128.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiCJk-0006Vt-Ou for linux-arm-kernel@lists.infradead.org; Thu, 26 Nov 2020 08:07:53 +0000 Received: by mail-wm1-f65.google.com with SMTP id s13so1395307wmh.4 for ; Thu, 26 Nov 2020 00:07:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=touMMcxtN/klkfBzKGmR1GBeAIVZ5Q/OLb3bh+krvqw=; b=dCK3j5iuAmq6TqD4Wsy+9A8O6sNpq+wjl0b9hpA41NdJ6RyC4ItJdyECe6VageWnYp xf4IjZouLOGCY8Sc9kSQb7GTDI0q+8WgyS8xEVcltCORLHOL54BhhCOBAOiwj/yf7HZO SBU2aDI4G/kO5GECT4rscW19L8lkPRrIAUnzQiPeUPB4JsVMFtYOuzJXMdFdU5rLt3j7 lxoaNSP8ygZbgZZkM2IXb5HrZW08AF5fhiSywa5+mnwbjiXuRw7elpoXoib8/Z85hxLq GsfIDfBg6NafgPGD4OwXF+idJxpRZpqwymXiGdpTv4uFijgah838WhsDBuisPoyRZooM o02w== X-Gm-Message-State: AOAM530eHnpMcdi/216PIXZzY9w5bEp7qmEBQbEJflx4ugs7anAvEMtC ydBkfSqXmKRK8oytrU/yYIw= X-Google-Smtp-Source: ABdhPJzBZ1+fYZhFRhcMpM8OBTLLHSNQoiR0ERzA+nGZZF28v4RH7uHopmtNRsmR6Xp2Medar4MN8Q== X-Received: by 2002:a1c:4e0f:: with SMTP id g15mr1927617wmh.160.1606378071210; Thu, 26 Nov 2020 00:07:51 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id v20sm6904441wmh.44.2020.11.26.00.07.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 00:07:50 -0800 (PST) Date: Thu, 26 Nov 2020 09:07:48 +0100 From: Krzysztof Kozlowski To: Alice Guo Subject: Re: [PATCH v6 4/4] soc: imx8m: change to use platform driver Message-ID: <20201126080748.GC4347@kozik-lap> References: <20201124015949.29262-1-alice.guo@nxp.com> <20201124015949.29262-4-alice.guo@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201126_030752_858479_6397679E X-CRM114-Status: GOOD ( 22.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Peng Fan , Adam Ford , Sascha Hauer , Linux Kernel Mailing List , Rob Herring , dl-linux-imx , "shawnguo@kernel.org" , arm-soc Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBOb3YgMjYsIDIwMjAgYXQgMDI6MTU6MzVBTSArMDAwMCwgQWxpY2UgR3VvIHdyb3Rl Ogo+IAo+IAo+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiA+IEZyb206IGxpbnV4LWFy bS1rZXJuZWwgPGxpbnV4LWFybS1rZXJuZWwtYm91bmNlc0BsaXN0cy5pbmZyYWRlYWQub3JnPiBP bgo+ID4gQmVoYWxmIE9mIEFkYW0gRm9yZAo+ID4gU2VudDogMjAyMOW5tDEx5pyIMjXml6UgODo0 NQo+ID4gVG86IEFsaWNlIEd1byA8YWxpY2UuZ3VvQG54cC5jb20+Cj4gPiBDYzogZGV2aWNldHJl ZSA8ZGV2aWNldHJlZUB2Z2VyLmtlcm5lbC5vcmc+OyBQZW5nIEZhbiA8cGVuZy5mYW5AbnhwLmNv bT47Cj4gPiBTYXNjaGEgSGF1ZXIgPHMuaGF1ZXJAcGVuZ3V0cm9uaXguZGU+OyBMaW51eCBLZXJu ZWwgTWFpbGluZyBMaXN0Cj4gPiA8bGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZz47IEtyenlz enRvZiBLb3psb3dza2kgPGtyemtAa2VybmVsLm9yZz47IFJvYgo+ID4gSGVycmluZyA8cm9iaCtk dEBrZXJuZWwub3JnPjsgZGwtbGludXgtaW14IDxsaW51eC1pbXhAbnhwLmNvbT47IFNoYXduIEd1 bwo+ID4gPHNoYXduZ3VvQGtlcm5lbC5vcmc+OyBhcm0tc29jIDxsaW51eC1hcm0ta2VybmVsQGxp c3RzLmluZnJhZGVhZC5vcmc+Cj4gPiBTdWJqZWN0OiBSZTogW1BBVENIIHY2IDQvNF0gc29jOiBp bXg4bTogY2hhbmdlIHRvIHVzZSBwbGF0Zm9ybSBkcml2ZXIKPiA+IAo+ID4gT24gTW9uLCBOb3Yg MjMsIDIwMjAgYXQgODowNCBQTSBBbGljZSBHdW8gPGFsaWNlLmd1b0BueHAuY29tPiB3cm90ZToK PiA+ID4KPiA+ID4gRGlyZWN0bHkgcmVhZGluZyBvY290cCByZWdpc3RlciBkZXBlbmRzIG9uIHRo YXQgYm9vdGxvYWRlciBlbmFibGVzCj4gPiA+IG9jb3RwIGNsaywgd2hpY2ggaXMgbm90IGFsd2F5 cyBlZmZlY3RpdmUsIHNvIGNoYW5nZSB0byB1c2UgbnZtZW0gQVBJLgo+ID4gPiBVc2luZyBudm1l bSBBUEkgcmVxdWlyZXMgdG8gc3VwcG9ydCBkcml2ZXIgZGVmZXIgcHJvYmUgYW5kIHRodXMgY2hh bmdlCj4gPiA+IHNvYy1pbXg4bS5jIHRvIHVzZSBwbGF0Zm9ybSBkcml2ZXIuCj4gPiA+Cj4gPiA+ IFRoZSBvdGhlciByZWFzb24gaXMgdGhhdCBkaXJlY3RseSByZWFkaW5nIG9jb3RwIHJlZ2lzdGVy IGNhdXNlcyBrZXhlYwo+ID4gPiBrZXJuZWwgaGFuZyBiZWNhdXNlIHRoZSAxc3Qga2VybmVsIHJ1 bm5pbmcgd2lsbCBkaXNhYmxlIHVudXNlZCBjbGtzCj4gPiA+IGFmdGVyIGtlcm5lbCBib290cyB1 cCwgYW5kIHRoZW4gb2NvdHAgY2xrIHdpbGwgYmUgZGlzYWJsZWQgZXZlbiBpZgo+ID4gPiBib290 bG9hZGVyIGVuYWJsZXMgaXQuIFdoZW4ga2V4ZWMga2VybmVsLCBvY290cCBjbGsgbmVlZHMgdG8g YmUKPiA+ID4gZW5hYmxlZCBiZWZvcmUgcmVhZGluZyBvY290cCByZWdpc3RlcnMsIGFuZCBudm1l bSBBUEkgd2l0aCBwbGF0Zm9ybQo+ID4gPiBkcml2ZXIgc3VwcG9ydGVkIGNhbiBhY2NvbXBsaXNo IHRoaXMuCj4gPiA+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IEFsaWNlIEd1byA8YWxpY2UuZ3VvQG54 cC5jb20+Cj4gPiA+IC0tLQo+ID4gPgo+ID4gVGhlIHBhdGNoIHJlYWRzIFY2LCBidXQgdGhlIGNo YW5nZSBsb2cgb25seSBzaG93cyBWMi4gIENhbiB5b3UgZWxhYm9yYXRlIG9uCj4gPiB3aGF0IGhh cyBjaGFuZ2VkIGJldHdlZW4gVjIgYW5kIFY2Pwo+ID4gCj4gPiBhZGFtCj4gCj4gSGksCj4gCj4g U29ycnkuIFRoZSBvcmRlciBvZiBjaGFuZ2xvZyBpcyByZXZlcnNlZC4gVGhhbmsgQWRhbSBmb3Ig cG9pbnRpbmcgb3V0IHRoZSBwcm9ibGVtLCBhbmQgdGhhbmsgS3J6eXN6dG9mIGZvciByZXZpZXdp bmcgbXkgcGF0Y2guCj4gRG8gSSBuZWVkIHRvIHJlc2VuZCB0aGUgcGF0Y2hzZXQgd2l0aCB0aGUg Y29ycmVjdCBjaGFuZ2Vsb2cgb3JkZXI/CgpObywgbm8gbmVlZC4KCkJlc3QgcmVnYXJkcywKS3J6 eXN6dG9mCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg==