From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 894A2C56202 for ; Thu, 26 Nov 2020 13:27:18 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 767F621D1A for ; Thu, 26 Nov 2020 13:27:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VbjCL5hP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 767F621D1A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51118 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiHIp-0002Ow-Go for qemu-devel@archiver.kernel.org; Thu, 26 Nov 2020 08:27:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43742) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiHH5-0001b3-I5 for qemu-devel@nongnu.org; Thu, 26 Nov 2020 08:25:27 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:25688) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kiHH0-00024t-QT for qemu-devel@nongnu.org; Thu, 26 Nov 2020 08:25:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606397120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Y7jh8pQtnRJpFKFr9TucWJZ8bJh+BuzJOonrExBkq0k=; b=VbjCL5hPDmzGe8MV53Ov1rE7WjJ6uWxtu/AOabyHwPb5f2VNR2XBAdyiJardb1wjuNFP/d ebHJGD0FoBUBKaw/7Tms9WUucH5N26ogfNcoR5StAUIllUmg1bwc9zhYgS3gQDncqN/AP7 MGf/7wWxbyt1SgHZuQe5TbbMsKOvVpw= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-501-PehRY6nsMiG67AMB5fUDKg-1; Thu, 26 Nov 2020 08:25:18 -0500 X-MC-Unique: PehRY6nsMiG67AMB5fUDKg-1 Received: by mail-wr1-f69.google.com with SMTP id z13so1287446wrm.19 for ; Thu, 26 Nov 2020 05:25:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Y7jh8pQtnRJpFKFr9TucWJZ8bJh+BuzJOonrExBkq0k=; b=SRhj+rwRzYwLXwVkxhdU2Y3Vv8NZIgmqqkssR/0uyP+EHbmOrMlkd6qCuzDvTlWrT7 H5KX9DtmAh7vyzgp0jXqUCfKdShSf+UIGwDoDDPBvaxdezpzJAV1CzDvAIggeBwKYlMN 6v/Hiz9kZrKFktvKHc7iQsJ2OU6Z2lY1ZUU6Nt7QHmYtl1zOubsnUKb4CJrDssoW+dMq DTaoUaKQKZ2E/GY8f08ybgKcbbVPWoYTYhRaaAy2l0YVQkelKcnV8Dwtd+IuvYMOYjMP fWQSonK0sLNUAWYFGeDkiyqKuZZCtTQf1694LGdOxP3O3cESH4LzjTaVW+RrThSql9Me X1dQ== X-Gm-Message-State: AOAM533nfL6uUeRX60m0j5GXXR555AsPZDnUPXwK9s2iNyR2Rpp2ubLH PcPfuv2cTeVC/33l3FVxfNgr/0K/LFt9BIyB9HS+74cvdM4c22uwxTA7fYgP6XGBT2z1C4La6Kd hLbrqO92F6C7CfVs= X-Received: by 2002:a7b:c5c6:: with SMTP id n6mr3313687wmk.131.1606397117612; Thu, 26 Nov 2020 05:25:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJwbC0NTLOkXr2BsKMAePXaPZUET44Hj7G5NoME88+x80cxKlo9wiHkUDYNiTtkYFfDR2bk5wg== X-Received: by 2002:a7b:c5c6:: with SMTP id n6mr3313661wmk.131.1606397117405; Thu, 26 Nov 2020 05:25:17 -0800 (PST) Received: from redhat.com (bzq-79-176-44-197.red.bezeqint.net. [79.176.44.197]) by smtp.gmail.com with ESMTPSA id s4sm8953961wru.56.2020.11.26.05.25.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:25:16 -0800 (PST) Date: Thu, 26 Nov 2020 08:25:14 -0500 From: "Michael S. Tsirkin" To: Laszlo Ersek Subject: Re: [DISCUSSION] Allow ACPI default OEM ID and OEM table ID fields to be set. Message-ID: <20201126082033-mutt-send-email-mst@kernel.org> References: <20201125132711.jqb7znxu5jpoanwi@tartarus> <20201125133251.GI30079@redhat.com> <20201125110221-mutt-send-email-mst@kernel.org> <20201125201322.urze5b7vwaa2t5sy@tartarus> <20201126051838-mutt-send-email-mst@kernel.org> <0d63ed0e-4dae-9f7e-9512-45c94e1968f0@redhat.com> MIME-Version: 1.0 In-Reply-To: <0d63ed0e-4dae-9f7e-9512-45c94e1968f0@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Antoine Damhet , Igor Mammedov , "Richard W.M. Jones" , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Nov 26, 2020 at 01:51:43PM +0100, Laszlo Ersek wrote: > On 11/26/20 12:09, Michael S. Tsirkin wrote: > > On Wed, Nov 25, 2020 at 09:13:22PM +0100, Antoine Damhet wrote: > >> On Wed, Nov 25, 2020 at 11:04:55AM -0500, Michael S. Tsirkin wrote: > >>> On Wed, Nov 25, 2020 at 01:32:51PM +0000, Richard W.M. Jones wrote: > >>>> On Wed, Nov 25, 2020 at 02:27:11PM +0100, Antoine Damhet wrote: > >>>>> Hello, > >>>>> > >>>>> We recently found out that some softwares are effectively crashing > >>>>> when they detect qemu's `OEM ID` or `OEM table ID` in the ACPI tables. > >>>>> > >>>>> I see no reason not to expose the setting to the user/command-line. A > >>>>> previous patch has been submitted in 2015[1] but did not get through > >>>>> because (if I understand correctly) using the IDs on the `SLIC`, `BXPC` > >>>>> and `RSDT` tables were enough at the time. > >>>>> > >>>>> If you agree, I am willing to forward port the patches of M. Jones but I > >>>>> need to ask how it would work `Signed-Off`-wise ? > >>>> > >>>> On this point, the patch I sent was actually written by > >>>> Michael Tokarev, I was only trying to get them upstream. > >>>> > >>>> Rich. > >>> > >>> I think at least one of the issues is that e.g. UEFI at least > >>> seems to assume unique OEM table IDs e.g. for SSDTs. > >>> > >>> So let's try to be more specific please, which software > >>> crashes, what does it want to see and in which table. > >> > >> I'm sorry I cannot give you the name of the crashing software due to a > >> company policy. But I can tell you that if either `BOCHS ` or `BXPC` is > >> present in any of the tables it will crash. Any (or at least the few > >> that I threw at it) other string will work so it seems it's some kind > >> of DRM-related hypervisor detection. > > > > Hmm I'm not sure how far we want to go with this. If software vendors > > want to detect a hypervisor there will always be a way. > > How are we sure we are not starting an arms race here? > > > > Also which of the IDs matter? OEMID? OEM Table ID? Creator ID? > > > > > >> As for the uniqueness of the table IDs, I guess it would be sane to keep > >> the same pattern (id+table sig) but allowing the first 4 bytes to be > >> overridden. > >> > >> [...] > > > > It's certainly possible, it's just very specific to just this DRM scheme. > > Not sure what's a better way to do it: > > qemu -acpidefault oem_id=ABCD,oem_table_id=EFGHIJKL > > is probably going too far since then table IDs are not unique. > > > > Also I'd probably use machine properties for this, the need here > > is baroque enough that we don't want a dedicated option. > > Minimally, I dislike the partial overlap with the existent "-acpitable" > switch. > > Thanks > Laszlo Well the existing -acpitable is very powerful and easy to break guests with, it can not really be fully supported. > > > >> > >> -- > >> Antoine 'xdbob' Damhet > >