From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB54EC63697 for ; Thu, 26 Nov 2020 15:33:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6ECF52087C for ; Thu, 26 Nov 2020 15:33:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390011AbgKZPdY (ORCPT ); Thu, 26 Nov 2020 10:33:24 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:13801 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731658AbgKZPdX (ORCPT ); Thu, 26 Nov 2020 10:33:23 -0500 X-Originating-IP: 86.194.74.19 Received: from localhost (lfbn-lyo-1-997-19.w86-194.abo.wanadoo.fr [86.194.74.19]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 139FF24001A; Thu, 26 Nov 2020 15:33:20 +0000 (UTC) Date: Thu, 26 Nov 2020 16:33:20 +0100 From: Alexandre Belloni To: Lee Jones Cc: linus.walleij@linaro.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Russell King , Nicolas Ferre , Ludovic Desroches Subject: Re: [PATCH v3 16/25] arch: arm: mach-at91: pm: Move prototypes to mutually included header Message-ID: <20201126153320.GE1296649@piout.net> References: <20200713144930.1034632-1-lee.jones@linaro.org> <20200713144930.1034632-17-lee.jones@linaro.org> <20201112093918.GV2063125@dell> <20201126132840.GD2455276@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201126132840.GD2455276@dell> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 26/11/2020 13:28:40+0000, Lee Jones wrote: > Both the caller and the supplier's source file should have access to > the include file containing the prototypes. > > Fixes the following W=1 kernel build warning(s): > > drivers/pinctrl/pinctrl-at91.c:1637:6: warning: no previous prototype for ‘at91_pinctrl_gpio_suspend’ [-Wmissing-prototypes] > 1637 | void at91_pinctrl_gpio_suspend(void) > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/pinctrl/pinctrl-at91.c:1661:6: warning: no previous prototype for ‘at91_pinctrl_gpio_resume’ [-Wmissing-prototypes] > 1661 | void at91_pinctrl_gpio_resume(void) > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > Cc: Russell King > Cc: Nicolas Ferre > Cc: Alexandre Belloni > Cc: Ludovic Desroches > Signed-off-by: Lee Jones Acked-by: Alexandre Belloni This is my ack in case Linus wants that to go through the pinctrl tree, which is fine with me. I can also take it through the at91 tree with Linus' ack. > --- > arch/arm/mach-at91/pm.c | 19 ++++++++----------- > drivers/pinctrl/pinctrl-at91.c | 2 ++ > include/soc/at91/pm.h | 16 ++++++++++++++++ > 3 files changed, 26 insertions(+), 11 deletions(-) > create mode 100644 include/soc/at91/pm.h > > diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c > index 120f9aa6fff32..90dcdfe3b3d0d 100644 > --- a/arch/arm/mach-at91/pm.c > +++ b/arch/arm/mach-at91/pm.c > @@ -17,6 +17,8 @@ > #include > #include > > +#include > + > #include > #include > #include > @@ -25,17 +27,6 @@ > #include "generic.h" > #include "pm.h" > > -/* > - * FIXME: this is needed to communicate between the pinctrl driver and > - * the PM implementation in the machine. Possibly part of the PM > - * implementation should be moved down into the pinctrl driver and get > - * called as part of the generic suspend/resume path. > - */ > -#ifdef CONFIG_PINCTRL_AT91 > -extern void at91_pinctrl_gpio_suspend(void); > -extern void at91_pinctrl_gpio_resume(void); > -#endif > - > struct at91_soc_pm { > int (*config_shdwc_ws)(void __iomem *shdwc, u32 *mode, u32 *polarity); > int (*config_pmc_ws)(void __iomem *pmc, u32 mode, u32 polarity); > @@ -326,6 +317,12 @@ static void at91_pm_suspend(suspend_state_t state) > static int at91_pm_enter(suspend_state_t state) > { > #ifdef CONFIG_PINCTRL_AT91 > + /* > + * FIXME: this is needed to communicate between the pinctrl driver and > + * the PM implementation in the machine. Possibly part of the PM > + * implementation should be moved down into the pinctrl driver and get > + * called as part of the generic suspend/resume path. > + */ > at91_pinctrl_gpio_suspend(); > #endif > > diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c > index 72edc675431ce..0a7e10d39505c 100644 > --- a/drivers/pinctrl/pinctrl-at91.c > +++ b/drivers/pinctrl/pinctrl-at91.c > @@ -23,6 +23,8 @@ > /* Since we request GPIOs from ourself */ > #include > > +#include > + > #include "pinctrl-at91.h" > #include "core.h" > > diff --git a/include/soc/at91/pm.h b/include/soc/at91/pm.h > new file mode 100644 > index 0000000000000..7a41e53a3ffa3 > --- /dev/null > +++ b/include/soc/at91/pm.h > @@ -0,0 +1,16 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Atmel Power Management > + * > + * Copyright (C) 2020 Atmel > + * > + * Author: Lee Jones > + */ > + > +#ifndef __SOC_ATMEL_PM_H > +#define __SOC_ATMEL_PM_H > + > +void at91_pinctrl_gpio_suspend(void); > +void at91_pinctrl_gpio_resume(void); > + > +#endif /* __SOC_ATMEL_PM_H */ > -- > 2.25.1 -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com