From: Jan Kara <jack@suse.cz> To: Ted Tso <tytso@mit.edu> Cc: <linux-ext4@vger.kernel.org>, Jan Kara <jack@suse.cz> Subject: [PATCH 03/12] ext4: Standardize error message in ext4_protect_reserved_inode() Date: Fri, 27 Nov 2020 12:33:56 +0100 [thread overview] Message-ID: <20201127113405.26867-4-jack@suse.cz> (raw) In-Reply-To: <20201127113405.26867-1-jack@suse.cz> We use __ext4_error() when ext4_protect_reserved_inode() finds filesystem corruption. However EXT4_ERROR_INODE_ERR() is perfectly capable of reporting all the needed information. So just use that. Signed-off-by: Jan Kara <jack@suse.cz> --- fs/ext4/block_validity.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/fs/ext4/block_validity.c b/fs/ext4/block_validity.c index 8e6ca23ed172..13ffda871227 100644 --- a/fs/ext4/block_validity.c +++ b/fs/ext4/block_validity.c @@ -176,12 +176,10 @@ static int ext4_protect_reserved_inode(struct super_block *sb, err = add_system_zone(system_blks, map.m_pblk, n, ino); if (err < 0) { if (err == -EFSCORRUPTED) { - __ext4_error(sb, __func__, __LINE__, - -err, map.m_pblk, - "blocks %llu-%llu from inode %u overlap system zone", - map.m_pblk, - map.m_pblk + map.m_len - 1, - ino); + EXT4_ERROR_INODE_ERR(inode, -err, + "blocks %llu-%llu from inode overlap system zone", + map.m_pblk, + map.m_pblk + map.m_len - 1); } break; } -- 2.16.4
next prev parent reply other threads:[~2020-11-27 11:34 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-27 11:33 [PATCH 00/12] ext4: Various fixes of ext4 handling of fs errors Jan Kara 2020-11-27 11:33 ` [PATCH 01/12] ext4: Don't remount read-only with errors=continue on reboot Jan Kara 2020-11-29 21:33 ` Andreas Dilger 2020-12-16 4:59 ` Theodore Y. Ts'o 2020-11-27 11:33 ` [PATCH 02/12] ext4: Remove redundant sb checksum recomputation Jan Kara 2020-11-29 22:11 ` Andreas Dilger 2020-11-30 10:59 ` Jan Kara 2020-12-16 5:01 ` Theodore Y. Ts'o 2020-11-27 11:33 ` Jan Kara [this message] 2020-11-29 21:39 ` [PATCH 03/12] ext4: Standardize error message in ext4_protect_reserved_inode() Andreas Dilger 2020-12-16 5:04 ` Theodore Y. Ts'o 2020-11-27 11:33 ` [PATCH 04/12] ext4: Make ext4_abort() use __ext4_error() Jan Kara 2020-11-29 22:12 ` Andreas Dilger 2020-12-16 5:07 ` Theodore Y. Ts'o 2020-11-27 11:33 ` [PATCH 05/12] ext4: Move functions in super.c Jan Kara 2020-11-29 22:13 ` Andreas Dilger 2020-12-16 5:09 ` Theodore Y. Ts'o 2020-11-27 11:33 ` [PATCH 06/12] ext4: Simplify ext4 error translation Jan Kara 2020-11-29 21:57 ` Andreas Dilger 2020-12-16 5:11 ` Theodore Y. Ts'o 2020-11-27 11:34 ` [PATCH 07/12] ext4: Defer saving error info from atomic context Jan Kara 2020-12-16 5:31 ` Theodore Y. Ts'o 2020-12-16 5:40 ` Theodore Y. Ts'o 2020-12-16 9:56 ` Jan Kara 2020-11-27 11:34 ` [PATCH 08/12] ext4: Combine ext4_handle_error() and save_error_info() Jan Kara 2020-12-14 19:23 ` harshad shirwadkar 2020-12-16 10:11 ` Jan Kara 2020-12-16 10:24 ` Jan Kara 2020-11-27 11:34 ` [PATCH 09/12] ext4: Drop sync argument of ext4_commit_super() Jan Kara 2020-12-14 19:25 ` harshad shirwadkar 2020-11-27 11:34 ` [PATCH 10/12] ext4: Protect superblock modifications with a buffer lock Jan Kara 2020-11-27 11:34 ` [PATCH 11/12] ext4: Save error info to sb through journal if available Jan Kara 2020-11-27 11:34 ` [PATCH 12/12] ext4: Use sbi instead of EXT4_SB(sb) in ext4_update_super() Jan Kara 2020-12-14 19:07 ` [PATCH 00/12] ext4: Various fixes of ext4 handling of fs errors harshad shirwadkar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201127113405.26867-4-jack@suse.cz \ --to=jack@suse.cz \ --cc=linux-ext4@vger.kernel.org \ --cc=tytso@mit.edu \ --subject='Re: [PATCH 03/12] ext4: Standardize error message in ext4_protect_reserved_inode()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.