From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 581BDC63777 for ; Fri, 27 Nov 2020 22:55:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 258E922228 for ; Fri, 27 Nov 2020 22:55:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728495AbgK0WzA (ORCPT ); Fri, 27 Nov 2020 17:55:00 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:32952 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731413AbgK0Wgs (ORCPT ); Fri, 27 Nov 2020 17:36:48 -0500 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 33C1420033; Fri, 27 Nov 2020 23:36:17 +0100 (CET) Date: Fri, 27 Nov 2020 23:36:15 +0100 From: Sam Ravnborg To: Joe Perches Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones , Aditya Pakki , Alexander Klimov , Alex Dewar , Antonino Daplas , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Benjamin Herrenschmidt , Daniel Vetter , Evgeny Novikov , Ferenc Bakonyi , Florian Tobias Schandinat , George Kennedy , Greg Kroah-Hartman , Gustavo Silva , Jani Nikula , Jason Yan , Jingoo Han , Jiri Slaby , Kristoffer Ericson , Laurent Pinchart , linux-nvidia@lists.surfsouth.com, Michal Januszewski , Mike Rapoport , Nathan Chancellor , Peilin Ye , Peter Rosin , Qilong Zhang , Randy Dunlap , Saeed Mirzamohammadi , Tetsuo Handa , Thomas Winischhofer , Thomas Zimemrmann , Vaibhav Gupta , Xiaofei Tan Subject: Re: [PATCH v1 02/28] video: fbcon: Use pr_debug() in fbcon Message-ID: <20201127223615.GA872093@ravnborg.org> References: <20201127195825.858960-1-sam@ravnborg.org> <20201127195825.858960-3-sam@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=Ibmpp1ia c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=8nJEP1OIZ-IA:10 a=VOK_sTC4ckVJP7rGVwkA:9 a=wPNLvfGTeEIA:10 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Hi Joe. On Fri, Nov 27, 2020 at 01:16:41PM -0800, Joe Perches wrote: > On Fri, 2020-11-27 at 20:57 +0100, Sam Ravnborg wrote: > > Replacing DPRINTK() statements with pr_debug fixes > > W=1 warnings. > > And moves to a more standard logging setup at the same time. > [] > > diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c > [] > > @@ -1015,9 +1007,9 @@ static const char *fbcon_startup(void) > >   rows /= vc->vc_font.height; > >   vc_resize(vc, cols, rows); > >   > > > > - DPRINTK("mode: %s\n", info->fix.id); > > - DPRINTK("visual: %d\n", info->fix.visual); > > - DPRINTK("res: %dx%d-%d\n", info->var.xres, > > + pr_debug("mode: %s\n", info->fix.id); > > + pr_debug("visual: %d\n", info->fix.visual); > > + pr_debug("res: %dx%d-%d\n", info->var.xres, > >   info->var.yres, > >   info->var.bits_per_pixel); > > It'd be nicer to reindent the subsequent lines too. > > > @@ -3299,7 +3291,7 @@ static void fbcon_exit(void) > >   > > > >   if (info->queue.func) > >   pending = cancel_work_sync(&info->queue); > > - DPRINTK("fbcon: %s pending work\n", (pending ? "canceled" : > > + pr_debug("fbcon: %s pending work\n", (pending ? "canceled" : > >   "no")); > > perhaps: > > pr_debug("fbcon: %s pending work\n", pending ? "canceled" : "no"); > Good suggestions, I will update accordingly in v2 or when applying in case someone acks/r-b's the patches. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4B3AC63777 for ; Fri, 27 Nov 2020 22:36:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4EA5822228 for ; Fri, 27 Nov 2020 22:36:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EA5822228 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4E5066EE98; Fri, 27 Nov 2020 22:36:28 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id BAEB46EE98 for ; Fri, 27 Nov 2020 22:36:26 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 33C1420033; Fri, 27 Nov 2020 23:36:17 +0100 (CET) Date: Fri, 27 Nov 2020 23:36:15 +0100 From: Sam Ravnborg To: Joe Perches Subject: Re: [PATCH v1 02/28] video: fbcon: Use pr_debug() in fbcon Message-ID: <20201127223615.GA872093@ravnborg.org> References: <20201127195825.858960-1-sam@ravnborg.org> <20201127195825.858960-3-sam@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=Ibmpp1ia c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=8nJEP1OIZ-IA:10 a=VOK_sTC4ckVJP7rGVwkA:9 a=wPNLvfGTeEIA:10 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Vaibhav Gupta , Tetsuo Handa , dri-devel@lists.freedesktop.org, Peter Rosin , Michal Januszewski , Laurent Pinchart , linux-nvidia@lists.surfsouth.com, Jiri Slaby , Florian Tobias Schandinat , Evgeny Novikov , Lee Jones , Saeed Mirzamohammadi , Daniel Vetter , Thomas Winischhofer , Thomas Zimemrmann , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Jani Nikula , Aditya Pakki , Xiaofei Tan , Nathan Chancellor , Alex Dewar , Jason Yan , Greg Kroah-Hartman , Qilong Zhang , Randy Dunlap , Gustavo Silva , Ferenc Bakonyi , George Kennedy , Kristoffer Ericson , Alexander Klimov , Jingoo Han , Peilin Ye , Mike Rapoport Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Joe. On Fri, Nov 27, 2020 at 01:16:41PM -0800, Joe Perches wrote: > On Fri, 2020-11-27 at 20:57 +0100, Sam Ravnborg wrote: > > Replacing DPRINTK() statements with pr_debug fixes > > W=3D1 warnings. > > And moves to a more standard logging setup at the same time. > [] > > diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/cor= e/fbcon.c > [] > > @@ -1015,9 +1007,9 @@ static const char *fbcon_startup(void) > > =A0 rows /=3D vc->vc_font.height; > > =A0 vc_resize(vc, cols, rows); > > =A0 > > = > > - DPRINTK("mode: %s\n", info->fix.id); > > - DPRINTK("visual: %d\n", info->fix.visual); > > - DPRINTK("res: %dx%d-%d\n", info->var.xres, > > + pr_debug("mode: %s\n", info->fix.id); > > + pr_debug("visual: %d\n", info->fix.visual); > > + pr_debug("res: %dx%d-%d\n", info->var.xres, > > =A0 info->var.yres, > > =A0 info->var.bits_per_pixel); > = > It'd be nicer to reindent the subsequent lines too. > = > > @@ -3299,7 +3291,7 @@ static void fbcon_exit(void) > > =A0 > > = > > =A0 if (info->queue.func) > > =A0 pending =3D cancel_work_sync(&info->queue); > > - DPRINTK("fbcon: %s pending work\n", (pending ? "canceled" : > > + pr_debug("fbcon: %s pending work\n", (pending ? "canceled" : > > =A0 "no")); > = > perhaps: > = > pr_debug("fbcon: %s pending work\n", pending ? "canceled" : "no"); > = Good suggestions, I will update accordingly in v2 or when applying in case someone acks/r-b's the patches. Sam _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel